Commit Graph

12999 Commits

Author SHA1 Message Date
Celotajs
190d0a0384 Replace alert usage with tgui_alert (#58419)
Pretty much every alert() call is replaced with tgui_alert, except one I replaced with tgalert as a fallback. If tgui_alert exists, why not use it?
2021-05-20 22:43:27 +12:00
tralezab
67a3ce53af Gives curators a console for printing portraits not in the round onto canvases (#59146) 2021-05-20 03:05:15 -07:00
InsaneRed
fd267096fd Takes away emag from medical borgs, and gives it to sabo borgs. (#59100) 2021-05-19 02:39:52 -07:00
Kylerace
f556296645 Touches up cameranet code (#59165)
makes it add only one vis_contents to all turfs for static (adding and removing when ai moves in/out of chunk gone)

original pr: #58522
basically the same but ai's moving in/out of the chunk doesnt affect vis_contents anymore because that was really racking up tidi for some reason.
Why It's Good For The Game

less maptick because theres only 1 vis_contents added instead of 2 and general optimizations to cameranet code
2021-05-19 19:44:04 +12:00
RandomGamer123
457685a8b6 Buckling to wheelchairs no longer gives people the immobile trait, allowing paraplegics to do more things (#59097) 2021-05-16 21:04:26 -07:00
Ryll Ryll
b7d2e5ac08 Dead people can no longer offer items (#59106) 2021-05-15 01:51:59 -07:00
Kylerace
0bc876423a fixes issue with ghosts being able to affect the world, oversight from the crossed refactor (#59010)
* as anything in _SendSignal

* Revert "as anything in _SendSignal"

This reverts commit 350c4b33d975d25003afb2cab2458a3026676559.

* ghosts can no longer affect the world (hopefully)
2021-05-14 16:46:59 -04:00
Mothblocks
53ed6c4641 Fix regal rat runtime (#59061) 2021-05-14 16:44:32 -04:00
tralezab
132a755aa3 Componentizes Duffelbag Curse and turns it into an RPGloot modifier (+ curse announcement element) (#59029)
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
2021-05-14 01:03:45 -07:00
John Willard
fe10045f0d Gives skeletons NOTRANSSTING trait (#58994) 2021-05-12 02:02:12 -07:00
Celotajs
991b5f074a Tidy HTML folder (#58761)
This PR aims to make the HTML folder a little more organized, as well as remove a few unused files.
Why It's Good For The Game

Doesn't change anything for the player, however makes the files more organized.
2021-05-11 09:35:57 +12:00
tralezab
332fa0b3d0 fixes master (adds a name to the venomous prefix, fixes bad signal in udders.dm) (#59007)
* Update prefixes.dm

* widening the scope to be fixing master in general
2021-05-09 19:45:12 -07:00
tralezab
ea57e3f960 Kills BOTH /poison paths by turning poisonous into an element. (+fantasty prefix, sanity on attackingtarget signal, and more) (#58882) 2021-05-09 16:49:59 -07:00
tralezab
0823302f30 GOOFUDDERS: YOU CAN MILK ANYTHING (You can only milk cows, goats gutlunches but with componentized goodcode) (#58910)
Co-authored-by: 81Denton <32391752+81Denton@users.noreply.github.com>
Co-authored-by: Qustinnus <Floydje123@hotmail.com>
2021-05-09 16:49:31 -07:00
Jonathan Rubenstein
770148de06 Replace Maint. Drone machinery whitelist with last touched check & other tweaks (#58802)
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
2021-05-08 16:12:31 -07:00
BootlegBow
a0b2686d38 Fixes flypeople moffin eating (#58923) 2021-05-08 01:15:47 -07:00
Timberpoes
ff47abe825 Refactors playtime tracking code. (#58186) 2021-05-08 09:36:22 +03:00
tralezab
1928826bc7 Refactors pet bonuses to be an element (#58912) 2021-05-07 15:26:59 -07:00
Kylerace
08df8798ce (code bounty) refactors all uses of Crossed() and Uncrossed() into signals sent to loc, tracked by connect_loc (#58340)
Co-authored-by: Jared-Fogle <35135081+Mothblocks@users.noreply.github.com>
Co-authored-by: Emmett Gaines <ninjanomnom@gmail.com>
2021-05-07 03:54:03 -07:00
tralezab
ff3a34a6b4 refactors is_flying_animal into simple_flight element (#58914) 2021-05-06 23:38:53 -07:00
Fikou
241ce53d37 moves sdql spell to vv dropdown (#58911) 2021-05-06 23:17:09 -07:00
ArcaneDefence
ed117d51e5 Fixes felinid disliked foods (#58891) 2021-05-06 23:15:26 -07:00
LemonInTheDark
c906c44393 Fixes a fuck ton more harddels (#58779)
Redoes how geese handle eating shit, it was fucking stupid and caused harddels, and while this method is technically slower in the best case, it's a fucking goose
Fixes action related harddels, I hate how they work but at least this way they won't hold refs.
Fixes the hierophont causing its beacon to harddel
Removes the M variable from megafauna actions, it was used like a typed owner and caused harddels, so I burned it
Fixes target and targets_from harddels, replaces all setters of target with LoseTarget and GiveTarget, which should help maintain behavior. I'm not sure if this breaks anything, but if it does we should fix the assumptions that code makes instead of reverting this change
Fixes more area_senstive_contents related harddels, we need to allow the mob to move before clearing out its list.
Fixes marked object harddels (I'm coming for you admin team)
Fixes a language based human harddel
Fixes managed overlay related harddels (This was just emissive blockers, but I think this is a good safety net to have. If we clear the overlay list we should clear this one as well)
Fixes bot core harddels, I hate the fact that this exists but it has no reason to know who its owner is
Adds a walk(src, 0) to simple_animal destroy, it's the best bang for the buck in terms of stopping spurious harddels. Walk related harddels aren't that expensive in the first place, since byond does the same thing I'm doing here, but this makes finding mob harddels easier, so let's go with it
I fixed another source of part harddels, I hate fullupgrade so much
Fixes all the sound loop harddels
2021-05-05 10:57:27 -04:00
ATH1909
16ae23e0b6 fixes some species trait issues (#58879) 2021-05-05 01:50:33 -07:00
ZeWaka
b86aaf3307 Fixes bitwise flag negation errors. (#58870)
These have been in the codebase for many years. Love, ZeWaka
2021-05-05 01:37:56 -04:00
LemonInTheDark
4e53d8c4bc Removes some boiler plate from working with atmos code (#58885)
Everything that called turf.assume_air and turf.remove_air was already updating turfs, and all that not tying

the two together did was add more boiler plate, and break things when people forgot about it.

This shouldn't add any overhead outside of hotspots, but I think that's trivial
2021-05-05 01:31:30 -04:00
Seris02
ff2f6abe83 Sort the majority of the rest of the unsorted chat (#58821)
* FINALLY IT IS DONE FUCK

* tip of the round into ooc

* adds cyopod chat messages to the info chat filter

* last one I promise probably, mob spawner messages to info filter

* holoparasite, round will start in x and keybinding conflict to respective filters

* removed motd from constants, made it infoplain surrounded instead

* changed info to infoplain
2021-05-05 05:57:40 +03:00
Emmett Gaines
4367cb09bd Adds new wrinkles to monkey brains (#58631)
This does a variety of improvements to monkey ai that I got drawn into after fixing a relatively simple bug with monkeys and guns. This pr is in support of #58565 so that in the rare chance pun pun gets a gun, they know how to use it. Previously #16630 made it so monkeys could use guns but semi-recently that was broken. Now that's fixed and in addition some other monkey ai capabilities were enhanced, read the changelog for the full list.
2021-05-04 08:32:31 +01:00
Fikou
0e8e403a5b fixes fake chasms not dropping floortiles and borgs having their floor tiles deleted when reskinning (#58853) 2021-05-03 23:50:15 -07:00
Nick
e3b1e3c8c5 Security citations are now logged to the DB (#58827)
Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com>
2021-05-03 05:17:04 -07:00
Fikou
c0f9d2e7e8 [READY] Tile Reskinning 2: Epic Winaloo (#58801)
extends the tile reskinning functionality to iron, bronze, plastitanium, carpet and pod floors
makes a bit of tile code better
moves some paths around, like elevator shafts being plating instead of floor
adds rotating as a tile reskinning function available on chapel or side floors for example

lets players customize any rooms they would want much more than it is possible now, allowing for more creativity
2021-05-01 02:20:45 -07:00
LemonInTheDark
27385e9d70 Converts the atmos senstive component over to connect_loc (#58266)
* Makes all uses of atmos_senstive pass in mapload as context

* Converts atmos senstive to connect_loc, does some general cleanup to the element, and makes it check the state of the tile the thing is on assuming creation didn't happen as a part of map loading

* Updates connect loc to match the new arg list
2021-04-30 18:35:47 -07:00
Arkatos1
db5420342f Converts space carps to GAGS (#58710) 2021-04-30 03:42:13 -07:00
LemonInTheDark
a924226b50 React optimization + event based processing for tanks, canisters and pipelines (#58418)
* Makes tanks only process when needed, rather then doing it constantly

* Makes portable atmos machines only process when needed, makes adding and removing atmos machinery cheaper, makes the tank processing logic actually work properly

* Makes pipelines only react() when their mix changes, fixes a ton of misuses of update_parents that were causing about 10ms of load for atmos just from reconcile_air()

* Adds in a new reaction framework alongside the old one for profiling related reasons

* whoops

* Cleanup, removes the react profiling code, I've chosen a direction to go here

* Cleans up some code, adds comments describing how to interact with portable atmos machines/tanks and their
mixes, adds a blurb to Atmospherics.md about the topic as a whole, leaves a line of bread for someone to follow
if I get hit by a bus in 2 days (Knock on wood)

* Removes priority from reactions, moves priority groups to the defines file

* whoops

* Converts air_contents to _air_contents, replaces all the out of file things that used it with return_air()

* Replaces the canister air contents uses, converts it back to air_contents, I decided I didn't like the _

* Fixes
2021-04-30 12:29:29 +02:00
ATH1909
ef1f79d7e3 The shivering symptom now actually chills you like it says it does instead of heating you up (#58181)
* ice ice baby

* broader species compatibility

* are you HAPPY NOW?

* should make the code compile

* Apply suggestions from code review

Co-authored-by: Aki Ito <11748095+ExcessiveUseOfCobblestone@users.noreply.github.com>
2021-04-30 01:42:11 -04:00
TiviPlus
e07dc7096d Remove excessively defined snail offsets (#58731)
it annoyed me
2021-04-27 16:56:25 -07:00
TemporalOroboros
9f598a9662 Makes the explosive compressor and blastcannon actually use the TTVs they're given + the explosion changes to support that. (#58015)
* Adds explosion SFX to the blastcannon and explosive compressor

- Extracts the explosion SFX and screenshake proc from the SSexplosions explosion handling proc and lets the explosive compressor and blastcannon use it.

* Miscellaneous changes

- Adds defines for the internal explosion arglist keys
- Reverses the values of the explosion severity defines
- Changes almost everything that uses `/proc/explosion` to use named arguments

- Removes a whole bunch of argname = 0 in explosion calls.

* Removes named callback arguments.

* Changes the explosion signals to just use the arguments list

Adds a simple framework to let objects respond to explosions occurring inside of them.

Changes a whole bunch of explosions to use the object being exploded as the origin of the explosion rather than the turf the object is on.

Makes the explosive compressor and blastcannon actually use the TTVs they are given.

Adds support for things responding to internal explosions.
Less snowflake code for the explosive compressor and blastcannon calculating bomb range.*
Less confusing explosion severity defines.
Less opaque explosion arguments

*does not guarantee that the solution to letting them actually use the TTV is any less snowflake.
2021-04-26 17:31:25 -07:00
Celotajs
76fb2e1712 Convert changelog to TGUI (#58593)
This pull request converts the changelog to TGUI. 
Note: Old unused changelog files will be automatically removed on the next changelog run
Why It's Good For The Game

More consistent UI, ability to view all historic logs.
Changelog

cl Celotajs
refactor: Converted the changelog popup to TGUI
/cl
2021-04-27 08:41:56 +12:00
GuillaumePrata
d8873f5e4a Jelly people can eat toxin food (#58698)
What I assume to be an oversight makes jellypeople and subtypes inherited their toxic_food from humans who can't eat TOXIN kinds of food, including slime based food like slime cakes and donuts.
Eating slime food would get them disgusted, even if it's basically their blood and how they grow.
They now have an NULL for toxin food, like fly people.

Most people would assume that jellypeople can safely eat slime based food...
2021-04-26 02:04:25 -07:00
Spookuni
f895534a32 Headcrab go fast (#58658)
Timber made me do this instead of doing it himself because apparently I break the game too much or something. :(

When changeling egg incubation times were moved over to delta time they weren't properly multiplied to maintain their 4 minute wait time while the egg hatched, instead taking 40 minutes.

Waiting 40 minutes as a changeling for your egg to hatch after biting a corpse isn't very fun.
2021-04-26 02:00:13 -07:00
Ghilker
0b28ea46f1 Fix multiz ventcrawling (#58531)
Allow mobs to travel through multiz adaptors,
fixes runtimes caused by ventcrawling
2021-04-26 01:53:08 -07:00
tralezab
88a9390abb Borgs can once again be chainstunned (#58696)
fixes #58274 (Borgs being unstunnable while stunned)

uh, if this is intended, then someone should lemmie know, close that issue, and i'll close this prr
2021-04-26 01:33:37 -07:00
tralezab
51e4d14918 freezes addictions and sanity during death (#58691) 2021-04-26 01:11:23 -07:00
tralezab
213fd616d8 fixes #58663 (Revs being able to convert blind people) (#58685)
eye and ear protection now consider blindness and deafness
2021-04-26 01:00:58 -07:00
tralezab
3302a25e18 simple animals with no attack no longer self nuzzle (#58684) 2021-04-26 00:59:27 -07:00
Swiftfeather
55e1dcf6bf Fixes a funny regex moment quoting half the file in weak editors (#58653) 2021-04-25 02:16:48 -07:00
Mothblocks
7e4de07506 Remove all gamemodes except Dynamic (#58470)
Removes all /datum/game_mode except dynamic. Eventually, all of mode and game_mode will be removed, and Dynamic will become an ingrained system. Every single other gamemode was unmaintained at best and poisoned other code at worst. Currently all tg servers run 24/7 Dynamic, so the time to act is now.

* Remove gamemode references from age checks

* Monkey

* Remove heretics

* Remove BBs

* Refactor uplinks and remove clown ops

* Remove nuke ops

* Removes and refactors cult

* Remove extended

* Remove and move out meteors

* Removes wizard

* Remove sandbox

* Remove changelings

* Remove traitors

* Remove revs

* Remove gangs

* Remove changing mode and voting for new gamemodes

* get_candidates signature fix

* Summon ERT and NERD in their own panel

* Remove some old unneeded age_check stuff

* Fix old signatures of get_uplink_items

* Use Extended like config for dynamic.json

* Fix discounted gear
2021-04-25 01:55:10 -07:00
RaveRadbury
c2dfe7418a Adds flavortext for trying to speak with a vow of silence (#58640)
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
2021-04-24 14:32:08 -07:00
Jonathan Rubenstein
c6369a6fe2 Add exp tracking for Maintenance Drones (#58386) 2021-04-23 17:19:25 -07:00
Trigg
5641e1f66b Dummies equipping outfits no longer call equipped (#58597) 2021-04-23 15:43:45 -07:00