Resurrection of #40819 after I was reminded that rebasing is hard.
cl QualityVan
fix: Hugging skeletons is now possible
/cl
Fixes#40672
The if not in crit checks in human_defense and carbon_defense could be removed because they should only be reached when they're either true or irrelevant.
This allows us to more easily keep track of speed modifiers which only affect certain move modes. Also cleans up a small bit of movespeed and mood code while I'm at it.
1. there was an option for cancel when the input already had a cancel button
2. hitting either of these cancels did nothing, and it continued on with the
transformation
3. there were some 1's and 0's that shoulda been TRUE and FALSE
Aiming to implement the framework oranges has detailed in https://tgstation13.org/phpBB/viewtopic.php?f=10&t=19102
Moves canmove to a bitflag in a new variable called mobility_flags, that will allow finer grain control of what someone can do codewise, for example, letting them move but not stand up, or stand up but not move.
Adds Immobilize()d status effect that freezes movement but does not prevent anything else.
Adds Paralyze()d which is oldstun "You can't do anything at all and knock down).
Stun() will now prevent any item/UI usage and movement (which is similar to before).
Knockdown() will now only knockdown without preventing item usage/movement.
People knocked down will be able to crawl at softcrit-speeds
Refactors some /mob variables and procs to /mob/living.
update_canmove() refactored to update_mobility() and will handle mobility_flags instead of the removed canmove
cl
rscadd: Crawling is now possible if you are down but not stunned. Obviously, you will be slower.
/cl
Refactors are done. I'd rather get this merged faster than try to fine tune stuff like slips. The most obvious gameplay effect this pr has will be crawling, and I believe I made tiny tweaks but I can't find it Anything I missed or weird behavior should be reported.
cl Whoneedspacee
balance: ash drake fire does less damage now
balance: ash drake takes longer to swoop down now
balance: tiles take longer to fully convert into lava now, slowing down the arena attack as well
balance: fire breath now moves slower
balance: triple fire breath for the lava swoop only happens below half health now
fix: #40621 (comment)
/cl
[why]: Complaints of ash drake being too strong in the lag have certainly not gone unheard, as well as the insults. The mech bug has been fixed from #40621 (comment) as well as making ash drake a lot slower and less punishing.
Attempt 2 at fixing the remaining bugs with orbits
Incorpmove had to be converted to forceMove() to make orbits able to tell when they move. They used loc setting before. This likely breaks some things but I couldn't find any particular issues. We should be overriding forceMove anyway for things that need to handle loc changes like that differently.
fixes#40544fixes#40522
cl XDTM
tweak: Holding an ID in your hands uses it instead of your worn ID for authentication purposes.
tweak: If you don't have an ID in your id slot, the belt slot will be checked as well.
/cl
Fixes#40437
Makes sense if you want to use a specific access card without playing pocket tetris. The get_idcard has an argument for prioritizing worn id over held id, for stuff like identification.
