## About The Pull Request
I've stumbled across this enough to finally go through the entire
codebase and fix it. I left out changelogs simply because rewriting
history logs is bad.
## Why It's Good For The Game
I find it pretty annoying because I stumble across words that are
misspelled for a few seconds, and I'm likely not the only one who feels
like this. Less spelling mistakes in code are better.
## Changelog
🆑
spellcheck: Occurrences of "recieve" has been changed to "receive".
/🆑
## About The Pull Request
Combines
```
soundadd: added a new sound thingy
sounddel: removed an old sound thingy
```
into "sound," and
```
imageadd: added some icons and images
imagedel: deleted some icons and images
```
into "image" in the changelog.
I don't think we need to have both; `sound` and `image` can represent
any kind of change to their respective medium.
---------
Co-authored-by: tattle <article.disaster@gmail.com>
## About The Pull Request
Really minor change that should make the April fools PR experience
better for PR creators/maints. Not sure if this has any notable
performance implications with the git bot going over its normal stuff,
if it does close this since this is pretty minor.
## Why It's Good For The Game
Its not, anything that encourages april fools PRs makes the game so much
worse.
## About The Pull Request
Github hook to add the Logging tag to PRs with "log/logs/logging" in the
title.
## Why It's Good For The Game
Computers doing my dirty work for me
## Changelog
No player-facing changes
Co-authored-by: tattle <article.disaster@gmail.com>
I wanted to move auto labeling into its own workflow, but realized that it and changelog generation were coupled. So I'm detaching that first, and then will work on auto labeling later. Includes general code for a changelog parser so that I can reuse it by that point.
GitHub actions are great for downstreams, as setting up a PHP server for the webhook is not trivial, compared to Existing and getting it for free. They are also much more straightforward to test and update than the webhook. I was able to verify this was working trivially with an empty repository.
Tested and working: Mothblocks/ss13-workflow-testing@0a2de4d
About The Pull Request
Limits the game announcers only to arrays in a fixed whitelist.
Discord announcements, as they're more for those interested in the technical side, are on a blacklist of patterns. This is set to blacklist anything starting with event-*.
This stops a lot of internal repos from clogging chat, but more importantly is going to be used as events will now be hosted on the tgstation organization, and we want to limit spoilers/confusion on that for people who don't go looking for it.
This pull request converts the changelog to TGUI.
Note: Old unused changelog files will be automatically removed on the next changelog run
Why It's Good For The Game
More consistent UI, ability to view all historic logs.
Changelog
cl Celotajs
refactor: Converted the changelog popup to TGUI
/cl
The action has been working fine, and every bug its had has been solved not with disabling it, but with me resolving it. There's no reason to keep around the old system anymore. Viva la actions.
Line 17 of the Run Linters job of the CI Suite workflow:
> PHP Fatal error: Array and string offset access syntax with curly braces is
> no longer supported in ./tools/WebhookProcessor/github_webhook_processor.php
> on line 972
Something, something the PHP version updated to 7.x and dropped curly brackets support.
Some rescaling since the stakes are 10x higher now:
Fix: +3
Tweak: -2
Performance: +12
Priority: High: +15
Priority: Critical: +20
Feedback: +2
Code Improvement: +2
The intention with the formula tweak is for the highest absolute value of the label set (favoring the negative) to be applied.
* Adds discord webhook support to the github webhook processor.
* Fix odd bug
* Add discordwebhook config to secrets with example urls
* Forgot a semicolon
* Remove debug lines
* Hide html comments inside pr bodies.
* Add a bunch of configs to announcement endpoints
include_repos
exclude_repos
exclude_events
announce_secret
announce_unvalidated
embed
no_text
* Add support for those configs.
* Fix minor bug
* Fix no embed messages not working
* Adds spoiler support to discord_sanitize
By disabling multiline mode, $ becomes the end of the string, so we can match either \Rdiff or $, so that the lazy modifier must match the rest of the string if it can't find \Rdiff
It's not that different from other subsystems to justify the huge extra point cost, and the people who make atmos related changes have attained a great number of points.
Tweak is for small things that shouldn't affect the point balance either way
* Webhook now comments its diff instead of its dump
* Fixes variable access in webhook
* Fixes webhook regex flaw
* Missing semicolon in webhook
well... I don't have much to say to you
this is... i mean... 😀😀😁😁😁😁😂😂😂😂😂😂😂😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭
* Fixes anoher webhook regex issue
* Re-adds content to webhook update
* Encapsulates webhook diff in <details>
