Commit Graph

228 Commits

Author SHA1 Message Date
SkyratBot
99cdbe4ce2 [MIRROR] Reworks pAIs [MDB IGNORE] (#15162) 2022-07-27 19:10:14 -04:00
SkyratBot
758914d69a [MIRROR] Fix: #41250 You can't use a tablet while inside a locker [MDB IGNORE] (#15177)
* Fix: #41250 You can't use a tablet while inside a locker (#68171)

* Fix: #41250 You can't use a tablet while inside a locker

Co-authored-by: Matt <gavxn@zanidrak.com>
2022-07-25 11:49:11 +01:00
SkyratBot
2059781c34 [MIRROR] PDAs open their messenger when replying to messages through chat [MDB IGNORE] (#15022)
* PDAs open their messenger when replying to messages through chat

* Update code/modules/modular_computers/hardware/hard_drive.dm

* Actually fixes the merge conflict and the compile errors

Co-authored-by: distributivgesetz <distributivgesetz93@gmail.com>
Co-authored-by: Tom <8881105+tf-4@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
2022-07-19 02:14:05 +01:00
SkyratBot
c68fea7cba [MIRROR] Completely removes proc_holders from existence. Refactors all wizard, xeno, spider, and genetics powers to be actions. Also refactors and sorts ton of accompanying code. [MDB IGNORE] (#14666)
* Completely removes `proc_holders` from existence. Refactors all wizard, xeno, spider, and genetics powers to be actions. Also refactors and sorts ton of accompanying code.

* our changes

* yes

* 0

* Update blackmesa.dmm

Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
2022-07-01 20:33:30 +01:00
GoldenAlpharex
d4b0974aaf [MIRROR] CARGONIA THE FREE: The Quartermaster is now a head of staff. (#67518) [MDB IGNORE] (#14186)
* CARGONIA THE FREE: The Quartermaster is now a head of staff. (#67518)

* The Quartermaster is officially a head of staff, with new accesses, a silver ID, ect ect.
* The HoP lost their cargo-related equipment and access, including the Vault monitor, and frequency.

* wew

Co-authored-by: Iamgoofball <iamgoofball@gmail.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
2022-06-08 15:28:51 +01:00
SkyratBot
85147efc66 [MIRROR] Head of Personnel Resprite & New HoP Coat [MDB IGNORE] (#13974)
* Head of Personnel Resprite & New HoP Coat (#67286)

add: Brand new HoP coat!
imageadd: New sprites for HoP's uniform, skirt, cap, and the ID Painter.

* Head of Personnel Resprite & New HoP Coat

Co-authored-by: axietheaxolotl <86872535+axietheaxolotl@users.noreply.github.com>
2022-05-28 13:17:09 +01:00
SkyratBot
85a634949d [MIRROR] Fixes tablet lights [MDB IGNORE] (#13946)
* Fixes tablet lights (#67315)

* Fixes tablet lights

Makes tablet lights properly be directional lights like PDAs were.
I also replaced some single-letter vars for no particular reason.

* re-adds action button updating

* Fixes tablet lights

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
2022-05-27 15:27:57 +01:00
SkyratBot
eab84b1475 [MIRROR] Removes power monitor from tablets [MDB IGNORE] (#13901)
* Removes power monitor from tablets (#67245)

* Removes power monitor from tablets

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
2022-05-26 08:13:35 -04:00
SkyratBot
eb96261bf7 [MIRROR] New illiterate quirk [MDB IGNORE] (#13846)
* New illiterate quirk

* Update health_analyzer.dm

* Update health_analyzer.dm

Co-authored-by: Tim <timothymtorres@gmail.com>
Co-authored-by: Zonespace <41448081+Zonespace27@users.noreply.github.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
2022-05-24 16:33:47 +01:00
SkyratBot
6705906507 [MIRROR] Readds Captains fountain pen [MDB IGNORE] (#13781)
* Readds Captains fountain pen (#67164)

bout The Pull Request

Was working on a different fix and noticed the Captains Fountain pen was missing so i went through some other jobs on a pre modular PDA build and found that QMs survial pen was also missing. Ignored the fountain pens for all Heads of Staff i presume that was intentional.
Why It's Good For The Game

Minor Fix, gives the Captain back back his Unique Pen and dignity
QM gets their survial pen back as well.
Changelog

Captains and Quartermasters now receive their unique pens in their PDAS again.

cl
fix: Restores Captains pen and QM survial pen in respective Pdas

/cl

* Readds Captains fountain pen

Co-authored-by: Dmeto <75919495+Dmeto@users.noreply.github.com>
2022-05-21 14:13:30 +01:00
SkyratBot
8765c990c2 [MIRROR] Fixes spray cans and pipes fitting inside of tablets. [MDB IGNORE] (#13701)
* Fixes spray cans and pipes fitting inside of tablets. (#67057)

They were subtypes of crayons and cigarettes which allowed them to be fit inside. To fix this, the tablet can only hold tiny items and spray cans and pipes have been changed from tiny items to small.

* Fixes spray cans and pipes fitting inside of tablets.

Co-authored-by: ReinaCoder <83892995+ReinaCoder@users.noreply.github.com>
2022-05-18 20:03:19 +01:00
SkyratBot
a11d253cf5 [MIRROR] Mass-PDA perms is configured on Wirecarp [MDB IGNORE] (#13663)
* Mass-PDA perms is configured on Wirecarp (#66889)

Lawyers and Captains spawn by-default with the ability to send mass PDA messages, but the Wirecarp app (so Research Director and Captain) can grant/revoke permission to send PDAs to everyone

* Mass-PDA perms is configured on Wirecarp

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
2022-05-17 00:12:12 -07:00
SkyratBot
9e9b8584d6 [MIRROR] Removes CPU, Sensors and Identify ModPC parts. [MDB IGNORE] (#13594)
* Removes CPU, Sensors and Identify ModPC parts.

* Update computer_part_designs.dm

* Update tablet.dm

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: Zonespace <41448081+Zonespace27@users.noreply.github.com>
2022-05-15 19:43:02 -07:00
SkyratBot
8be8604d46 [MIRROR] Fixes the captain's PDA [MDB IGNORE] (#13586)
* Fixes the captain's PDA (#66908)

I screwed it up and didn't make the Captain's PDA a subtype of heads, so captain was spawning with the wrong PDA.

* Fixes the captain's PDA

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
2022-05-13 16:06:52 -07:00
SkyratBot
81db26ba94 [MIRROR] [MDB IGNORE] Removes tablet cartridges + reworks a ton more [MDB IGNORE] (#13539)
* [MDB IGNORE] Removes tablet cartridges + reworks a ton more (#66505)

- All tablets who previously had apps in a cartridge now has them built-into their tablet instead. This means it costs space for it.
- Rebalances the sizes of several apps to help them fit on Command tablets (Cargo ordering costed 20!!)
- Removes tablet cartridges, they've been reworked into a regular old portable disk (the same you use for toxins/borgs)
- Removes Signaller (the module required to run the signaller app) from tablets (likely will remove more in the future)
- Refactors the health/chem scanning app to not be as bad
- Dehardcodes detomatix resistance
- Ability to send PDA's to all is now tied to your access rather than a cartridge
- Moves 'eject disk' button to the very top of the UI

* [MDB IGNORE] Removes tablet cartridges + reworks a ton more

* wew

* wew

* ok

* Update nanotrasen_consultant.dm

* Update nanotrasen_consultant.dm

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
2022-05-11 22:40:06 +01:00
SkyratBot
c1a1683db6 [MIRROR] removes permeability, rolling it into bio armor [MDB IGNORE] (#13435)
* removes permeability, rolling it into bio armor

* e

Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
2022-05-09 01:16:27 +01:00
SkyratBot
c70b428704 [MIRROR] Set steel_sheet_cost for tablets (PDAs) to 2 [MDB IGNORE] (#13449)
* Set steel_sheet_cost for tablets (PDAs) to 2 (#66773)

Destroyed player PDA / tablet drops half of the steel_sheet_cost as a stack on destruction. Having this set to 1 creates zero sized stacks of iron. Rather than fix the code that drops, I just upped this to make it drop 1 sheet on destruction, which is probably the intended effect.

* Set steel_sheet_cost for tablets (PDAs) to 2

Co-authored-by: Iain Price <github@predestined.net>
2022-05-08 12:19:26 -07:00
SkyratBot
66a716aea6 [MIRROR] Fixes computers being unusable and runtiming to hell [MDB IGNORE] (#13412)
* Fixes computers being unusable and runtiming to hell (#66737)

* Fixes computers being unusable and runtiming to hell

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
2022-05-07 22:07:12 +01:00
SkyratBot
9e1b277ef1 This just like george orwell's book uh... 1984 (#66502) (#13289)
Materials got removed from the PDA that all crew members spawned with when we switched over to tablets.
This readds that as that was originally done in #57923 (2e309d4ead)

Allowing players to interact through obscure mechanics to bait each other to blow up a microwave in an attempt to charge their tablet is fucking hilarious.

Co-authored-by: ArcaneDefence <51932756+ArcaneDefence@users.noreply.github.com>
2022-05-03 16:05:56 +01:00
SkyratBot
360242ee83 [MIRROR] adds pda paper scanning, and gives head job disks the tech web [MDB IGNORE] (#13133)
* adds pda paper scanning, and gives head job disks the tech web (#66470)

lets you uhhh scan papers i nto your notes app and also uhhh gives all heads the techweb app and also uhhh removes some role tablets because they dont really like need them anymore yeah cool awesome

coming one step closer to orange's vision of having techweb be heads only

* adds pda paper scanning, and gives head job disks the tech web

Co-authored-by: magatsuchi <88991542+magatsuchi@users.noreply.github.com>
2022-04-26 15:50:31 +01:00
SkyratBot
e50bf125f9 [MIRROR] Makes PDA flashlight action button update when its flashlight toggles [MDB IGNORE] (#13067)
* Makes flashlight action button update when flashlight toggles (#66434)

* Makes PDA flashlight action button update when its flashlight toggles

Co-authored-by: Tastyfish <crazychris32@gmail.com>
2022-04-24 19:38:47 +01:00
SkyratBot
a72972dd64 [MIRROR] fixes curator PDA overlays not showing up [MDB IGNORE] (#13063)
* ae (#66412)

* fixes curator PDA overlays not showing up

Co-authored-by: capsaicin <84609863+capsaicinz@users.noreply.github.com>
2022-04-24 19:38:05 +01:00
SkyratBot
43c3921170 [MIRROR] new pda sprites! [MDB IGNORE] (#12996)
* new pda sprites! (#66369)

Replaced new PDA sprites with even newer ones!

* new pda sprites!

Co-authored-by: capsaicin <84609863+capsaicinz@users.noreply.github.com>
2022-04-22 15:03:41 +01:00
SkyratBot
cb2e261ebb [MIRROR] Installs Syndix on the military tablet PDA [MDB IGNORE] (#12992)
* Properly adds the syndicate PDA theme (#66376)

Please read and accept our Terms of Use and Privacy Policy before proceeding.

* Installs Syndix on the military tablet PDA

Co-authored-by: Vladin Heir <44104681+VladinXXV@users.noreply.github.com>
2022-04-22 15:01:34 +01:00
SkyratBot
94700280ab [MIRROR] adds pen in tablet flavor text + ctrl click [MDB IGNORE] (#12988)
* adds pen in tablet flavor text + ctrl click (#66367)

Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>

* adds pen in tablet flavor text + ctrl click

Co-authored-by: magatsuchi <88991542+magatsuchi@users.noreply.github.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
2022-04-22 14:59:26 +01:00
SkyratBot
d28de54ed9 [MIRROR] [NO GBP] more tablet additions [MDB IGNORE] (#12944)
* [NO GBP] more tablet additions (#66358)

About The Pull Request

actually makes the damn action button for the flashlight on your device work, as well as fixing clown/silicon/mime names properly showing up

    fixes not chunky finger people not being able to use pdas

Why It's Good For The Game

tweaks to make the tablet more user friendly
Changelog

cl
fix: actually makes the flashlight action button work, and fixes silicon/clown/mime names showing up properly on tablets/messenger
/cl

* [NO GBP] more tablet additions

Co-authored-by: magatsuchi <88991542+magatsuchi@users.noreply.github.com>
2022-04-21 00:16:09 +01:00
SkyratBot
729132a4e0 [MIRROR] Rebalanced Power consumption, increase for machines [MDB IGNORE] (#12930)
* Rebalanced Power consumption, increase for machines

* wew

Co-authored-by: Ghilker <42839747+Ghilker@users.noreply.github.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
2022-04-20 17:07:14 +01:00
magatsuchi
dc8adc2924 Modular Tablets: Converting PDAs to the NtOS System (SKYRAT VERSION) (#12920)
* hot-patch 1

* hot patch 2

* hot patch 3

* slight issue
2022-04-20 16:55:49 +01:00
SkyratBot
c99897ca9c [MIRROR] Refactors Newscaster cartridge to tablet app [MDB IGNORE] (#12652)
* Refactors Newscaster cartridge to tablet app (#66035)

* Refactors Newscaster cartridge to tablet app

* Update maint_loot_uncommon.dm

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
2022-04-11 00:57:41 +01:00
SkyratBot
25178c9747 [MIRROR] Refactors janitor cartridge to a tablet app [MDB IGNORE] (#12563)
* Refactors janitor cartridge to a tablet app

* e

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
2022-04-07 15:57:08 +01:00
SkyratBot
3cbab2718e [MIRROR] Fixes tablet not updating appearance after it is repaired [MDB IGNORE] (#12015)
* Tablet update icon fix (#65298)

* Fixes tablet not updating appearance after it is repaired

Co-authored-by: Tortoise <64306407+OneAsianTortoise@users.noreply.github.com>
2022-03-11 16:43:10 -07:00
SkyratBot
6f1ab2f231 [MIRROR] Ordnance Content Update: Scientific Papers [MDB IGNORE] (#11862)
* Ordnance Content Update: Scientific Papers

* Feex

* Updated our modular maps to not be missing equipment

* I also forgot to fix that in another PR, I'm too lazy to open a new one to fix it

* Yikes

* I forgot Journey

Co-authored-by: vincentiusvin <54709710+vincentiusvin@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
2022-03-07 17:59:39 -05:00
SkyratBot
7437f1a0eb [MIRROR] fix modular printer paper level display [MDB IGNORE] (#10926)
* fix modular printer paper level display (#64289)

* fix modular printer paper level display

Co-authored-by: Coldud <coldud13@users.noreply.github.com>
2022-01-23 05:32:44 -05:00
SkyratBot
65b8082678 [MIRROR] Harddel Fix Pack #42 + Better Live Reftracking Support [MDB IGNORE] (#10639)
* Harddel Fix Pack #42 + Better Live Reftracking Support

* awooga

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
2022-01-12 21:57:49 +00:00
SkyratBot
c33061765b [MIRROR] [MDB IGNORE] BIDDLE TRAITORS - Adds progression traitors. Refactors uplink code in its entirety [MDB IGNORE] (#10620)
* [MDB IGNORE] BIDDLE TRAITORS - Adds progression traitors. Refactors uplink code in its entirety

* updates and fixes

* ffff

Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
2022-01-12 03:25:38 +00:00
SkyratBot
f9c68f99a0 [MIRROR] Modular Devices Deconstruction QOL [MDB IGNORE] (#10605)
* Modular Devices now have auditory feedback for disassembly. (#63986)

* Modular Console Bubble Message + Sounds

* Screwdriver Sounds

* Balloon Text Changes

* capitalization begone

* Tiny Edit

* Requested Changes

* Modular Devices Deconstruction QOL

Co-authored-by: Cheshify <73589390+Cheshify@users.noreply.github.com>
2022-01-12 02:22:59 +00:00
SkyratBot
092e534e75 [MIRROR] TGUI list conversions + bug fixes [MDB IGNORE] (#10355)
* TGUI list conversions + bug fixes

* Fixing conflicts

* Maintaining a few modular files while we're at it...

Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
2022-01-03 22:53:58 +00:00
SkyratBot
a0c805ff4c [MIRROR] Fix skin tone sorting and refactor color procs [MDB IGNORE] (#10210)
* Fix skin tone sorting and refactor color procs (#63554)

* Remove superfluous hash from hex2rgb call
Add stack_trace to hex2rgb to catch future nonsense

* Fix skin tone sorting and refactor color procs

Co-authored-by: AndrewL97 <andrewjlove97@gmail.com>
2021-12-23 16:46:08 +00:00
SkyratBot
959f66bf47 [MIRROR] Fixed spelling of possession, Separate, and Cemetery [MDB IGNORE] (#9862)
* Fixed spelling of possession, separate, and cemetery (#63203)

Just fixes some spelling for gangs. I also fixed misspellings for "posession" to "possession". Fixed "seperate " to "Separate" Fixed "Cemetary" to "Cemetery"

* Fixed spelling of possession, Separate, and Cemetery

Co-authored-by: Doctor Pope <84367152+Dr-Pope@users.noreply.github.com>
2021-12-03 16:58:40 -05:00
SkyratBot
528a41e38b [MIRROR] Security Officer, Detective and Warden spawn with tablets. [MDB IGNORE] (#9251)
* Security starts with tablets. (#62537)

* Security Officer, Detective and Warden spawn with tablets.

Co-authored-by: GuillaumePrata <55374212+GuillaumePrata@users.noreply.github.com>
2021-11-05 17:15:47 -04:00
SkyratBot
e90627be0e [MIRROR] Modernizing Radiation -- TL;DR: Radiation is now a status effect healed by tox healing, and contamination is removed [MDB IGNORE] (#9176)
* Modernizing Radiation -- TL;DR: Radiation is now a status effect healed by tox healing, and contamination is removed

* Fixing conflicts

* Makes it compile, yeet all the RAD armor from everywhere (thanks RegEx!)

* Removing more lingering rad armor (woo)

* Damnit powerarmors

* Bye bye rad collectors!

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
2021-11-02 10:36:46 -04:00
SkyratBot
fa519bdde3 [MIRROR] cleanup _HELPERS/_lists.dm and all the necessary files [MDB IGNORE] (#8783)
* cleanup _HELPERS/_lists.dm and all the necessary files

* Epbic

Co-authored-by: Ghilker <42839747+Ghilker@users.noreply.github.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2021-10-13 21:07:35 +01:00
SkyratBot
95ab2d2efb [MIRROR] Adds SHOULD_NOT_SLEEP to Destroy. Why didn't we do this before. [MDB IGNORE] (#8714)
* Adds SHOULD_NOT_SLEEP to Destroy. Why didn't we do this before. (#61943)

* Adds SHOULD_NOT_SLEEP to Destroy. Why didn't we do this before.

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
2021-10-09 09:11:52 -04:00
SkyratBot
c23bd1cb8c [MIRROR] every case of initialize that should have mapload, does (#8374)
* every case of initialize that should have mapload, does

* E

Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2021-09-24 23:07:53 +01:00
SkyratBot
af6de0b4d4 [MIRROR] Eng/Atmos/CE tablet come with Canary (Alarm monitor) preinstalled (#8233)
* Eng/Atmos/CE tablet come with Canary (Alarm monitor) preinstalled (#61322)

Tablets are often found thrown around a corner of the foyer, and I'm tired of bullying people to use it at this point. It's IMO the most powerful tool engineering has to keep the station in good condition but only a few players ever download anything in a round.

So let's make their lives easier, engineering tablets come preinstalled with Canary and the Atmos with the Gas Scanner too. (Even if I never saw anyone use that, just because the tablet comes preinstalled with the sensor that enables it.)

Canary is a powerful tool to assist on station maintenance that is not well known to the player, maybe this will get people curious enough to open it and start to enjoy having all alarms green as much as I do.

Nothing hurts more than a small breach at science that goes unfixed for half an hour and slowly creep in turning the station into Firelock hell... and nothing is funnier than screaming "Atmos alarm at the HoS Office!" the second it pops up only for the AI to lock the shutters down and tell sec that a random lizard broke the window and is trying to Esword the HoS locker.

* Eng/Atmos/CE tablet come with Canary (Alarm monitor) preinstalled

Co-authored-by: GuillaumePrata <55374212+GuillaumePrata@users.noreply.github.com>
2021-09-17 21:22:33 +01:00
SkyratBot
bf1914c794 [MIRROR] Fixes some stupid behavior in computer hardware code. (#8145)
* Fixes some stupid behavior in computer hardware code.  (#61350)

* Fixes some stupid behavior in computer hardware code.

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
2021-09-14 03:16:00 +01:00
SkyratBot
04302a770a [MIRROR] moves obj_integrity and associated procs to the atom level (#8016)
* moves obj_integrity and associated procs to the atom level

* Feex good

* Whoops forgot the maps

Co-authored-by: Kylerace <kylerlumpkin1@gmail.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2021-09-10 16:47:01 +01:00
SkyratBot
eae7233c5b [MIRROR] small refactor to can_interact() so that borg range is fully respected (#7891)
* small refactor to can_interact() so that borg range is fully respected (#60693)

Its a relatively small refactor that changes the previous machinery "can_interact()" proc that literally did a full override despite half of their checks already existing in not one, but TWO parent procs, so i removed the redundant checks, added callbacks to its parents and then added the cyborg range check on the can_interact_with() itself. in doing so i also moved the interaction range var from silicons only, to mobs as a whole and defaulted it to a single tile, silicons override it to 7 (so pAIs and borgs like before) but then set AI and AI.eye to "null", because i have a check in can_interact that if there is no range set, then the range is effectively unlimited. and i even added code for when AI is carded and their wireless transmission is disabled it sets their range to "0" aka, it has no range to do anything even if it could

this was really complicated for me so despite my extensive testing it probably would be a bad thing if any of you want to test my code yourself to ensure there isnt a bug with this (theres no runtimes ive come across)

note: i did a lot of searching and going through machinery to ensure i caught all the little snowflake overrides and added can_interact() checks to them, but i may have missed one or two things, especially maybe a altclick or ctrlclick somewhere, however i believe i caught most of them

one nice side effect of this refactor is that you can actually set another mobs range to something other than 1 tile and they can interact at range, rather than only silicons getting this ability, an admin could VV a human to have a 3 tile arm reach as a meme if they want

* small refactor to can_interact() so that borg range is fully respected

Co-authored-by: 小月猫 <alina.r.starkova@gmail.com>
2021-08-31 20:26:36 +01:00
SkyratBot
b0c01e40af [MIRROR] Del The World: Unit testing for hard deletes (#7589)
* Del The World: Unit testing for hard deletes (#59612)

Co-authored-by: SteelSlayer <42044220+SteelSlayer@ users.noreply.github.com>

* Del The World: Unit testing for hard deletes

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Co-authored-by: SteelSlayer <42044220+SteelSlayer@ users.noreply.github.com>
2021-08-17 18:58:57 +01:00
twilightwanderer
356a8bbe67 Fix the program at the cyborg tablet (#7433) 2021-08-06 14:06:25 +01:00