* Makes changelog compile only fire if CHANGELOG_ENABLER secret is present (#53845)
Not tested yet, so please speak up if you notice anything off.
For any interested downstream/fork maintainers reading this:
You need to add CHANGELOG_ENABLER secret with some nonempty value to your repository if you want this action to continue to work as before.
* Makes changelog compile only fire if CHANGELOG_ENABLER secret is present
Co-authored-by: AnturK <AnturK@users.noreply.github.com>
* JATUM (#53831)
Adds the JATUM serialization system. Inspired by @ RemieRichards. Allows for easy serialization and deserialization of trivial datums.
Also adds a missing html_encode.
* JATUM
Co-authored-by: Jordan Brown <Cyberboss@users.noreply.github.com>
* Updates the tgs-dmapi-updater action reference (#53777)
* Updates the tgs-dmapi-updater action reference
Co-authored-by: Jordan Brown <Cyberboss@users.noreply.github.com>
* Add workflow_dispatch to TGS DMAPI update action for testing (#53775)
* Add workflow_dispatch to TGS DMAPI update action for testing
Co-authored-by: Jordan Brown <Cyberboss@users.noreply.github.com>
* Merge pull request #53674 from tgstation/Cyberboss-patch-2
Adds a GitHub action to automatically update the DMAPI
* Adds a GitHub action to automatically update the DMAPI
Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com>
* Create MAINTAINER_GUIDELINES.md (#53665)
* Create MAINTIAINER_GUIDELINES.md
This is echoing a post I made on the maintainer team page.
* Fix typo in file name
* Create MAINTAINER_GUIDELINES.md
Co-authored-by: Jordan Brown <Cyberboss@users.noreply.github.com>
* Adds a requirement to profile optimizations to contributing.md (#53235)
Co-authored-by: TiviPlus <TiviPlus>
* Adds a requirement to profile optimizations to contributing.md
Co-authored-by: TiviPlus <57223640+TiviPlus@users.noreply.github.com>
* tgchat: Hotfixes, Message Annotations (#52947)
This PR changes the message pipeline a little bit to support list-based messages, which can be annotated with custom data. Function signature of to_chat was slightly changed as well:
// Plain text message
to_chat(client,
type = MESSAGE_TYPE_INFO,
text = "foo")
// HTML message
to_chat(client,
type = MESSAGE_TYPE_INFO,
html = "<span class='notice'>foo</span>")
Old to_chat format is still supported, but handle_whitespace, trailing_newline and confidential flags have no effect. confidential flag could still be revived though, if there is enough merit in it, for example to filter out confidential messages when saving a chat log.
The reason for using /list and not /datum, is because lists are plain faster, and there are minimal data transformations - these lists are fed directly to json_encode and sent to tgchat.
Plain text messages do not need to be HTML-escaped, which makes them safer and more performant than HTML messages. Plain text messages can be made interactive (or formatted with CSS) by custom-handling them in javscript based on message type and annotations.
It would be impossible to annotate every single message in the game (at the moment of writing, there are 9447 to_chat calls in the code), but it could be done selectively, for only those messages that are hard to classify by span classes (and there are still A LOT of them).
Please annotate more messages. Thank you.
Fixes#52943Fixes#52908Fixes#52816
Changelog
cl
add: tgchat: Unread message count is now smarter and won't increase on other tabs if you have already read the same message in the active tab.
add: tgchat: Admin PMs are now properly annotated and can be filtered into separate tabs.
fix: tgchat: Fix: Highlighted message overlay no longer blocks clicks. Clicking a highlighted (F) link should work as it should.
fix: tgui: Fixed NTOS bluescreen due to calling .includes() on a stylesheet href which could be null on certain browsers.
code: tgchat: Chat schema bumped to version 5. All chat-related settings were reset to avoid breakage.
/cl
* tgchat: Hotfixes, Message Annotations
Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>
* Change BYOND version to 513.1526
* Remove BSQL from docker image
* Add a docker publish action
* Add a docker test action
* Cleanup runtime icons
* Cleanup runtime sounds
* Correct docker workflow names
* Add Dockerfile as an appveyor cache dependency
* Fix build issues
* Copy all dlls
* No need for .dlls in docker
* Minor cleanups
* Case of lower
* More changes
* Ruins the nice 420 diff, brainfart when doing the second batch of conversions
* More changes
* Next batch. I think
* Converts even more paths
* Restarts bots
* Capital Free Zone
* Come on travis, do something
* Renames areas
* Bots, please stop dying
* Updates CONTRIBUTING.md and updates a few paths I missed.
* APC recgarftzfvas
/obj/item/computer_hardware/recharger/apc to /obj/item/computer_hardware/recharger/apc_recharger
* first-version
* let's do those recommendations first
* color moment
* reorganization, prefs
* certified layer moment
* virtual speakers BEGONNE
* remove naughty bits, better sizing
* gimme the message mode
* rename that pesky pref and hide chat bubbles
* exponential decay moment
* async moment
* fixes
* fixes
* the players have decided they don't want to hear themselves on radio
* Fix bug with holograms incorrectly rendering messages
* rohesie's suggestion
* Color tweaks
* hallucinating now shows message properly
* pref moment
* updates
* rohesie's suggestions
* fix moment number 5
* less smelly more epic
* unfix the fixes and refix them
* a conscious change
* return of the prefs
Improves the description of the stale auto issue comment.
About The Pull Request
It is not clear to people how the auto stale process works, and they are having their PR shut because of it.
Some things to note if your PR is autoclosed
A)Preferably, ask a maintainer to reopen the PR, at that point they will decide if your PR was going to be merged and choose to reopen your PR and remove the stale label.
B)Open a new PR with the same branch (less preferred, but fine if you can't get any maintainers attention)
If your PR is marked stale but you have no compile issues or outstanding review, you need to make sure you follow up with maintainers in discord, as it's likely there are outstanding design issues preventing your PR being merged, or no appetite to include the change.
* Propose requiring use of the policy config system for some features
This commit proposes adding the requirement that a developer working on
a ghost role, antag, minor antag or event mob role of any kind must
support the policy configuration system. It also lays out a simple guide
to that system, as well as expectations.
The requirement will go into affect upon merge, any non merged PR at
that time will be required to implement the guidelines
* Update .github/POLICYCONFIG.md
Co-Authored-By: Rohesie <rohesie@gmail.com>
* Update .github/POLICYCONFIG.md
Co-Authored-By: moo <11748095+ExcessiveUseOfCobblestone@users.noreply.github.com>
Co-authored-by: Rohesie <rohesie@gmail.com>
Co-authored-by: moo <11748095+ExcessiveUseOfCobblestone@users.noreply.github.com>
About The Pull Request
Goes through the readme and moves a lot of stuff into situation documents, reducing scroll of death and helping people get to what they want faster.
Adds coderbus discord, and labels irc as dead
* Proposal to require DMDOC documentation on PR's
Includes a guide to how to do it on /tg/ as well as information about
the data.
* Further tweaks
* A few more tweaks
* Fix up links
* Fix Yet another link
* Change dmdoc link to actual dmdoc src and readme
* Clearer single line explanation
AddComponent/AddElement now support named arguments. This requires passing around an argument list instead of using actual proc args which a bit gross but we can blame byond for forcing this.
InheritComponent uses mirrored init arguments instead of an argument list which means no more accessing it via index to get to the same arguments as in init.
As a small bonus I restructured dcs defines to be a bit more manageable. Mainly just splits them into separate files and gives them their own folder.
