mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-08-26 06:29:23 +01:00
3c5749f862
## About The Pull Request The overall behaviour of everything should stay the same but the memory & speed of these components has been slightly improved and when you scale that across large plumbing factories you get a substantial improvement. Here's a list of the most noticeable changes along with many others that aren't worth mentioning - Removed vars `use_overlays`, `turn_connects`, `recipient_reagents_holder` - `active` var is now replaced with a proc which simply returns is the machine wrenched or not - `turn_connects` has been removed because all machines have their pipes rotate when the machine is rotated. This also removed all the static icon states ending with `-s` from the `dmi` file thus reducing that file size as well - `extend_pipe_to_edge` var is directly integrated into `cut_overlays()` because it's use cases were limited such for showers & sinks - Simplified `Initialize()` a lot. Removed params `start`, `turn_connects`, `custom_receiver`, `extend_pipe_to_edge`. We now only pass `bolt_layer` making that proc faster & less convoluted - Replaced `set_recipient_reagents_holder()` proc with `recipient_reagents_holder()` which returns the reagent holder for holding reagents instead of storing it in the component. This removes the need to hook a qdel signal on the holder & we don't need to keep track of it - Merged a ton of procs to reduce overhead & reduce file size - Plumbing ducts creating the network at mapload is faster without using recursion and the timer subsystem - Deconstructing plumbing ducts is faster in reconstructing the network without using recursion and the timer subsystem This makes managing plumbing code less convoluted & overall better for the foreseeable future. See the lines of code removed vs added and still preserves behaviour ## Changelog 🆑 qol: added examines & screentips for ducts & stack of ducts qol: you can wrench a stack of ducts on the ground to create a pipe refactor: plumbing code has been improved overall. Report bugs on github sprite: removed unused static(does not rotate with machine) icon states for plumbing connections /🆑 --------- Co-authored-by: Time-Green <7501474+Time-Green@users.noreply.github.com>
49 lines
1.3 KiB
Plaintext
49 lines
1.3 KiB
Plaintext
/datum/component/plumbing/splitter
|
|
demand_connects = NORTH
|
|
supply_connects = SOUTH | EAST
|
|
|
|
/datum/component/plumbing/splitter/Initialize(ducting_layer)
|
|
if(!istype(parent, /obj/machinery/plumbing/splitter))
|
|
return COMPONENT_INCOMPATIBLE
|
|
return ..()
|
|
|
|
/datum/component/plumbing/splitter/can_give(amount, reagent, datum/ductnet/net)
|
|
. = ..()
|
|
if(!.)
|
|
return
|
|
var/direction
|
|
for(var/A in ducts)
|
|
if(ducts[A] == net)
|
|
direction = get_original_direction(text2num(A))
|
|
break
|
|
var/obj/machinery/plumbing/splitter/S = parent
|
|
switch(direction)
|
|
if(SOUTH)
|
|
if(S.turn_straight && S.transfer_straight <= amount)
|
|
S.turn_straight = FALSE
|
|
return TRUE
|
|
if(EAST)
|
|
if(!S.turn_straight && S.transfer_side <= amount)
|
|
S.turn_straight = TRUE
|
|
return TRUE
|
|
return FALSE
|
|
|
|
|
|
/datum/component/plumbing/splitter/transfer_to(datum/component/plumbing/target, amount, reagent, datum/ductnet/net, round_robin = TRUE)
|
|
var/direction
|
|
for(var/A in ducts)
|
|
if(ducts[A] == net)
|
|
direction = get_original_direction(text2num(A))
|
|
break
|
|
var/obj/machinery/plumbing/splitter/S = parent
|
|
switch(direction)
|
|
if(SOUTH)
|
|
if(amount >= S.transfer_straight)
|
|
amount = S.transfer_straight
|
|
if(EAST)
|
|
if(amount >= S.transfer_side)
|
|
amount = S.transfer_side
|
|
S.use_energy(S.active_power_usage)
|
|
return ..()
|
|
|