cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-20 03:30:01 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
docker-build
Bubberstation/code/game/objects/items/tanks/jetpack.dm
T
SmArtKarandRoxy 589cf0a904 Refactors how item actions are handled (#89654) 
## About The Pull Request

This PR tackles our piss-poor item action handling. Currently in order
to make an item only have actions when its equipped to a certain slot
you need to override a proc, which I've changed by introducing an
action_slots variable. I've also cleaned up a ton of action code, and
most importantly moved a lot of Trigger effects on items to do_effect,
which allows actions to not call ui_action_click or attack_self on an
item without bypassing IsAvailible and comsigs that parent Trigger has.
This resolves issues like jump boots being usable from your hands, HUDs
being toggleable out of your pockets, etc. Also moved a few actions from
relying on attack_self to individual handling on their side.

This also stops welding masks/hardhats from showing their action while
you hold them, this part of the change is just something I thought
didn't make much sense - you can use their action by using them in-hand,
and flickering on your action bar can be annoying when reshuffling your
backpack.

Closes #89653

## Why It's Good For The Game
Makes action handling significantly less ass, allows us to avoid code
like this
```js
/obj/item/clothing/mask/gas/sechailer/ui_action_click(mob/user, action)
	if(istype(action, /datum/action/item_action/halt))
		halt()
	else
		adjust_visor(user)
```
2025-03-12 16:53:44 -04:00

252 lines
7.8 KiB
Plaintext
Raw Permalink Blame History

/obj/item/tank/jetpack
name = "jetpack (empty)"
desc = "A tank of compressed gas for use as propulsion in zero-gravity areas. Use with caution."
icon_state = "jetpack"
inhand_icon_state = "jetpack"
lefthand_file = 'icons/mob/inhands/equipment/jetpacks_lefthand.dmi'
righthand_file = 'icons/mob/inhands/equipment/jetpacks_righthand.dmi'
w_class = WEIGHT_CLASS_BULKY
distribute_pressure = ONE_ATMOSPHERE * O2STANDARD
actions_types = list(/datum/action/item_action/set_internals, /datum/action/item_action/toggle_jetpack, /datum/action/item_action/jetpack_stabilization)
/// What gas our jetpack is filled with on initialize
var/gas_type = /datum/gas/oxygen
/// If the jetpack is currently active
var/on = FALSE
/// If the jetpack will stop when you stop moving
var/stabilize = FALSE
/// If the jetpack will have a speedboost in space/nograv or not
var/full_speed = TRUE
/// If our jetpack is disabled, from getting EMPd
var/disabled = FALSE
/// Callback for the jetpack component
var/thrust_callback
/// How much force out jetpack can output per tick
var/drift_force = 1.5 NEWTONS
/// How much force this jetpack can output per tick to stabilize the user
var/stabilizer_force = 1.2 NEWTONS
/obj/item/tank/jetpack/Initialize(mapload)
. = ..()
AddElement(/datum/element/update_icon_updates_onmob, ITEM_SLOT_SUITSTORE)
thrust_callback = CALLBACK(src, PROC_REF(allow_thrust), 0.01)
configure_jetpack(stabilize)
/obj/item/tank/jetpack/Destroy()
thrust_callback = null
return ..()
/**
* configures/re-configures the jetpack component
*
* Arguments
* stabilize - Should this jetpack be stabalized
*/
/obj/item/tank/jetpack/proc/configure_jetpack(stabilize, mob/user = null)
src.stabilize = stabilize
AddComponent( \
/datum/component/jetpack, \
src.stabilize, \
drift_force, \
stabilizer_force, \
COMSIG_JETPACK_ACTIVATED, \
COMSIG_JETPACK_DEACTIVATED, \
JETPACK_ACTIVATION_FAILED, \
thrust_callback, \
thrust_callback, \
/datum/effect_system/trail_follow/ion, \
)
if (!isnull(user) && user.get_item_by_slot(slot_flags) == src)
if (!stabilize)
ADD_TRAIT(user, TRAIT_NOGRAV_ALWAYS_DRIFT, JETPACK_TRAIT)
else
REMOVE_TRAIT(user, TRAIT_NOGRAV_ALWAYS_DRIFT, JETPACK_TRAIT)
/obj/item/tank/jetpack/equipped(mob/user, slot, initial)
. = ..()
if(on && !(slot & slot_flags))
turn_off(user)
/obj/item/tank/jetpack/dropped(mob/user, silent)
. = ..()
if(on)
turn_off(user)
/obj/item/tank/jetpack/populate_gas()
if(gas_type)
var/datum/gas_mixture/our_mix = return_air()
our_mix.assert_gas(gas_type)
our_mix.gases[gas_type][MOLES] = ((6 * ONE_ATMOSPHERE) * volume / (R_IDEAL_GAS_EQUATION * T20C))
/obj/item/tank/jetpack/ui_action_click(mob/user, action)
if(istype(action, /datum/action/item_action/toggle_jetpack))
cycle(user)
else if(istype(action, /datum/action/item_action/jetpack_stabilization))
if(on)
configure_jetpack(!stabilize, user)
to_chat(user, span_notice("You turn the jetpack stabilization [stabilize ? "on" : "off"]."))
else
toggle_internals(user)
/obj/item/tank/jetpack/proc/cycle(mob/user)
if(user.incapacitated)
return
if(!on)
if(turn_on(user))
to_chat(user, span_notice("You turn the jetpack on."))
else
to_chat(user, span_notice("You fail to turn the jetpack on."))
return
else
turn_off(user)
to_chat(user, span_notice("You turn the jetpack off."))
update_item_action_buttons()
/obj/item/tank/jetpack/update_icon_state()
. = ..()
icon_state = "[initial(icon_state)][on ? "-on" : ""]"
/obj/item/tank/jetpack/proc/turn_on(mob/user)
if(disabled)
return FALSE
if(SEND_SIGNAL(src, COMSIG_JETPACK_ACTIVATED, user) & JETPACK_ACTIVATION_FAILED)
return FALSE
on = TRUE
update_icon(UPDATE_ICON_STATE)
if(full_speed)
user.add_movespeed_modifier(/datum/movespeed_modifier/jetpack/full_speed)
if (!stabilize)
ADD_TRAIT(user, TRAIT_NOGRAV_ALWAYS_DRIFT, JETPACK_TRAIT)
return TRUE
/obj/item/tank/jetpack/proc/turn_off(mob/user)
SEND_SIGNAL(src, COMSIG_JETPACK_DEACTIVATED, user)
on = FALSE
update_icon(UPDATE_ICON_STATE)
if(user)
user.remove_movespeed_modifier(/datum/movespeed_modifier/jetpack/full_speed)
REMOVE_TRAIT(user, TRAIT_NOGRAV_ALWAYS_DRIFT, JETPACK_TRAIT)
/obj/item/tank/jetpack/proc/allow_thrust(num, use_fuel = TRUE)
if(!ismob(loc))
return FALSE
var/mob/user = loc
if((num < 0.005 || air_contents.total_moles() < num))
turn_off(user)
return FALSE
// We've got the gas, it's chill
if(!use_fuel)
return TRUE
var/datum/gas_mixture/removed = remove_air(num)
if(removed.total_moles() < 0.005)
turn_off(user)
return FALSE
var/turf/T = get_turf(src)
T.assume_air(removed)
return TRUE
/obj/item/tank/jetpack/suicide_act(mob/living/user)
if (!ishuman(user))
return
var/mob/living/carbon/human/suffocater = user
suffocater.say("WHAT THE FUCK IS CARBON DIOXIDE?")
suffocater.visible_message(span_suicide("[user] is suffocating [user.p_them()]self with [src]! It looks like [user.p_they()] didn't read what that jetpack says!"))
return OXYLOSS
/obj/item/tank/jetpack/emp_act(severity)
. = ..()
if(. & EMP_PROTECT_CONTENTS)
return
if(ismob(loc) && (item_flags & IN_INVENTORY))
var/mob/wearer = loc
turn_off(wearer)
else
turn_off()
update_item_action_buttons()
disabled = TRUE
addtimer(CALLBACK(src, PROC_REF(remove_emp)), 4 SECONDS)
///Removes the disabled flag after getting EMPd
/obj/item/tank/jetpack/proc/remove_emp()
disabled = FALSE
/obj/item/tank/jetpack/improvised
name = "improvised jetpack"
desc = "A jetpack made from two air tanks, a fire extinguisher and some atmospherics equipment. It doesn't look like it can hold much."
icon_state = "jetpack-improvised"
inhand_icon_state = "jetpack-improvised"
worn_icon = null
worn_icon_state = "jetpack-improvised"
volume = 20 //normal jetpacks have 70 volume
gas_type = null //it starts empty
full_speed = FALSE
drift_force = 1 NEWTONS
stabilizer_force = 0.5 NEWTONS
/obj/item/tank/jetpack/improvised/allow_thrust(num)
if(!ismob(loc))
return FALSE
var/mob/user = loc
if(rand(0,250) == 0)
to_chat(user, span_notice("You feel your jetpack's engines cut out."))
turn_off(user)
return
return ..()
/obj/item/tank/jetpack/void
name = "void jetpack (oxygen)"
desc = "It works well in a void."
icon_state = "jetpack-void"
inhand_icon_state = "jetpack-void"
/obj/item/tank/jetpack/oxygen
name = "jetpack (oxygen)"
desc = "A tank of compressed oxygen for use as propulsion in zero-gravity areas. Use with caution."
icon_state = "jetpack"
inhand_icon_state = "jetpack"
/obj/item/tank/jetpack/oxygen/harness
name = "jet harness (oxygen)"
desc = "A lightweight tactical harness, used by those who don't want to be weighed down by traditional jetpacks."
icon_state = "jetpack-mini"
inhand_icon_state = "jetpack-black"
volume = 40
throw_range = 7
w_class = WEIGHT_CLASS_NORMAL
/obj/item/tank/jetpack/oxygen/captain
name = "captain's jetpack"
desc = "A compact, lightweight jetpack containing a high amount of compressed oxygen."
icon_state = "jetpack-captain"
inhand_icon_state = "jetpack-captain"
w_class = WEIGHT_CLASS_NORMAL
volume = 90
resistance_flags = INDESTRUCTIBLE | LAVA_PROOF | FIRE_PROOF | ACID_PROOF //steal objective items are hard to destroy.
slot_flags = ITEM_SLOT_BACK | ITEM_SLOT_SUITSTORE
drift_force = 2 NEWTONS
stabilizer_force = 2 NEWTONS
/obj/item/tank/jetpack/oxygen/security
name = "security jetpack (oxygen)"
desc = "A tank of compressed oxygen for use as propulsion in zero-gravity areas by security forces."
icon_state = "jetpack-sec"
inhand_icon_state = "jetpack-sec"
/obj/item/tank/jetpack/carbondioxide
name = "jetpack (carbon dioxide)"
desc = "A tank of compressed carbon dioxide for use as propulsion in zero-gravity areas. Painted black to indicate that it should not be used as a source for internals."
icon_state = "jetpack-black"
inhand_icon_state = "jetpack-black"
distribute_pressure = 0
gas_type = /datum/gas/carbon_dioxide
Reference in New Issue View Git Blame Copy Permalink