mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-08-27 07:08:00 +01:00
Joshua KidderandGitHub
7a3ad79506
## About The Pull Request It's just a partial cleanup of anti-[STYLE](https://github.com/tgstation/tgstation/blob/master/.github/guides/STYLE.md) code from /tg/'s ancient history. I compiled & tested with my helpful assistant and damage is still working. <img width="1920" height="1040" alt="image" src="https://github.com/user-attachments/assets/26dabc17-088f-4008-b299-3ff4c27142c3" /> I'll upload the .cs script I used to do it shortly. ## Why It's Good For The Game Just minor code cleanup. Script used is located at https://metek.tech/camelTo-Snake.7z EDIT 11/23/25: Updated the script to use multithreading and sequential scan so it works a hell of a lot faster ``` /* // Copyright 2025 Joshua 'Joan Metekillot' Kidder This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with this program. If not, see <https://www.gnu.org/licenses/>. // */ using System.Text.RegularExpressions; class Program { static async Task Main(string[] args) { var readFile = new FileStreamOptions { Access = FileAccess.Read, Share = FileShare.ReadWrite, Options = FileOptions.Asynchronous | FileOptions.SequentialScan }; FileStreamOptions writeFile = new FileStreamOptions { Share = FileShare.ReadWrite, Access = FileAccess.ReadWrite, Mode = FileMode.Truncate, Options = FileOptions.Asynchronous }; RegexOptions regexOptions = RegexOptions.Multiline | RegexOptions.Compiled; Dictionary<string, int> changedProcs = new(); string regexPattern = @"(?<=\P{L})([a-z]+)([A-Z]{1,2}[a-z]+)*(Brute|Burn|Fire|Tox|Oxy|Organ|Stamina)(Loss)([A-Z]{1,2}[a-z]+)*"; Regex camelCaseProcRegex = new(regexPattern, regexOptions); string snakeify(Match matchingRegex) { var vals = matchingRegex.Groups.Cast<Group>().SelectMany(_ => _.Captures).Select(_ => _.Value).ToArray(); var newVal = string.Join("_", vals.Skip(1).ToArray()).ToLower(); string logString = $"{vals[0]} => {newVal}"; if (changedProcs.TryGetValue(logString, out int value)) { changedProcs[logString] = value + 1; } else { changedProcs.Add(logString, 1); } return newVal; } var dmFiles = Directory.EnumerateFiles(".", "*.dm", SearchOption.AllDirectories).ToAsyncEnumerable<string>(); // uses default ParallelOptions // https://learn.microsoft.com/en-us/dotnet/api/system.threading.tasks.paralleloptions?view=net-10.0#main await Parallel.ForEachAsync(dmFiles, async (filePath, UnusedCancellationToken) => { var reader = new StreamReader(filePath, readFile); string oldContent = await reader.ReadToEndAsync(); string newContent = camelCaseProcRegex.Replace(oldContent, new MatchEvaluator((Func<Match, string>)snakeify)); if (oldContent != newContent) { var writer = new StreamWriter(filePath, writeFile); await writer.WriteAsync(newContent); await writer.DisposeAsync(); } reader.Dispose(); }); var logToList = changedProcs.Cast<KeyValuePair<string, int>>().ToList(); foreach (var pair in logToList) { Console.WriteLine($"{pair.Key}: {pair.Value} locations"); } } } ``` ## Changelog 🆑 Bisar code: All (Brute|Burn|Fire|Tox|Oxy|Organ|Stamina)(Loss) procs now use snake_case, in-line with the STYLE guide. Underscores rule! /🆑
39 lines
1.6 KiB
Plaintext
39 lines
1.6 KiB
Plaintext
/* A couple of brain tumor stats for anyone curious / looking at this quirk for balancing:
|
|
* - It takes less 16 minute 40 seconds to die from brain death due to a brain tumor.
|
|
* - It takes 1 minutes 40 seconds to take 10% (20 organ damage) brain damage.
|
|
* - 5u mannitol will heal 12.5% (25 organ damage) brain damage
|
|
*/
|
|
/datum/quirk/item_quirk/brainproblems
|
|
name = "Brain Tumor"
|
|
desc = "You have a little friend in your brain that is slowly destroying it. Better bring some mannitol!"
|
|
icon = FA_ICON_BRAIN
|
|
value = -12
|
|
gain_text = span_danger("You feel smooth.")
|
|
lose_text = span_notice("You feel wrinkled again.")
|
|
medical_record_text = "Patient has a tumor in their brain that is slowly driving them to brain death."
|
|
hardcore_value = 12
|
|
quirk_flags = QUIRK_HUMAN_ONLY|QUIRK_PROCESSES
|
|
mail_goodies = list(/obj/item/storage/pill_bottle/mannitol/braintumor)
|
|
no_process_traits = list(TRAIT_TUMOR_SUPPRESSED)
|
|
|
|
/datum/quirk/item_quirk/brainproblems/add_unique(client/client_source)
|
|
give_item_to_holder(
|
|
/obj/item/storage/pill_bottle/mannitol/braintumor,
|
|
list(
|
|
LOCATION_LPOCKET,
|
|
LOCATION_RPOCKET,
|
|
LOCATION_BACKPACK,
|
|
LOCATION_HANDS,
|
|
),
|
|
flavour_text = "These will keep you alive until you can secure a supply of medication. Don't rely on them too much!",
|
|
notify_player = TRUE,
|
|
)
|
|
|
|
/datum/quirk/item_quirk/brainproblems/is_species_appropriate(datum/species/mob_species)
|
|
if(ispath(mob_species, /datum/species/dullahan))
|
|
return FALSE
|
|
return ..()
|
|
|
|
/datum/quirk/item_quirk/brainproblems/process(seconds_per_tick)
|
|
quirk_holder.adjust_organ_loss(ORGAN_SLOT_BRAIN, 0.2 * seconds_per_tick)
|