mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-07-11 08:06:33 +01:00
paganiy
b8f75406c1
## About The Pull Request Cleans up the recycler code to be easier to read and work better: - Combined safety checks into one function. - Preventing unnecessary item collection from mobs when safety mode is active. - Fixing issue with deleting content of holographic objects. (i think this bug still exists in many other places in code where holograms are being deleted) - Unit test. ## Why It's Good For The Game It's good, i think. ## Changelog 🆑 fix: Fixed recycler deconstruction. fix: Holograms now properly drop their contents when processed in recycler instead of deleting them. code: Cleaned up recycler code. /🆑
85 lines
4.7 KiB
Plaintext
85 lines
4.7 KiB
Plaintext
// Unit tests for recycler machine.
|
|
|
|
/// Tests that holographic item are properly processed - deleted while preserving real contents.
|
|
/datum/unit_test/recycler_hologram
|
|
|
|
/datum/unit_test/recycler_hologram/Run()
|
|
var/obj/machinery/recycler/recycler = allocate(/obj/machinery/recycler/deathtrap, get_step(run_loc_floor_bottom_left, EAST))
|
|
var/obj/structure/closet/hologram_closet = allocate(/obj/structure/closet, run_loc_floor_bottom_left)
|
|
// Hologram closet that could contain non-holographic objects.
|
|
hologram_closet.flags_1 |= HOLOGRAM_1
|
|
// Add real, non-holographic cookie.
|
|
var/obj/item/food/cookie/real_cookie = allocate(/obj/item/food/cookie, hologram_closet)
|
|
// And a real human being.
|
|
var/mob/living/carbon/human/assistant = allocate(/mob/living/carbon/human/consistent, hologram_closet)
|
|
// Abstract cookie won't be recycled. But will be deleted if the contents of hologram aren't managed.
|
|
real_cookie.item_flags |= ABSTRACT
|
|
// Process the hologram through the recycler.
|
|
hologram_closet.forceMove(get_turf(recycler))
|
|
// Check that hologram was properly deleted.
|
|
TEST_ASSERT(QDELETED(hologram_closet), "Hologram item was not deleted after processing")
|
|
// Check that real items were moved to recycler location (not deleted).
|
|
TEST_ASSERT(!QDELETED(real_cookie), "Non-holographic contents of holographic object was incorrectly deleted with hologram")
|
|
// Check that mobs were moved to recycler location (not deleted).
|
|
TEST_ASSERT(!QDELETED(assistant), "Mob inside of holographic object was incorrectly deleted with hologram")
|
|
TEST_ASSERT_EQUAL(assistant.loc, get_turf(recycler), "Mob inside of holographic object was not moved to recycler location")
|
|
TEST_ASSERT_EQUAL(real_cookie.loc, get_turf(recycler), "Non-holographic contents of holographic object was not moved to recycler location")
|
|
|
|
/// Tests that recycler properly handles indestructible item.
|
|
/datum/unit_test/recycler_indestructible_item
|
|
|
|
/datum/unit_test/recycler_indestructible_item/Run()
|
|
var/obj/machinery/recycler/recycler = allocate(/obj/machinery/recycler/deathtrap, get_step(run_loc_floor_bottom_left, EAST))
|
|
// Create indestructible cookie.
|
|
var/obj/item/food/cookie/indestructible_cookie = allocate(/obj/item/food/cookie, run_loc_floor_bottom_left)
|
|
indestructible_cookie.resistance_flags |= INDESTRUCTIBLE
|
|
// Try to process indestructible cookie.
|
|
indestructible_cookie.forceMove(get_turf(recycler))
|
|
// Cookie should still exist.
|
|
TEST_ASSERT(!QDELETED(indestructible_cookie), "Indestructible item was recycled")
|
|
|
|
/// Tests that recycler properly handles abstract item.
|
|
/datum/unit_test/recycler_abstract_item
|
|
|
|
/datum/unit_test/recycler_abstract_item/Run()
|
|
var/obj/machinery/recycler/recycler = allocate(/obj/machinery/recycler/deathtrap, get_step(run_loc_floor_bottom_left, EAST))
|
|
// Create abstract cookie.
|
|
var/obj/item/food/cookie/abstract_cookie = allocate(/obj/item/food/cookie, run_loc_floor_bottom_left)
|
|
abstract_cookie.item_flags |= ABSTRACT
|
|
// Try to process abstract cookie.
|
|
abstract_cookie.forceMove(get_turf(recycler))
|
|
// Cookie should still exist.
|
|
TEST_ASSERT(!QDELETED(abstract_cookie), "Abstract item was recycled")
|
|
|
|
/// Tests that brains trigger safety mode in the recycler.
|
|
/datum/unit_test/recycler_brain_safety
|
|
|
|
/datum/unit_test/recycler_brain_safety/Run()
|
|
var/obj/machinery/recycler/recycler = allocate(/obj/machinery/recycler, get_step(run_loc_floor_bottom_left, EAST))
|
|
var/mob/living/brain/test_brain = allocate(/mob/living/brain, run_loc_floor_bottom_left)
|
|
// Process brain - should trigger safety mode.
|
|
test_brain.forceMove(get_turf(recycler))
|
|
// Should enter safety mode.
|
|
TEST_ASSERT(recycler.safety_mode, "Recycler did not enter safety mode when processing brain")
|
|
// Brain should not be deleted.
|
|
TEST_ASSERT(!QDELETED(test_brain), "Brain was incorrectly deleted in safety mode")
|
|
|
|
/// Tests that MMI with brain triggers safety mode.
|
|
/datum/unit_test/recycler_mmi_with_brain_safety
|
|
|
|
/datum/unit_test/recycler_mmi_with_brain_safety/Run()
|
|
var/obj/machinery/recycler/recycler = allocate(/obj/machinery/recycler, get_step(run_loc_floor_bottom_left, EAST))
|
|
var/obj/item/mmi/test_mmi = allocate(/obj/item/mmi, run_loc_floor_bottom_left)
|
|
var/mob/living/brain/test_brain = allocate(/mob/living/brain, run_loc_floor_bottom_left)
|
|
// Insert brain into MMI.
|
|
test_mmi.brain = test_brain
|
|
test_brain.forceMove(test_mmi)
|
|
// Process MMI with brain - should trigger safety mode.
|
|
test_mmi.forceMove(get_turf(recycler))
|
|
// Should enter safety mode.
|
|
TEST_ASSERT(recycler.safety_mode, "Recycler did not enter safety mode when processing MMI with brain")
|
|
// MMI should not be deleted.
|
|
TEST_ASSERT(!QDELETED(test_mmi), "MMI with brain was incorrectly deleted in safety mode")
|
|
// Brain should still be intact inside MMI.
|
|
TEST_ASSERT(!QDELETED(test_mmi.brain), "Brain was deleted during safety mode processing")
|