cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-28 07:38:05 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
docker-container
Bubberstation/code/modules/vehicles/mecha/mecha_actions.dm
T
Tsar-SalatandGitHub 0917d44cc8 Audits and cleans up Trigger() parent calls (#95548) 
## About The Pull Request

``/datum/action/proc/Trigger(mob/clicker, trigger_flags)`` has a lot of
children, many of which use mixed ``. = ..()`` or no parent calls at
all.


https://github.com/tgstation/tgstation/blob/d65ee47f6ebd0384d463a1f2a044c321ff2d912f/code/datums/actions/action.dm#L163-L170

This PR attempts to standardize all the children procs to call parent in
a uniform way, or cements that they *shouldnt* call parent for whatever
reason.
## Why It's Good For The Game

Base proc calls are important, yanno?

The base proc has the action button signals and availability proc on it,
so its technically possible for children procs of trigger() to have
check_flags enabled, but never blocked (i.e AB_CHECK_CONSCIOUS,
AB_CHECK_HANDS_BLOCKED).

Some children procs have IsAvailable on them, but its possible they can
be skipped over if a coder is not paying attention. This reduces that
risk.
2026-04-07 14:23:25 -05:00

295 lines
9.9 KiB
Plaintext
Raw Permalink Blame History

/***************** MECHA ACTIONS *****************/
/obj/vehicle/sealed/mecha/generate_action_type()
. = ..()
if(istype(., /datum/action/vehicle/sealed/mecha))
var/datum/action/vehicle/sealed/mecha/mecha_action = .
mecha_action.set_chassis(src)
/datum/action/vehicle/sealed/mecha
button_icon = 'icons/mob/actions/actions_mecha.dmi'
var/obj/vehicle/sealed/mecha/chassis
/datum/action/vehicle/sealed/mecha/Destroy()
chassis = null
return ..()
///Sets the chassis var of our mecha action to the referenced mecha. Used during actions generation in
///generate_action_type() chain.
/datum/action/vehicle/sealed/mecha/proc/set_chassis(passed_chassis)
chassis = passed_chassis
/datum/action/vehicle/sealed/mecha/mech_eject
name = "Eject From Mech"
button_icon_state = "mech_eject"
/datum/action/vehicle/sealed/mecha/mech_eject/Trigger(mob/clicker, trigger_flags)
. = ..()
if(!.)
return
if(!chassis || !(owner in chassis.occupants))
return
chassis.container_resist_act(owner)
/datum/action/vehicle/sealed/mecha/mech_toggle_cabin_seal
name = "Toggle Cabin Airtight"
button_icon_state = "mech_cabin_open"
desc = "Airtight cabin preserves internal air and can be pressurized with a mounted air tank."
/datum/action/vehicle/sealed/mecha/mech_toggle_cabin_seal/Trigger(mob/clicker, trigger_flags)
. = ..()
if(!.)
return
if(!chassis || !(owner in chassis.occupants))
return
chassis.set_cabin_seal(owner, !chassis.cabin_sealed)
/datum/action/vehicle/sealed/mecha/mech_toggle_lights
name = "Toggle Lights"
button_icon_state = "mech_lights_off"
/datum/action/vehicle/sealed/mecha/mech_toggle_lights/Trigger(mob/clicker, trigger_flags)
. = ..()
if(!.)
return
if(!chassis || !(owner in chassis.occupants))
return
chassis.toggle_lights(user = owner)
/datum/action/vehicle/sealed/mecha/mech_view_stats
name = "View Stats"
button_icon_state = "mech_view_stats"
/datum/action/vehicle/sealed/mecha/mech_view_stats/Trigger(mob/clicker, trigger_flags)
. = ..()
if(!.)
return
if(!chassis || !(owner in chassis.occupants))
return
chassis.ui_interact(owner)
/datum/action/vehicle/sealed/mecha/mech_toggle_safeties
name = "Toggle Equipment Safeties"
button_icon_state = "mech_safeties_off"
/datum/action/vehicle/sealed/mecha/mech_toggle_safeties/set_chassis(passed_chassis)
. = ..()
RegisterSignal(chassis, COMSIG_MECH_SAFETIES_TOGGLE, PROC_REF(update_action_icon))
/datum/action/vehicle/sealed/mecha/mech_toggle_safeties/Trigger(mob/clicker, trigger_flags)
. = ..()
if(!.)
return
if(!chassis || !(owner in chassis.occupants))
return
chassis.set_safety(owner)
/datum/action/vehicle/sealed/mecha/mech_toggle_safeties/apply_button_icon(atom/movable/screen/movable/action_button/current_button, force)
button_icon_state = "mech_safeties_[chassis.weapons_safety ? "on" : "off"]"
return ..()
/datum/action/vehicle/sealed/mecha/mech_toggle_safeties/proc/update_action_icon()
SIGNAL_HANDLER
build_all_button_icons()
/datum/action/vehicle/sealed/mecha/strafe
name = "Toggle Strafing. Disabled when Alt is held."
button_icon_state = "strafe"
/datum/action/vehicle/sealed/mecha/strafe/Trigger(mob/clicker, trigger_flags)
. = ..()
if(!.)
return
if(!chassis || !(owner in chassis.occupants))
return
chassis.toggle_strafe()
/obj/vehicle/sealed/mecha/proc/toggle_strafe()
if(!(mecha_flags & CAN_STRAFE))
to_chat(occupants, "this mecha doesn't support strafing!")
return
strafe = !strafe
for(var/mob/occupant in occupants)
balloon_alert(occupant, "strafing [strafe?"on":"off"]")
occupant.playsound_local(src, 'sound/machines/terminal/terminal_eject.ogg', 50, TRUE)
log_message("Toggled strafing mode [strafe?"on":"off"].", LOG_MECHA)
for(var/occupant in occupants)
var/datum/action/action = LAZYACCESSASSOC(occupant_actions, occupant, /datum/action/vehicle/sealed/mecha/strafe)
action?.build_all_button_icons()
///swap seats, for two person mecha
/datum/action/vehicle/sealed/mecha/swap_seat
name = "Switch Seats"
button_icon_state = "mech_seat_swap"
/datum/action/vehicle/sealed/mecha/swap_seat/Trigger(mob/clicker, trigger_flags)
. = ..()
if(!.)
return
if(!chassis || !(owner in chassis.occupants))
return
if(chassis.occupants.len == chassis.max_occupants)
chassis.balloon_alert(owner, "other seat occupied!")
return
var/list/drivers = chassis.return_drivers()
chassis.balloon_alert(owner, "moving to other seat...")
chassis.is_currently_ejecting = TRUE
if(!do_after(owner, chassis.has_gravity() ? chassis.exit_delay : 0 , target = chassis))
chassis.balloon_alert(owner, "interrupted!")
chassis.is_currently_ejecting = FALSE
return
chassis.is_currently_ejecting = FALSE
if(owner in drivers)
chassis.balloon_alert(owner, "controlling gunner seat")
chassis.remove_control_flags(owner, VEHICLE_CONTROL_DRIVE|VEHICLE_CONTROL_SETTINGS)
chassis.add_control_flags(owner, VEHICLE_CONTROL_MELEE|VEHICLE_CONTROL_EQUIPMENT)
chassis.remove_all_equipment_actions(owner)
else
chassis.balloon_alert(owner, "controlling pilot seat")
chassis.remove_control_flags(owner, VEHICLE_CONTROL_MELEE|VEHICLE_CONTROL_EQUIPMENT)
chassis.add_control_flags(owner, VEHICLE_CONTROL_DRIVE|VEHICLE_CONTROL_SETTINGS)
chassis.generate_equipment_actions(owner)
chassis.update_icon_state()
/datum/action/vehicle/sealed/mecha/mech_overclock
name = "Toggle Overclocking"
desc = "Increases mech speed and power at the cost of heat generation."
button_icon_state = "mech_overload_off"
/datum/action/vehicle/sealed/mecha/mech_overclock/siren/New()
. = ..()
build_all_button_icons()
/datum/action/vehicle/sealed/mecha/mech_overclock/Trigger(mob/clicker, trigger_flags, forced_state = null)
. = ..()
if(!.)
return
if(!chassis || !(owner in chassis.occupants))
return
chassis.toggle_overclock(forced_state)
build_all_button_icons()
/datum/action/vehicle/sealed/mecha/mech_overclock/apply_button_icon(atom/movable/screen/movable/action_button/current_button, force)
button_icon_state = get_button_icon_state()
return ..()
/datum/action/vehicle/sealed/mecha/mech_overclock/proc/get_button_icon_state()
return "mech_overload_[chassis.overclock_mode ? "on" : "off"]"
/datum/action/vehicle/sealed/mecha/equipment
name = "Mech Equipment"
button_icon_state = null
background_icon_state = "bg_tech"
var/obj/item/mecha_parts/mecha_equipment/equipment
/datum/action/vehicle/sealed/mecha/equipment/Destroy()
equipment = null
return ..()
/datum/action/vehicle/sealed/mecha/equipment/Trigger(mob/clicker, trigger_flags)
. = ..()
if(!.)
return
if(!chassis || !(owner in chassis.occupants) || !equipment)
return
equipment.set_active(!equipment.active)
equipment.handle_ui_act(action = "toggle")
chassis.balloon_alert(owner, "[equipment.name] [equipment.active ? "on" : "off"]!")
/datum/action/vehicle/sealed/mecha/equipment/proc/set_equipment(passed_equipment)
equipment = passed_equipment
name = "Toggle [equipment.name]"
desc = equipment.desc
target = equipment
if(target)
AddComponent(/datum/component/action_item_overlay, equipment)
build_button_icon()
/datum/action/vehicle/sealed/mecha/equipment/cargo_module
name = "Cargo Module"
/datum/action/vehicle/sealed/mecha/equipment/cargo_module/set_equipment(passed_equipment)
. = ..()
name = "[equipment.name]"
/datum/action/vehicle/sealed/mecha/equipment/cargo_module/Trigger(mob/clicker, trigger_flags)
SHOULD_CALL_PARENT(FALSE) //We are snowflaked from parent
if(!chassis || !(owner in chassis.occupants) || !equipment)
return
if(!istype(equipment, /obj/item/mecha_parts/mecha_equipment/ejector))
return
var/obj/item/mecha_parts/mecha_equipment/ejector/cargo_hold = equipment
// Right click - show radial menu
if(trigger_flags & TRIGGER_SECONDARY_ACTION)
var/list/cargo_radial = list()
for(var/atom/movable/cargo_item in cargo_hold.contents)
cargo_radial[cargo_item] = cargo_item.appearance
if(!length(cargo_radial))
chassis.balloon_alert(owner, "cargo hold empty!")
return
var/atom/movable/picked_item = show_radial_menu(owner, chassis, cargo_radial, require_near = TRUE)
if(!picked_item || !(picked_item in cargo_hold.contents))
return
to_chat(chassis.occupants, "[icon2html(cargo_hold, chassis.occupants)][span_notice("You unload [picked_item].")]")
picked_item.forceMove(cargo_hold.drop_location())
if(picked_item == chassis.ore_box)
chassis.ore_box = null
playsound(chassis, 'sound/items/weapons/tap.ogg', 50, TRUE)
cargo_hold.log_message("Unloaded [picked_item]. Cargo compartment capacity: [cargo_hold.cargo_capacity - cargo_hold.contents.len]", LOG_MECHA)
return
// Left click - dispose first item
if(cargo_hold.contents.len)
var/atom/movable/first_item = cargo_hold.contents[1]
to_chat(chassis.occupants, "[icon2html(cargo_hold, chassis.occupants)][span_notice("You unload [first_item].")]")
first_item.forceMove(cargo_hold.drop_location())
if(first_item == chassis.ore_box)
chassis.ore_box = null
playsound(chassis, 'sound/items/weapons/tap.ogg', 50, TRUE)
cargo_hold.log_message("Unloaded [first_item]. Cargo compartment capacity: [cargo_hold.cargo_capacity - cargo_hold.contents.len]", LOG_MECHA)
else
chassis.balloon_alert(owner, "cargo hold empty!")
/datum/action/vehicle/sealed/mecha/equipment/extinguisher_action
name = "Extinguisher"
/datum/action/vehicle/sealed/mecha/equipment/extinguisher_action/set_equipment(passed_equipment)
. = ..()
name = "[equipment.name]"
/datum/action/vehicle/sealed/mecha/equipment/extinguisher_action/Trigger(mob/clicker, trigger_flags)
SHOULD_CALL_PARENT(FALSE) //We are snowflaked from parent
if(!chassis || !(owner in chassis.occupants) || !equipment)
return
if(!istype(equipment, /obj/item/mecha_parts/mecha_equipment/extinguisher))
return
var/obj/item/mecha_parts/mecha_equipment/extinguisher/extinguisher = equipment
// Right click - refill
if(trigger_flags & TRIGGER_SECONDARY_ACTION)
extinguisher.attempt_refill(owner)
return
// Left click - spray
if(extinguisher.reagents.total_volume < extinguisher.required_amount)
chassis.balloon_alert(owner, "not enough water!")
return
extinguisher.spray_extinguisher(owner)
Reference in New Issue View Git Blame Copy Permalink