mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-09 07:46:20 +00:00
## About The Pull Request  The original purpose of this PR was to extend the previous Magazine Miscellany PR by adding the ability to recolor magazine indicators if they had a defined icon. This functionality is present by using a pen on a magazine that has a defined ammo band icon state. This PR also further standardizes magazines with different ammo types by using a define to append their description and magazine color for AP ammo, hollow-points, and incendiary ammo. This PR also _also_ gives ammo indicator bands to the magazines for the Stechkin APS and C-20r. And also gives descriptions to every magazine so they're not using a placeholder that mentions error signs anymore. Each description is roughly in the format of "caliber, suitable for gun". Not sure if I should standardize magazine names to be "caliber and special ammo type" - the only outlier I can think of right now for that would be the 7mm ammo boxes for the L6. ## Why It's Good For The Game Ammo stripes are neat, functionally, so changing the stripes on magazines in case someone chooses to reload spent mags with autolathe ammo is probably nice as a QoL thing. Descriptions that aren't placeholders are pretty cool too. ## Changelog 🆑 add: Magazines with defined ammo bands can now have their color changed with a pen, in case you're reloading spent magazines or speedloaders with different ammunition and want to change magazine colors to be appropriate. qol: C-20r magazines and Stechkin APS magazines now have ammo band support. qol: Standardized some descriptions for AP, HP, and incendiary magazines. /🆑 --------- Co-authored-by: Hatterhat <Hatterhat@users.noreply.github.com>
22 lines
1.7 KiB
Plaintext
22 lines
1.7 KiB
Plaintext
/// Appended to the description of magazines that spawn with old-fashioned incendiary ammo, which generally leave fire trails and give firestacks in return for less base damage.
|
|
#define MAGAZINE_DESC_INC "<br>Carries rounds which ignite targets and leave flaming trails, but inflict less damage."
|
|
/// Appended to the description of magazines that spawn with hollow-point ammo, which generally has higher base damage but is weak against armor.
|
|
#define MAGAZINE_DESC_HOLLOWPOINT "<br>Carries hollow-point rounds which are effective against unarmored targets, but suffer greatly against armor."
|
|
/// Appended to the description of magazines that spawn with armor-piercing ammo, which generally has less base damage but penetrates armor.
|
|
#define MAGAZINE_DESC_ARMORPIERCE "<br>Carries armor-piercing rounds which are effective against armored targets, but less effective against unarmored targets."
|
|
|
|
/// Defines a magazine to, visually, be for incendiary ammo by setting the ammo band color and appending a short blurb to the description.
|
|
#define MAGAZINE_TYPE_INCENDIARY \
|
|
ammo_band_color = COLOR_AMMO_INCENDIARY; \
|
|
desc = parent_type::desc + MAGAZINE_DESC_INC;
|
|
|
|
/// Defines a magazine to, visually, be for hollow-point ammo by setting the ammo band color and appending a short blurb to the description.
|
|
#define MAGAZINE_TYPE_HOLLOWPOINT \
|
|
ammo_band_color = COLOR_AMMO_HOLLOWPOINT; \
|
|
desc = parent_type::desc + MAGAZINE_DESC_HOLLOWPOINT;
|
|
|
|
/// Defines a magazine to, visually, be for armor-piercing ammo by setting the ammo band color and appending a short blurb to the description.
|
|
#define MAGAZINE_TYPE_ARMORPIERCE \
|
|
ammo_band_color = COLOR_AMMO_ARMORPIERCE; \
|
|
desc = parent_type::desc + MAGAZINE_DESC_ARMORPIERCE;
|