mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-07-12 16:44:43 +01:00
Roxy
436f766c3b
## About The Pull Request This is a general clean up of some of our modular vending machine code, highlights are: - Merges the skyrat `modular_vending` folder into our own - Eliminates the `skyrat_products`, `skyrat_product_categories`, `skyrat_contraband`, and `skyrat_premium` vars, merge their stuff into the bubber equivalents - Changes the handling for modular autodrobe additions to just add them to the global list because the autodrobe uses global lists for some reason, this fixes #4758 - Change a `+=` to `|=` to prevent duplicate entries in vending machines causing both to appear out of stock - Fix a duplicate recolor button in the vending machine TGUI ## Why It's Good For The Game Less duplicate code and bugs, the autodrobe one in particular was funny because what was happening is the category lists of items were global lists, and the modular code for adding our own stuff to categories just `+=` adds it, and that runs every time an autodrobe is created on the map, so each time the same stuff was being added to the same list and bloating it to several hundred ## Proof Of Testing <details> <summary>Screenshots/Videos</summary> <img width="425" height="559" alt="image" src="https://github.com/user-attachments/assets/e9ab16ed-3c7c-4061-90d5-dc27a7d8a40e" /> </details> ## Changelog 🆑 fix: fixed the autodrobe being mostly out of stock and broken fix: fixed certain vending machines having duplicate items that broke fix: fixed a bug with the recolor button in vending machines appearing twice code: merged modular skyrat vending machine code into our folder /🆑