Hookie
bff9c3b528
## About The Pull Request A downstream, a fork of a downstream, and a fork of a fork of a downstream all walk into Github. The contributor says; _"I'm gonna have to fix this bug three times, aren't I?"_ Milsim CIN NPCs used an old way of causing mobs to drop corpses by putting them in their loot table. This was eventually deprecated, and their subtype was eventually given a **corpse** variable to keep their bodies in. Milsim NPCs were not updated to account for this, causing them to drop the default corpse and their own corpse. This fixes this by simply replacing the loot definition with a corpse definition. There was a reference to an item that doesn't exist in Milsim. That's been replaced with what it was almost certainly supposed to have been in the first place. I assume this doesn't need to be modular, since these are Skyrat files. Correct me if I'm wrong, I do not play or know anything particularly about Bubber. ## Why It's Good For The Game fix bug ## Proof Of Testing <details> <summary>Screenshots/Videos</summary> <img width="256" height="278" alt="one corpes" src="https://github.com/user-attachments/assets/804c7c0b-3c7d-4557-a61c-b2ef7caeed28" /> <img width="237" height="187" alt="image" src="https://github.com/user-attachments/assets/b01f680b-a001-4e03-b40f-864fba91a000" /> </details> ## Changelog 🆑 fix: Virtual CIN Soldiers will no longer undergo mitosis upon death. fix: Fixed a non-existent item in Milsim. /🆑 Co-authored-by: gavla <96078776+shayoki@users.noreply.github.com>
Making new virtual domains
REQUIRED:
- One way that the encrypted cache can spawn. This can be from a mob drop, a landmark (place a few, it'll pick one), or a signal landmark if you have a points system.
- Place a virtual domain baseturf helper in each area.
- If you're using modular safehouses, ensure that the map has ONE tile marked with the safehouse modular map loader (and set the KEY). it will need an open 7x6 area.
- Placing a safehouse area is redundant, but it will ensure there is power in the starting safehouse.
- Create the dm file that defines the map qualities. You can use the existing ones as a template.
- Place a virtual domain baseturf helper in each area.
Converting an existing map
- Create a new map using the existing map's size - give yourself enough room to enclose it with a binary wall. There's no need for any space outside of it, so ensure that it fits and is enclosed, nothing outside of this.
- Copy and paste the existing map into it.
- Find an accessible area for a safehouse, 7x6.
- Place a bottom left safehouse landmark somewhere on the map to load the safehouse.
Notes
You shouldn't need to fully enclose your map in 15 tiles of binary filler. Using one solid wall should do the trick.
For areas, ideally just one on the map and one for the safehouse. Vdoms should never last so long as to need individual area power and atmos unless you're specifically going for a gimmick.
Make it modular: Add modular map and mob segments! It adds variety. Just make sure you've set your map to have "is_modular" afterwards.
Adding some open tile padding around the safehouse is a good touch. About 7 tiles West/East for the visual effect of a larger map.
If you want to add prep gear, you can do so within the safehouse's area as long you don't overlap with goal turfs or exit spawners. The top left corner is a good spot for this, with respect for the walls, therefore [1, 1], [1, 2], [1, 3]
You can also create a specific safehouse if you find yourself needing the same gear over and over again. There is a readme for that as well.
Boss zones should give players pretty ample space, I've been using a 23x23 minimum area.
While it's not a hard set rule, 75x75 is the guideline for max size. The main issue is keeping them in the domain for too long.
You have the option of baking in your own safehouse and ignoring the 7x6 guideline. To do this, you will still need a safehouse landmark and a file to load - even if it's empty. Ensure that you have the necessary landmarks placed that normally go in a safehouse on the map itself.