mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-07-13 17:14:47 +01:00
7a3ad79506
## About The Pull Request It's just a partial cleanup of anti-[STYLE](https://github.com/tgstation/tgstation/blob/master/.github/guides/STYLE.md) code from /tg/'s ancient history. I compiled & tested with my helpful assistant and damage is still working. <img width="1920" height="1040" alt="image" src="https://github.com/user-attachments/assets/26dabc17-088f-4008-b299-3ff4c27142c3" /> I'll upload the .cs script I used to do it shortly. ## Why It's Good For The Game Just minor code cleanup. Script used is located at https://metek.tech/camelTo-Snake.7z EDIT 11/23/25: Updated the script to use multithreading and sequential scan so it works a hell of a lot faster ``` /* // Copyright 2025 Joshua 'Joan Metekillot' Kidder This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with this program. If not, see <https://www.gnu.org/licenses/>. // */ using System.Text.RegularExpressions; class Program { static async Task Main(string[] args) { var readFile = new FileStreamOptions { Access = FileAccess.Read, Share = FileShare.ReadWrite, Options = FileOptions.Asynchronous | FileOptions.SequentialScan }; FileStreamOptions writeFile = new FileStreamOptions { Share = FileShare.ReadWrite, Access = FileAccess.ReadWrite, Mode = FileMode.Truncate, Options = FileOptions.Asynchronous }; RegexOptions regexOptions = RegexOptions.Multiline | RegexOptions.Compiled; Dictionary<string, int> changedProcs = new(); string regexPattern = @"(?<=\P{L})([a-z]+)([A-Z]{1,2}[a-z]+)*(Brute|Burn|Fire|Tox|Oxy|Organ|Stamina)(Loss)([A-Z]{1,2}[a-z]+)*"; Regex camelCaseProcRegex = new(regexPattern, regexOptions); string snakeify(Match matchingRegex) { var vals = matchingRegex.Groups.Cast<Group>().SelectMany(_ => _.Captures).Select(_ => _.Value).ToArray(); var newVal = string.Join("_", vals.Skip(1).ToArray()).ToLower(); string logString = $"{vals[0]} => {newVal}"; if (changedProcs.TryGetValue(logString, out int value)) { changedProcs[logString] = value + 1; } else { changedProcs.Add(logString, 1); } return newVal; } var dmFiles = Directory.EnumerateFiles(".", "*.dm", SearchOption.AllDirectories).ToAsyncEnumerable<string>(); // uses default ParallelOptions // https://learn.microsoft.com/en-us/dotnet/api/system.threading.tasks.paralleloptions?view=net-10.0#main await Parallel.ForEachAsync(dmFiles, async (filePath, UnusedCancellationToken) => { var reader = new StreamReader(filePath, readFile); string oldContent = await reader.ReadToEndAsync(); string newContent = camelCaseProcRegex.Replace(oldContent, new MatchEvaluator((Func<Match, string>)snakeify)); if (oldContent != newContent) { var writer = new StreamWriter(filePath, writeFile); await writer.WriteAsync(newContent); await writer.DisposeAsync(); } reader.Dispose(); }); var logToList = changedProcs.Cast<KeyValuePair<string, int>>().ToList(); foreach (var pair in logToList) { Console.WriteLine($"{pair.Key}: {pair.Value} locations"); } } } ``` ## Changelog 🆑 Bisar code: All (Brute|Burn|Fire|Tox|Oxy|Organ|Stamina)(Loss) procs now use snake_case, in-line with the STYLE guide. Underscores rule! /🆑
122 lines
4.3 KiB
Plaintext
122 lines
4.3 KiB
Plaintext
/datum/component/heart_eater
|
|
/// Check if we fully ate whole heart and reset when we start eat new one.
|
|
var/bites_taken = 0
|
|
/// Remember the number of species damage_modifier.
|
|
var/remember_modifier = 0
|
|
/// Remember last heart we ate and reset bites_taken counter if we start eat new one
|
|
var/datum/weakref/last_heart_we_ate
|
|
/// List of all mutations allowed to get.
|
|
var/static/list/datum/mutation/mutations_list = list(
|
|
/datum/mutation/adaptation/cold,
|
|
/datum/mutation/adaptation/heat,
|
|
/datum/mutation/adaptation/pressure,
|
|
/datum/mutation/adaptation/thermal,
|
|
/datum/mutation/chameleon,
|
|
/datum/mutation/cryokinesis,
|
|
/datum/mutation/pyrokinesis,
|
|
/datum/mutation/dwarfism,
|
|
/datum/mutation/cindikinesis,
|
|
/datum/mutation/insulated,
|
|
/datum/mutation/telekinesis,
|
|
/datum/mutation/telepathy,
|
|
/datum/mutation/thermal,
|
|
/datum/mutation/tongue_spike,
|
|
/datum/mutation/webbing,
|
|
/datum/mutation/xray,
|
|
)
|
|
|
|
/datum/component/heart_eater/Initialize(...)
|
|
. = ..()
|
|
if(!ishuman(parent))
|
|
return COMPONENT_INCOMPATIBLE
|
|
prepare_species(parent)
|
|
|
|
/datum/component/heart_eater/RegisterWithParent()
|
|
. = ..()
|
|
RegisterSignal(parent, COMSIG_SPECIES_GAIN, PROC_REF(on_species_change))
|
|
RegisterSignal(parent, COMSIG_LIVING_FINISH_EAT, PROC_REF(eat_eat_eat))
|
|
|
|
/datum/component/heart_eater/UnregisterFromParent()
|
|
. = ..()
|
|
UnregisterSignal(parent, COMSIG_LIVING_FINISH_EAT)
|
|
UnregisterSignal(parent, COMSIG_SPECIES_GAIN)
|
|
|
|
/datum/component/heart_eater/proc/prepare_species(mob/living/carbon/human/eater)
|
|
if(eater.get_liked_foodtypes() & GORE)
|
|
return
|
|
var/obj/item/organ/tongue/eater_tongue = eater.get_organ_slot(ORGAN_SLOT_TONGUE)
|
|
if(!eater_tongue)
|
|
return
|
|
eater_tongue.disliked_foodtypes &= ~GORE
|
|
eater_tongue.liked_foodtypes |= GORE
|
|
|
|
/datum/component/heart_eater/proc/on_species_change(mob/living/carbon/human/eater, datum/species/new_species, datum/species/old_species, pref_load, regenerate_icons)
|
|
SIGNAL_HANDLER
|
|
|
|
eater.dna?.species?.damage_modifier += remember_modifier
|
|
prepare_species(eater)
|
|
|
|
/// Proc called when we finish eat somthing.
|
|
/datum/component/heart_eater/proc/eat_eat_eat(mob/living/carbon/human/eater, datum/what_we_ate)
|
|
SIGNAL_HANDLER
|
|
|
|
if(get_area(eater) == GLOB.areas_by_type[/area/centcom/wizard_station])
|
|
return
|
|
if(!istype(what_we_ate, /obj/item/organ/heart))
|
|
return
|
|
var/obj/item/organ/heart/we_ate_heart = what_we_ate
|
|
var/obj/item/organ/heart/previous_heart = last_heart_we_ate?.resolve()
|
|
if(we_ate_heart == previous_heart)
|
|
return
|
|
if (!HAS_TRAIT(we_ate_heart, TRAIT_USED_ORGAN))
|
|
to_chat(eater, span_warning("This heart is utterly lifeless, you won't receive any boons from consuming it!"))
|
|
return
|
|
bites_taken = 0
|
|
|
|
last_heart_we_ate = WEAKREF(we_ate_heart)
|
|
bites_taken++
|
|
if(bites_taken < (we_ate_heart.reagents.total_volume/2))
|
|
return
|
|
if(prob(50))
|
|
perfect_heart(eater)
|
|
return
|
|
not_perfect_heart(eater)
|
|
|
|
///Perfect heart give our +10 damage modifier(Max. 80).
|
|
/datum/component/heart_eater/proc/perfect_heart(mob/living/carbon/human/eater)
|
|
if(eater.dna?.species?.damage_modifier >= 80)
|
|
healing_heart(eater)
|
|
return
|
|
eater.dna?.species?.damage_modifier += 10
|
|
remember_modifier += 10
|
|
healing_heart(eater)
|
|
to_chat(eater, span_warning("This heart is perfect. You feel a surge of vital energy."))
|
|
|
|
///Not Perfect heart give random mutation.
|
|
/datum/component/heart_eater/proc/not_perfect_heart(mob/living/carbon/human/eater)
|
|
var/datum/mutation/new_mutation
|
|
var/list/datum/mutation/shuffle_mutation_list = shuffle(mutations_list)
|
|
for(var/mutation_in_list in shuffle_mutation_list)
|
|
if(is_type_in_list(mutation_in_list, eater.dna.mutations))
|
|
continue
|
|
new_mutation = mutation_in_list
|
|
break
|
|
if(isnull(new_mutation))
|
|
healing_heart(eater)
|
|
return
|
|
eater.dna.add_mutation(new_mutation, MUTATION_SOURCE_HEART_EATER)
|
|
healing_heart(eater)
|
|
to_chat(eater, span_warning("This heart is not right for you. You now have [new_mutation.name] mutation."))
|
|
|
|
///Heart eater give also strong healing from hearts.
|
|
/datum/component/heart_eater/proc/healing_heart(mob/living/carbon/human/eater)
|
|
for(var/heal_organ in eater.organs)
|
|
eater.adjust_organ_loss(heal_organ, -50)
|
|
for(var/datum/wound/heal_wound in eater.all_wounds)
|
|
heal_wound.remove_wound()
|
|
eater.adjust_brute_loss(-50)
|
|
eater.adjust_fire_loss(-50)
|
|
eater.adjust_tox_loss(-50)
|
|
eater.adjust_oxy_loss(-50)
|
|
eater.adjust_stamina_loss(-50)
|