cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-07-11 08:06:33 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
mayfools
Bubberstation/code/datums/elements/spooky.dm
T
Joshua Kidder 7a3ad79506 All camelCase (Brute|Burn|Fire|Tox|Oxy|Organ|Stamina)(Loss) procs now use snake_case. UNDERSCORES RULE! (#94111) 
## About The Pull Request
It's just a partial cleanup of
anti-[STYLE](https://github.com/tgstation/tgstation/blob/master/.github/guides/STYLE.md)
code from /tg/'s ancient history. I compiled & tested with my helpful
assistant and damage is still working.

<img width="1920" height="1040" alt="image"
src="https://github.com/user-attachments/assets/26dabc17-088f-4008-b299-3ff4c27142c3"
/>


I'll upload the .cs script I used to do it shortly.

## Why It's Good For The Game
Just minor code cleanup.

Script used is located at https://metek.tech/camelTo-Snake.7z

EDIT 11/23/25: Updated the script to use multithreading and sequential
scan so it works a hell of a lot faster
```
/*
//
Copyright 2025 Joshua 'Joan Metekillot' Kidder

This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version.

This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.

You should have received a copy of the GNU General Public License along with this program. If not, see <https://www.gnu.org/licenses/>.
//
*/
using System.Text.RegularExpressions;
class Program
{
    static async Task Main(string[] args)
    {
        var readFile = new FileStreamOptions
        {
            Access = FileAccess.Read,
            Share = FileShare.ReadWrite,
            Options = FileOptions.Asynchronous | FileOptions.SequentialScan
        };
        FileStreamOptions writeFile = new FileStreamOptions
        {
            Share = FileShare.ReadWrite,
            Access = FileAccess.ReadWrite,
            Mode = FileMode.Truncate,
            Options = FileOptions.Asynchronous
        };
        RegexOptions regexOptions = RegexOptions.Multiline | RegexOptions.Compiled;
        Dictionary<string, int> changedProcs = new();
        string regexPattern = @"(?<=\P{L})([a-z]+)([A-Z]{1,2}[a-z]+)*(Brute|Burn|Fire|Tox|Oxy|Organ|Stamina)(Loss)([A-Z]{1,2}[a-z]+)*";
        Regex camelCaseProcRegex = new(regexPattern, regexOptions);

        string snakeify(Match matchingRegex)
        {
            var vals =
            matchingRegex.Groups.Cast<Group>().SelectMany(_ => _.Captures).Select(_ => _.Value).ToArray();
            var newVal = string.Join("_", vals.Skip(1).ToArray()).ToLower();
            string logString = $"{vals[0]} => {newVal}";
            if (changedProcs.TryGetValue(logString, out int value))
            {
                changedProcs[logString] = value + 1;
            }
            else
            {
                changedProcs.Add(logString, 1);
            }
            return newVal;
        }
        var dmFiles = Directory.EnumerateFiles(".", "*.dm", SearchOption.AllDirectories).ToAsyncEnumerable<string>();

        // uses default ParallelOptions
        // https://learn.microsoft.com/en-us/dotnet/api/system.threading.tasks.paralleloptions?view=net-10.0#main
        await Parallel.ForEachAsync(dmFiles, async (filePath, UnusedCancellationToken) =>
        {
            var reader = new StreamReader(filePath, readFile);
            string oldContent = await reader.ReadToEndAsync();
            string newContent = camelCaseProcRegex.Replace(oldContent, new MatchEvaluator((Func<Match, string>)snakeify));
            if (oldContent != newContent)
            {
                var writer = new StreamWriter(filePath, writeFile);
                await writer.WriteAsync(newContent);
                await writer.DisposeAsync();
            }
            reader.Dispose();
        });
        var logToList = changedProcs.Cast<KeyValuePair<string, int>>().ToList();
        foreach (var pair in logToList)
        {
            Console.WriteLine($"{pair.Key}: {pair.Value} locations");
        }
    }
}

```

## Changelog
🆑 Bisar
code: All (Brute|Burn|Fire|Tox|Oxy|Organ|Stamina)(Loss) procs now use
snake_case, in-line with the STYLE guide. Underscores rule!
/🆑
2025-11-27 15:50:23 -05:00

104 lines
4.0 KiB
Plaintext
Raw Permalink Blame History

/datum/element/spooky
element_flags = ELEMENT_BESPOKE
argument_hash_start_idx = 2
///will it spawn a new instrument
var/too_spooky = TRUE
///If, once someone is skeletonized, the element is detached
var/single_use = FALSE
///The base multiplier of stamina damage applied by the item
var/stam_damage_mult
/datum/element/spooky/Attach(datum/target, too_spooky = TRUE, single_use = FALSE, stam_damage_mult = 1)
. = ..()
if(!isitem(target))
return ELEMENT_INCOMPATIBLE
src.too_spooky = too_spooky
src.single_use = single_use
src.stam_damage_mult = stam_damage_mult
RegisterSignal(target, COMSIG_ITEM_ATTACK, PROC_REF(spectral_attack))
/datum/element/spooky/Detach(datum/source)
UnregisterSignal(source, COMSIG_ITEM_ATTACK)
return ..()
/datum/element/spooky/proc/spectral_attack(datum/source, mob/living/carbon/target, mob/user)
SIGNAL_HANDLER
if(ishuman(user) && !isskeleton(user)) //this weapon wasn't meant for mortals.
var/mob/living/carbon/human/human_user = user
if(rattle_bones(human_user, stam_dam_mult = stam_damage_mult * 2))
to_chat(human_user, span_userdanger("Your ears weren't meant for this spectral sound."))
INVOKE_ASYNC(src, PROC_REF(spectral_change), human_user, user, source)
return
to_chat(target, span_userdanger("<b>DOOT</b"))
if(isskeleton(target)) // skeletons are totally immune, no redundant skeletonization or bad mood event.
return
target.add_mood_event("spooked", /datum/mood_event/spooked)
if(!ishuman(target))//the sound will spook basic mobs.
target.set_jitter_if_lower(30 SECONDS)
target.set_stutter(40 SECONDS)
return
var/mob/living/carbon/human/human = target
if(rattle_bones(human))
INVOKE_ASYNC(src, PROC_REF(spectral_change), human, user, source)
///Cause jitteriness and stamina to the target relative to the amount of their bodyparts made of flesh and bone.
/datum/element/spooky/proc/rattle_bones(mob/living/carbon/human/human, stam_dam_mult = stam_damage_mult)
if(isskeleton(human))
return FALSE //undeads are unaffected by the spook-pocalypse.
var/bone_amount = 0
for(var/obj/item/bodypart/part as anything in human.bodyparts)
if((part.biological_state & BIO_FLESH_BONE) == BIO_FLESH_BONE)
bone_amount++
if(bone_amount)
human.set_jitter_if_lower(12 SECONDS * bone_amount)
human.set_stutter(6.5 SECONDS * bone_amount)
human.adjust_stamina_loss(3 * bone_amount * stam_dam_mult)
if(iszombie(human))
human.adjust_stamina_loss(25)
human.Paralyze(15) //zombies can't resist the doot
return bone_amount
/datum/element/spooky/proc/spectral_change(mob/living/carbon/human/human, mob/living/user, obj/item/source)
if(human.get_stamina_loss() <= 95)
return
if(single_use)
to_chat(user, span_warning("You feel like [source] has lost its spookiness..."))
Detach(source)
human.Paralyze(2 SECONDS)
human.set_species(/datum/species/skeleton)
human.visible_message(span_warning("[human] has given up on life as a mortal."))
to_chat(human, span_boldnotice("You are a spooky skeleton!"))
to_chat(human,
span_boldnotice("A new life and identity has begun.\
[too_spooky ? "Help your fellow skeletons into bringing out the spooky-pocalypse." : ""] \
You haven't forgotten your past life, and are still beholden to past loyalties.")
)
INVOKE_ASYNC(src, PROC_REF(change_name), human) //time for a new name!
if(!too_spooky)
return
var/turf/turf = get_turf(human)
if(!prob(90))
to_chat(human, span_boldwarning("The spooky gods forgot to ship your instrument. Better luck next unlife."))
return
var/obj/item/instrument = pick(
/obj/item/instrument/saxophone/spectral,
/obj/item/instrument/trumpet/spectral,
/obj/item/instrument/trombone/spectral,
)
new instrument(turf)
/datum/element/spooky/proc/change_name(mob/living/carbon/human/spooked)
var/skeleton_name = spooked.client ? sanitize_name(tgui_input_text(spooked, "Enter your new skeleton name", "Spookifier", spooked.real_name, MAX_NAME_LEN)) : null
if(!skeleton_name)
skeleton_name = "\improper spooky skeleton"
spooked.fully_replace_character_name(null, skeleton_name)
Reference in New Issue View Git Blame Copy Permalink