mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-08-24 13:38:41 +01:00
## About The Pull Request It's just a partial cleanup of anti-[STYLE](https://github.com/tgstation/tgstation/blob/master/.github/guides/STYLE.md) code from /tg/'s ancient history. I compiled & tested with my helpful assistant and damage is still working. <img width="1920" height="1040" alt="image" src="https://github.com/user-attachments/assets/26dabc17-088f-4008-b299-3ff4c27142c3" /> I'll upload the .cs script I used to do it shortly. ## Why It's Good For The Game Just minor code cleanup. Script used is located at https://metek.tech/camelTo-Snake.7z EDIT 11/23/25: Updated the script to use multithreading and sequential scan so it works a hell of a lot faster ``` /* // Copyright 2025 Joshua 'Joan Metekillot' Kidder This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with this program. If not, see <https://www.gnu.org/licenses/>. // */ using System.Text.RegularExpressions; class Program { static async Task Main(string[] args) { var readFile = new FileStreamOptions { Access = FileAccess.Read, Share = FileShare.ReadWrite, Options = FileOptions.Asynchronous | FileOptions.SequentialScan }; FileStreamOptions writeFile = new FileStreamOptions { Share = FileShare.ReadWrite, Access = FileAccess.ReadWrite, Mode = FileMode.Truncate, Options = FileOptions.Asynchronous }; RegexOptions regexOptions = RegexOptions.Multiline | RegexOptions.Compiled; Dictionary<string, int> changedProcs = new(); string regexPattern = @"(?<=\P{L})([a-z]+)([A-Z]{1,2}[a-z]+)*(Brute|Burn|Fire|Tox|Oxy|Organ|Stamina)(Loss)([A-Z]{1,2}[a-z]+)*"; Regex camelCaseProcRegex = new(regexPattern, regexOptions); string snakeify(Match matchingRegex) { var vals = matchingRegex.Groups.Cast<Group>().SelectMany(_ => _.Captures).Select(_ => _.Value).ToArray(); var newVal = string.Join("_", vals.Skip(1).ToArray()).ToLower(); string logString = $"{vals[0]} => {newVal}"; if (changedProcs.TryGetValue(logString, out int value)) { changedProcs[logString] = value + 1; } else { changedProcs.Add(logString, 1); } return newVal; } var dmFiles = Directory.EnumerateFiles(".", "*.dm", SearchOption.AllDirectories).ToAsyncEnumerable<string>(); // uses default ParallelOptions // https://learn.microsoft.com/en-us/dotnet/api/system.threading.tasks.paralleloptions?view=net-10.0#main await Parallel.ForEachAsync(dmFiles, async (filePath, UnusedCancellationToken) => { var reader = new StreamReader(filePath, readFile); string oldContent = await reader.ReadToEndAsync(); string newContent = camelCaseProcRegex.Replace(oldContent, new MatchEvaluator((Func<Match, string>)snakeify)); if (oldContent != newContent) { var writer = new StreamWriter(filePath, writeFile); await writer.WriteAsync(newContent); await writer.DisposeAsync(); } reader.Dispose(); }); var logToList = changedProcs.Cast<KeyValuePair<string, int>>().ToList(); foreach (var pair in logToList) { Console.WriteLine($"{pair.Key}: {pair.Value} locations"); } } } ``` ## Changelog 🆑 Bisar code: All (Brute|Burn|Fire|Tox|Oxy|Organ|Stamina)(Loss) procs now use snake_case, in-line with the STYLE guide. Underscores rule! /🆑
67 lines
2.5 KiB
Plaintext
67 lines
2.5 KiB
Plaintext
#define GORILLA_MUTATION_CHANCE_PER_SECOND 0.25
|
|
#define GORILLA_MUTATION_MINIMUM_DAMAGE 2500
|
|
|
|
/datum/status_effect/genetic_damage
|
|
id = "genetic_damage"
|
|
alert_type = null
|
|
status_type = STATUS_EFFECT_REFRESH // New effects will add to total_damage
|
|
duration = STATUS_EFFECT_PERMANENT
|
|
tick_interval = 2 SECONDS
|
|
on_remove_on_mob_delete = TRUE // Need to unregister from owner, be_replaced() would cause runtimes
|
|
remove_on_fullheal = TRUE
|
|
/// The total genetic damage accumulated on the mob
|
|
var/total_damage = 0
|
|
/// The amount of genetic damage a mob can sustain before taking toxin damage
|
|
var/minimum_before_tox_damage = 500
|
|
/// The amount of genetic damage to remove per second
|
|
var/remove_per_second = 1 / 3
|
|
/// The amount of toxin damage to deal per second, if over the minimum before taking damage
|
|
var/toxin_damage_per_second = 1 / 3
|
|
|
|
/datum/status_effect/genetic_damage/on_creation(mob/living/new_owner, total_damage)
|
|
. = ..()
|
|
src.total_damage = total_damage
|
|
RegisterSignal(new_owner, COMSIG_LIVING_HEALTHSCAN, PROC_REF(on_healthscan))
|
|
|
|
/datum/status_effect/genetic_damage/on_remove()
|
|
. = ..()
|
|
UnregisterSignal(owner, COMSIG_LIVING_HEALTHSCAN)
|
|
|
|
/datum/status_effect/genetic_damage/refresh(mob/living/owner, total_damage)
|
|
. = ..()
|
|
src.total_damage += total_damage
|
|
|
|
/datum/status_effect/genetic_damage/tick(seconds_between_ticks)
|
|
if(ismonkey(owner) && total_damage >= GORILLA_MUTATION_MINIMUM_DAMAGE && SPT_PROB(GORILLA_MUTATION_CHANCE_PER_SECOND, seconds_between_ticks))
|
|
var/mob/living/carbon/carbon_owner = owner
|
|
carbon_owner.gorillize(genetics_gorilla = TRUE)
|
|
qdel(src)
|
|
return
|
|
|
|
if(total_damage >= minimum_before_tox_damage)
|
|
owner.adjust_tox_loss(toxin_damage_per_second * seconds_between_ticks)
|
|
|
|
total_damage -= remove_per_second * seconds_between_ticks
|
|
if(total_damage <= 0)
|
|
qdel(src)
|
|
return
|
|
|
|
/datum/status_effect/genetic_damage/proc/on_healthscan(datum/source, list/render_list, advanced, mob/user, mode, tochat)
|
|
SIGNAL_HANDLER
|
|
|
|
var/message = ""
|
|
if(advanced)
|
|
message = "Genetic damage: [round(total_damage / minimum_before_tox_damage * 100, 0.1)]%"
|
|
else if(total_damage >= minimum_before_tox_damage)
|
|
message = "Severe genetic damage detected."
|
|
else
|
|
message = "Minor genetic damage detected."
|
|
|
|
if(message)
|
|
render_list += "<span class='alert ml-1'>"
|
|
render_list += conditional_tooltip("[message]", "Irreparable under normal circumstances - will decay over time.", tochat)
|
|
render_list += "</span><br>"
|
|
|
|
#undef GORILLA_MUTATION_CHANCE_PER_SECOND
|
|
#undef GORILLA_MUTATION_MINIMUM_DAMAGE
|