mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-08-23 05:00:55 +01:00
## About The Pull Request It's just a partial cleanup of anti-[STYLE](https://github.com/tgstation/tgstation/blob/master/.github/guides/STYLE.md) code from /tg/'s ancient history. I compiled & tested with my helpful assistant and damage is still working. <img width="1920" height="1040" alt="image" src="https://github.com/user-attachments/assets/26dabc17-088f-4008-b299-3ff4c27142c3" /> I'll upload the .cs script I used to do it shortly. ## Why It's Good For The Game Just minor code cleanup. Script used is located at https://metek.tech/camelTo-Snake.7z EDIT 11/23/25: Updated the script to use multithreading and sequential scan so it works a hell of a lot faster ``` /* // Copyright 2025 Joshua 'Joan Metekillot' Kidder This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with this program. If not, see <https://www.gnu.org/licenses/>. // */ using System.Text.RegularExpressions; class Program { static async Task Main(string[] args) { var readFile = new FileStreamOptions { Access = FileAccess.Read, Share = FileShare.ReadWrite, Options = FileOptions.Asynchronous | FileOptions.SequentialScan }; FileStreamOptions writeFile = new FileStreamOptions { Share = FileShare.ReadWrite, Access = FileAccess.ReadWrite, Mode = FileMode.Truncate, Options = FileOptions.Asynchronous }; RegexOptions regexOptions = RegexOptions.Multiline | RegexOptions.Compiled; Dictionary<string, int> changedProcs = new(); string regexPattern = @"(?<=\P{L})([a-z]+)([A-Z]{1,2}[a-z]+)*(Brute|Burn|Fire|Tox|Oxy|Organ|Stamina)(Loss)([A-Z]{1,2}[a-z]+)*"; Regex camelCaseProcRegex = new(regexPattern, regexOptions); string snakeify(Match matchingRegex) { var vals = matchingRegex.Groups.Cast<Group>().SelectMany(_ => _.Captures).Select(_ => _.Value).ToArray(); var newVal = string.Join("_", vals.Skip(1).ToArray()).ToLower(); string logString = $"{vals[0]} => {newVal}"; if (changedProcs.TryGetValue(logString, out int value)) { changedProcs[logString] = value + 1; } else { changedProcs.Add(logString, 1); } return newVal; } var dmFiles = Directory.EnumerateFiles(".", "*.dm", SearchOption.AllDirectories).ToAsyncEnumerable<string>(); // uses default ParallelOptions // https://learn.microsoft.com/en-us/dotnet/api/system.threading.tasks.paralleloptions?view=net-10.0#main await Parallel.ForEachAsync(dmFiles, async (filePath, UnusedCancellationToken) => { var reader = new StreamReader(filePath, readFile); string oldContent = await reader.ReadToEndAsync(); string newContent = camelCaseProcRegex.Replace(oldContent, new MatchEvaluator((Func<Match, string>)snakeify)); if (oldContent != newContent) { var writer = new StreamWriter(filePath, writeFile); await writer.WriteAsync(newContent); await writer.DisposeAsync(); } reader.Dispose(); }); var logToList = changedProcs.Cast<KeyValuePair<string, int>>().ToList(); foreach (var pair in logToList) { Console.WriteLine($"{pair.Key}: {pair.Value} locations"); } } } ``` ## Changelog 🆑 Bisar code: All (Brute|Burn|Fire|Tox|Oxy|Organ|Stamina)(Loss) procs now use snake_case, in-line with the STYLE guide. Underscores rule! /🆑
126 lines
4.4 KiB
Plaintext
126 lines
4.4 KiB
Plaintext
// Effects given by the spacer quirk
|
|
|
|
/datum/status_effect/spacer
|
|
id = "spacer_gravity_effects"
|
|
status_type = STATUS_EFFECT_REPLACE
|
|
alert_type = null
|
|
/// Essentially, tracks whether this is a planetary map.
|
|
/// It'd be pretty miserable if you're playing a planetary map and getting the worse of all effects, so we handwave it a bit.
|
|
VAR_FINAL/nerfed_effects_because_planetary = FALSE
|
|
|
|
/datum/status_effect/spacer/on_apply()
|
|
return iscarbon(owner)
|
|
|
|
/datum/status_effect/spacer/on_creation(mob/living/new_owner, ...)
|
|
. = ..()
|
|
nerfed_effects_because_planetary = SSmapping.is_planetary()
|
|
|
|
// The good side (being in space)
|
|
/datum/status_effect/spacer/gravity_wellness
|
|
alert_type = null
|
|
tick_interval = 3 SECONDS
|
|
/// How much disgust to heal per tick
|
|
var/disgust_healing_per_tick = 1.5
|
|
/// How much of stamina damage to heal per tick when we've been in nograv for a while
|
|
var/stamina_heal_per_tick = 3
|
|
/// How many seconds of stuns to reduce per tick when we've been in nograv for a while
|
|
var/stun_heal_per_tick = 3 SECONDS
|
|
/// Tracks how long we've been in no gravity
|
|
VAR_FINAL/seconds_in_nograv = 0 SECONDS
|
|
|
|
/datum/status_effect/spacer/gravity_wellness/tick(seconds_between_ticks)
|
|
var/in_nograv = !owner.has_gravity()
|
|
var/nograv_mod = in_nograv ? 1 : 0.5
|
|
owner.adjust_disgust(-1 * disgust_healing_per_tick * nograv_mod)
|
|
|
|
if(!in_nograv)
|
|
seconds_in_nograv = 0 SECONDS
|
|
return
|
|
|
|
seconds_in_nograv += (seconds_between_ticks * 0.1)
|
|
|
|
if(seconds_in_nograv >= 3 MINUTES)
|
|
// This has some interesting side effects with gravitum or similar negating effects that may be worth nothing
|
|
owner.adjust_stamina_loss(-1 * stamina_heal_per_tick)
|
|
owner.AdjustAllImmobility(-1 * stun_heal_per_tick)
|
|
// For comparison: Ephedrine heals 4 stamina per tick / 2 per second
|
|
// and Nicotine heals 5 seconds of stun per tick / 2.5 per second
|
|
|
|
// The bad side (being on a planet)
|
|
/datum/status_effect/spacer/gravity_sickness
|
|
alert_type = /atom/movable/screen/alert/status_effect/gravity_sickness
|
|
tick_interval = 1 SECONDS
|
|
/// How much disgust to gain per tick
|
|
var/disgust_per_tick = 1
|
|
/// The cap to which we can apply disgust
|
|
var/max_disgust = DISGUST_LEVEL_GROSS + 5
|
|
/// Tracks how many seconds this has been active
|
|
VAR_FINAL/seconds_active = 0 SECONDS
|
|
|
|
/datum/status_effect/spacer/gravity_sickness/tick(seconds_between_ticks)
|
|
if(owner.mob_negates_gravity())
|
|
// Might seem redundant but we can totally be on a planet but have an anti-gravity effect like gravitum
|
|
return
|
|
|
|
seconds_active += (seconds_between_ticks * 0.1)
|
|
|
|
var/mob/living/carbon/the_spacer = owner
|
|
the_spacer.adjust_disgust(disgust_per_tick, max = max_disgust + 5)
|
|
|
|
if(nerfed_effects_because_planetary)
|
|
return
|
|
if(seconds_active < 2 MINUTES)
|
|
return
|
|
|
|
var/minutes_active = round(seconds_active / (1 MINUTES))
|
|
// Sit at a passive amount of stamina damage depending on how long it's been
|
|
if(!the_spacer.get_stamina_loss())
|
|
the_spacer.adjust_stamina_loss(min(25, 5 * minutes_active))
|
|
// Max disgust increases over time as well
|
|
max_disgust = min(DISGUST_LEVEL_VERYGROSS + 5, initial(max_disgust) + 5 * minutes_active)
|
|
// And your lungs can't really handle it good
|
|
if(!the_spacer.internal && seconds_active % 10 == 0)
|
|
the_spacer.losebreath = min(the_spacer.losebreath++, minutes_active, 8)
|
|
|
|
/atom/movable/screen/alert/status_effect/gravity_sickness
|
|
name = "Gravity Sickness"
|
|
desc = "The gravity of the planet around you is making you feel sick and tired."
|
|
use_user_hud_icon = TRUE
|
|
overlay_state = "paralysis"
|
|
|
|
/datum/mood_event/spacer
|
|
|
|
/datum/mood_event/spacer/in_space
|
|
description = "Space is long and dark and empty, but it's my home."
|
|
|
|
/datum/mood_event/spacer/on_planet
|
|
description = "I'm on a planet. The gravity here makes me uncomfortable."
|
|
mood_change = -2
|
|
|
|
/datum/mood_event/spacer/on_planet/too_long
|
|
description = "I've been on this planet for too long. I need to get back to space."
|
|
mood_change = -4
|
|
|
|
/datum/mood_event/spacer/on_planet/nerfed
|
|
description = "I'm stationed on a planet. I'd love to be back in space."
|
|
mood_change = -3
|
|
|
|
/datum/movespeed_modifier/spacer
|
|
id = "spacer"
|
|
|
|
/datum/movespeed_modifier/spacer/in_space
|
|
movetypes = FLOATING
|
|
blacklisted_movetypes = FLYING
|
|
multiplicative_slowdown = -0.1
|
|
|
|
/datum/movespeed_modifier/spacer/on_planet
|
|
movetypes = GROUND|FLYING
|
|
blacklisted_movetypes = FLOATING
|
|
multiplicative_slowdown = 0.2
|
|
|
|
/datum/movespeed_modifier/spacer/on_planet/too_long
|
|
multiplicative_slowdown = 0.5
|
|
|
|
/datum/movespeed_modifier/spacer/on_planet/nerfed
|
|
multiplicative_slowdown = 0.25
|