Files
GhomandGitHub 0b0c5ea91e Unit test material checks are now performed on all crafting recipes by default. All stack recipes now transfer mats to the results (#92620)
## About The Pull Request
Extends the part of the crafting unit test that ensures consistency
between the total mats of the components of a recipe (or rather, the
result of said recipe) and a generic instance of the same type as its
result, previously only implemented on food recipes.

## Why It's Good For The Game
This ensures a degree of consistency with the material composition of
various objects in the game. I couldn't do it in the original PR as that
one was too big already and it took months to get it merged, and have
the relative bugs fixed.

Currently a WIP as I slowly deal with the unit test reports.

## Changelog

🆑
refactor: Follow-up to the crafting/material refactor from months ago.
All objects crafted with stacks now inherit their mat composition (not
necessarily the effects and color) by default, while previously only a
few things like chair, sinks and toilets did. Report any object looking
or behaving weirdly as a result.
fix: The material composition of ammo boxes is no longer a 1/10 of what
it's supposed to be. It was a shitty hack to make it harder to recycle
empty ammo boxes. Instead, they lose materials as they're emptied now.
/🆑
2025-12-02 18:29:01 -05:00

159 lines
5.5 KiB
Plaintext

/**
* ## VIM!!!!!!!
*
* It's a teenie miniature mecha... for critters!
* For the critters that cannot be understood, there is a sound creator in the mecha. It also has headlights.
*/
/obj/vehicle/sealed/car/vim
name = "\improper Vim"
desc = "A miniature exosuit from Nanotrasen, developed to let the irreplaceable station pets live a little longer."
icon_state = "vim"
max_integrity = 50
armor_type = /datum/armor/car_vim
enter_delay = 20
movedelay = 0.6
engine_sound_length = 0.3 SECONDS
light_system = OVERLAY_LIGHT_DIRECTIONAL
light_range = 4
light_power = 1.5
light_on = FALSE
engine_sound = 'sound/effects/servostep.ogg'
interaction_flags_mouse_drop = NONE
custom_materials = list(/datum/material/iron = SHEET_MATERIAL_AMOUNT * 0.55, /datum/material/glass = SMALL_MATERIAL_AMOUNT * 0.7)
///Maximum size of a mob trying to enter the mech
var/maximum_mob_size = MOB_SIZE_SMALL
COOLDOWN_DECLARE(sound_cooldown)
/datum/armor/car_vim
melee = 70
bullet = 40
laser = 40
bomb = 30
fire = 80
acid = 80
/obj/vehicle/sealed/car/vim/Initialize(mapload)
. = ..()
AddComponent( \
/datum/component/shell, \
unremovable_circuit_components = list(new /obj/item/circuit_component/vim), \
capacity = SHELL_CAPACITY_SMALL, \
)
/obj/vehicle/sealed/car/vim/examine(mob/user)
. = ..()
. += span_notice("[src] can be repaired with a welder.")
/obj/vehicle/sealed/car/vim/atom_destruction(damage_flag)
new /obj/effect/decal/cleanable/blood/oil(get_turf(src))
do_sparks(5, TRUE, src)
visible_message(span_bolddanger("[src] blows apart!"))
return ..()
/obj/vehicle/sealed/car/vim/mob_try_enter(mob/entering)
if(!isanimal_or_basicmob(entering))
return FALSE
var/mob/living/animal_or_basic = entering
if(animal_or_basic.mob_size > maximum_mob_size)
entering.balloon_alert(entering, "can't fit inside!")
return FALSE
return ..()
/obj/vehicle/sealed/car/vim/welder_act(mob/living/user, obj/item/W)
if(user.combat_mode)
return
. = TRUE
if(DOING_INTERACTION(user, src))
balloon_alert(user, "you're already repairing it!")
return
if(atom_integrity >= max_integrity)
balloon_alert(user, "it's not damaged!")
return
if(!W.tool_start_check(user, amount=1, heat_required = HIGH_TEMPERATURE_REQUIRED))
return
user.balloon_alert_to_viewers("started welding [src]", "started repairing [src]")
audible_message(span_hear("You hear welding."))
var/did_the_thing
while(atom_integrity < max_integrity)
if(W.use_tool(src, user, 2.5 SECONDS, volume=50))
did_the_thing = TRUE
atom_integrity += min(VIM_HEAL_AMOUNT, (max_integrity - atom_integrity))
audible_message(span_hear("You hear welding."))
else
break
if(did_the_thing)
user.balloon_alert_to_viewers("[(atom_integrity >= max_integrity) ? "fully" : "partially"] repaired [src]")
else
user.balloon_alert_to_viewers("stopped welding [src]", "interrupted the repair!")
/obj/vehicle/sealed/car/vim/mob_enter(mob/newoccupant, silent = FALSE)
. = ..()
update_appearance()
playsound(src, 'sound/machines/windowdoor.ogg', 50, TRUE)
if(atom_integrity == max_integrity)
SEND_SOUND(newoccupant, sound('sound/vehicles/mecha/nominal.ogg',volume=50))
/obj/vehicle/sealed/car/vim/mob_try_exit(mob/pilot, mob/user, silent = FALSE, randomstep = FALSE)
. = ..()
update_appearance()
/obj/vehicle/sealed/car/vim/generate_actions()
initialize_controller_action_type(/datum/action/vehicle/sealed/climb_out/vim, VEHICLE_CONTROL_DRIVE)
initialize_controller_action_type(/datum/action/vehicle/sealed/noise/chime, VEHICLE_CONTROL_DRIVE)
initialize_controller_action_type(/datum/action/vehicle/sealed/noise/buzz, VEHICLE_CONTROL_DRIVE)
initialize_controller_action_type(/datum/action/vehicle/sealed/headlights/vim, VEHICLE_CONTROL_DRIVE)
/obj/vehicle/sealed/car/vim/update_overlays()
. = ..()
var/static/piloted_overlay
var/static/headlights_overlay
if(isnull(piloted_overlay))
piloted_overlay = iconstate2appearance(icon, "vim_piloted")
headlights_overlay = iconstate2appearance(icon, "vim_headlights")
var/list/drivers = return_drivers()
if(drivers.len)
. += piloted_overlay
if(headlights_toggle)
. += headlights_overlay
/obj/item/circuit_component/vim
display_name = "Vim"
desc = "A miniature exosuit from Nanotrasen, developed to let the irreplaceable station pets live a little longer."
/// Sent when the mech chimes.
var/datum/port/output/chime
/// Sent when the mech buzzes.
var/datum/port/output/buzz
/// Whether the mech headlights are currently on.
var/datum/port/output/are_headlights_on
/obj/item/circuit_component/vim/populate_ports()
are_headlights_on = add_output_port("Are Headlights On", PORT_TYPE_NUMBER)
chime = add_output_port("On Chime Used", PORT_TYPE_SIGNAL)
buzz = add_output_port("On Buzz Used", PORT_TYPE_SIGNAL)
/obj/item/circuit_component/vim/register_shell(atom/movable/shell)
. = ..()
RegisterSignal(shell, COMSIG_VIM_HEADLIGHTS_TOGGLED, PROC_REF(on_headlights_toggle))
RegisterSignal(shell, COMSIG_VIM_CHIME_USED, PROC_REF(on_chime_used))
RegisterSignal(shell, COMSIG_VIM_BUZZ_USED, PROC_REF(on_buzz_used))
/obj/item/circuit_component/vim/unregister_shell(atom/movable/shell)
. = ..()
UnregisterSignal(shell, COMSIG_VIM_HEADLIGHTS_TOGGLED)
UnregisterSignal(shell, COMSIG_VIM_CHIME_USED)
UnregisterSignal(shell, COMSIG_VIM_BUZZ_USED)
/obj/item/circuit_component/vim/proc/on_headlights_toggle(datum/source, headlights_on)
SIGNAL_HANDLER
are_headlights_on.set_output(headlights_on)
/obj/item/circuit_component/vim/proc/on_chime_used()
SIGNAL_HANDLER
chime.set_output(COMPONENT_SIGNAL)
/obj/item/circuit_component/vim/proc/on_buzz_used()
SIGNAL_HANDLER
buzz.set_output(COMPONENT_SIGNAL)