mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-08-30 08:37:43 +01:00
2e98eef84b
## About The Pull Request Properly marks BA, NT Rep, and Blueshield as members of command within the job flags. (when other parts of the code already consider them as 'command', e.g. the biscuit handout) ## Why It's Good For The Game Resolves issue: https://github.com/Bubberstation/Bubberstation/issues/5070 ## Proof Of Testing <!-- Compile and run your code locally. Make sure it works. This is the place to show off your changes! We are not responsible for testing your features. --> <details> <summary>Screenshots/Videos</summary> <img width="712" height="325" alt="image" src="https://github.com/user-attachments/assets/8db7a5e6-96cd-49ee-8e42-426082a8f1ea" /> ^ The manifest after the RD has cryo'd (Note lack of RD, which is triggering the variable in the next screenshot), note that the count is important here. <img width="380" height="263" alt="image" src="https://github.com/user-attachments/assets/e5157ce4-5b31-4ae9-a5a0-75e252232c31" /> ^ The command member count, as the RD is entering cryo. Note: Before this fix, the count for this exact setup was `8` as it was not counting the BA, NT Rep, and Blueshield. This means that now on lowpop shifts where a BA would sign up, then a member of command joining and then BA cryo'ing will now have the proper count and will not fire off a 'last member of command has cryo'd message' </details> ## Changelog 🆑 fix: Fix last member of command has cryo'd announcement when there are still member's of command on board. /🆑 --------- Co-authored-by: LT3 <83487515+lessthnthree@users.noreply.github.com>
https://github.com/Skyrat-SS13/Skyrat-tg/pull/127
Title: Blueshield
MODULE ID: BLUESHIELD
Description:
Adds the blueshield job to the game. It does not however add the blueshield office to the map. This includes all the blueshields items and job descriptors.
TG Proc Changes:
- code/modules/jobs/jobs.dm > GLOBAL_LIST_INIT(security_positions, list()
- code/modules/jobs/access.dm > /proc/get_all_accesses()
Defines:
- #define JOB_DISPLAY_ORDER_BLUESHIELD 34
- #define ACCESS_BLUESHIELD 71
Master file additions
- ./modular_skyrat/master_files/icons/mob/hud.dmi #NEW
- ./modular_skyrat/master_files/icons/clothing/hands.dmi #NEW
- ./modular_skyrat/master_files/icons/obj/clothing/gloves.dmi #NEW
Included files that are not contained in this module:
- N/A
Credits:
Gandalf2k15 - Porting