cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-23 13:10:02 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
ok-behavior-trees
Bubberstation/code/game/objects/items/rcd/RTD.dm
T
GhomandGitHub 6eb2d1674a Implementing materials checks for techweb designs. (#96257) 
## About The Pull Request
In similar fashion to what was done with crafting recipes last year,
this year it's time for techweb designs and printed items to be audited.
This is mostly just about consistency, we've a lot of items that can be
printed by protolathes, autolathes, circuit printers and techfab etc.
However they almost all (except most stacks, mainly) have custom
materials that do not match in one way or another with the materials
used by the design, which is what this PR is for.

"But items printed from lathes etc. already get the mats used to make
them." Yes, they do, however that isn't the case for items of the same
type that were spawned in some other way (cargo shuttle, space/maints
loot, mapped, admins), this create a subtle discrepancy. It isn't a huge
deal (in spite of the size of this PR, ton of designs), but given that I
have done something similar with crafting recipes before, I may as well
give it a second arc of some sort and bring things to completion. And
fix a few possible oversights.

TL;DR consistency and stuff

## Why It's Good For The Game
Consistency, unit test checks to make it harder not to be consistent in
the future. Still has a few TODOs like:

- [x] Fixed newly printed, fully charged RCDs costing less than the RCD
cartridges required to fully charge one. EDIT: I had to tweak the newly
added RDD as well because it suffered from the same fundamental issue.
- [x] Fixed plates being made of iron and yet shattering like ceramic
ones. A new subtype for metallic ones has been made.

## Changelog

🆑
refactor: Refactored a few things with techweb designs (the ones for
autolathes, protolathes, circuit printers, mechfabs etc.) to make sure
that the materials of items that can be made from these designs more
closely match the materials used to make them.
fix: Lizard fries no longer need a plate to be made, like all other
treats that used to require plates in a distant past.
balance: Tweaked the materials cost of RCD, RDD and RCD cartridges.
image: Oven trays now have a more metallic hue.
balance: Plates printed printed from lathes won't shatter like ceramic
ones, in virtue of them being made out of iron instead.
/🆑
2026-07-06 00:13:02 -07:00

440 lines
14 KiB
Plaintext
Raw Permalink Blame History

//RAPID TILING DEVICE
/// time taken to create tile
#define CONSTRUCTION_TIME(cost)((cost * 0.15) SECONDS)
/// time taken to destroy a tile
#define DECONSTRUCTION_TIME(cost)((cost * 0.25) SECONDS)
/**
* An tool used to create, destroy, and copy & clear decals of floor tiles
* Great for janitor but can be made only in engineering
* Supports silo link upgrade and refill with glass, plasteel & iron
*/
/obj/item/construction/rtd
name = "rapid-tiling-device (RTD)"
desc = "Used for fast placement & destruction of floor tiles."
icon = 'icons/obj/tools.dmi'
icon_state = "rtd"
worn_icon_state = "RCD"
lefthand_file = 'icons/mob/inhands/equipment/tools_lefthand.dmi'
righthand_file = 'icons/mob/inhands/equipment/tools_righthand.dmi'
custom_premium_price = PAYCHECK_COMMAND * 3
max_matter = 350
slot_flags = ITEM_SLOT_BELT
item_flags = NO_MAT_REDEMPTION | NOBLUDGEON
has_ammobar = TRUE
banned_upgrades = RCD_ALL_UPGRADES & ~RCD_UPGRADE_SILO_LINK
drop_sound = 'sound/items/handling/tools/rcd_drop.ogg'
pickup_sound = 'sound/items/handling/tools/rcd_pickup.ogg'
sound_vary = TRUE
custom_materials = list(/datum/material/iron = SHEET_MATERIAL_AMOUNT * 15, /datum/material/glass = SHEET_MATERIAL_AMOUNT * 1.25)
/// main category for tile design
var/root_category = "Conventional"
/// sub category for tile design
var/design_category = "Standard"
/// design selected by player
var/datum/tile_info/selected_design
/// direction currently selected
var/selected_direction = SOUTH
/// overlays on a tile
var/list/design_overlays = list()
var/ranged = TRUE
/// stores the name, type, icon & cost for each tile type
/datum/tile_info
/// name of this tile design for ui
var/name
/// path to create this tile type
var/obj/item/stack/tile/tile_type
/// path for the turf
var/turf/open/floor/turf_type
/// icon file used by the turf
var/icon_file
/// icon_state for this tile to display for ui
var/icon_state
/// rcd units to consume for this tile creation
var/cost
///directions this tile can be placed on the turf
var/list/tile_directions_text
var/list/tile_directions_numbers
/// CSS selector for the icon in TGUI
var/icon_css_class
/// decompress a single tile design list element from GLOB.floor_designs into its individual variables
/datum/tile_info/New(list/design)
name = design["name"]
tile_type = design["type"]
turf_type = initial(tile_type.turf_type)
icon_file = initial(turf_type.icon)
icon_state = initial(turf_type.icon_state)
icon_css_class = sanitize_css_class_name("[icon_file]-[icon_state]")
var/obj/item/stack/tile/tile_obj = new tile_type // lists stored on types compile to be inside New()
tile_directions_text = assoc_to_keys(tile_obj.tile_rotate_dirs)
tile_directions_numbers = tile_obj.tile_rotate_dirs_number
qdel(tile_obj)
cost = design["tile_cost"]
/// fill all information to be sent to the UI
/datum/tile_info/proc/fill_ui_data(list/data, selected_direction)
data["selected_recipe"] = name
data["selected_icon"] = icon_css_class
if(!tile_directions_text)
data["selected_direction"] = null
return
data["tile_dirs"] = tile_directions_text
data["selected_direction"] = dir2text(selected_direction)
///convinience proc to quickly convert the tile design into an physical tile to lay on the plating
/datum/tile_info/proc/new_tile(loc, selected_direction)
var/obj/item/stack/tile/final_tile = new tile_type(loc, 1)
final_tile.turf_dir = selected_direction
return final_tile
/**
* Stores the decal & overlays on the floor to preserve texture of the design
* in short it's just an wrapper for mutable appearance where we retrieve the nessassary information
* to recreate an mutable appearance
*/
/datum/overlay_info
/// icon var of the mutable appearance
var/icon/icon
/// icon_state var of the mutable appearance
var/icon_state
/// direction var of the mutable appearance
var/direction
/// alpha var of the mutable appearance
var/alpha
/// color var of the mutable appearance
var/color
//decompressing nessasary information required to re-create an mutable appearance
/datum/overlay_info/New(mutable_appearance/appearance)
icon = appearance.icon
icon_state = appearance.icon_state
alpha = appearance.alpha
direction = appearance.dir
color = appearance.color
/// re create the appearance
/datum/overlay_info/proc/add_decal(turf/the_turf)
the_turf.AddElement(/datum/element/decal, icon, icon_state, direction, null, null, alpha, color, null, FALSE, null)
/obj/item/construction/rtd/Initialize(mapload)
. = ..()
var/list/design = GLOB.floor_designs[root_category][design_category][1]
if(!design["datum"])
populate_rtd_datums()
selected_design = design["datum"]
/obj/item/construction/rtd/Destroy()
selected_design = null
QDEL_LIST(design_overlays)
return ..()
/obj/item/construction/rtd/ui_interact(mob/user, datum/tgui/ui)
ui = SStgui.try_update_ui(user, src, ui)
if(!ui)
ui = new(user, src, "RapidTilingDevice", name)
ui.open()
/obj/item/construction/rtd/ui_assets(mob/user)
return list(
get_asset_datum(/datum/asset/spritesheet_batched/rtd),
)
/obj/item/construction/rtd/attack_self(mob/user)
. = ..()
ui_interact(user)
/obj/item/construction/rtd/ui_static_data(mob/user)
var/list/data = ..()
data["root_categories"] = list()
for(var/category in GLOB.floor_designs)
data["root_categories"] += category
data["selected_root"] = root_category
data["categories"] = list()
for(var/sub_category in GLOB.floor_designs[root_category])
var/list/target_category = GLOB.floor_designs[root_category][sub_category]
var/list/designs = list() //initialize all designs under this category
for(var/list/design as anything in target_category)
var/datum/tile_info/tile_design = design["datum"]
if(!istype(tile_design))
populate_rtd_datums()
tile_design = design["datum"]
designs += list(list("name" = tile_design.name, "icon" = tile_design.icon_css_class))
data["categories"] += list(list("category_name" = sub_category, "recipes" = designs))
return data
/obj/item/construction/rtd/ui_data(mob/user)
var/list/data = ..()
data["selected_category"] = design_category
selected_design.fill_ui_data(data, selected_direction)
return data
/obj/item/construction/rtd/handle_ui_act(action, params, datum/tgui/ui, datum/ui_state/state)
playsound(src, SFX_TOOL_SWITCH, 20, TRUE)
var/floor_designs = GLOB.floor_designs
switch(action)
if("root_category")
var/new_root = params["root_category"]
if(floor_designs[new_root] != null) //is a valid category
root_category = new_root
update_static_data_for_all_viewers()
if("set_dir")
var/direction = text2dir(params["dir"])
if(!direction)
return FALSE
selected_direction = direction
if("recipe")
var/list/main_root = floor_designs[root_category]
if(main_root == null)
return FALSE
var/list/sub_category = main_root[params["category_name"]]
if(sub_category == null)
return FALSE
var/list/target_design = sub_category[text2num(params["id"])]
if(target_design == null)
return FALSE
QDEL_LIST(design_overlays)
design_category = params["category_name"]
if(!target_design["datum"])
populate_rtd_datums()
selected_design = target_design["datum"]
selected_direction = SOUTH
blueprint_changed = TRUE
return TRUE
/obj/item/construction/rtd/ranged_interact_with_atom(atom/interacting_with, mob/living/user, list/modifiers)
if(!ranged || !range_check(interacting_with, user))
return NONE
return try_tiling(interacting_with, user)
/obj/item/construction/rtd/interact_with_atom(atom/interacting_with, mob/living/user, list/modifiers)
. = ..()
if(. & ITEM_INTERACT_ANY_BLOCKER)
return .
return try_tiling(interacting_with, user)
/**
* put plating on the turf
* Arguments
*
* * turf/open/floor/floor - the turf we are trying to put plating on
* * mob/living/user - the mob trying to do the plating
*/
/obj/item/construction/rtd/proc/try_tiling(atom/interacting_with, mob/living/user)
PRIVATE_PROC(TRUE)
if(HAS_TRAIT(interacting_with, TRAIT_COMBAT_MODE_SKIP_INTERACTION))
return NONE
var/turf/open/floor/floor = interacting_with
if(!istype(floor))
return NONE
var/floor_designs = GLOB.floor_designs
if(!istype(floor, /turf/open/floor/plating)) //we infer what floor type it is if its not the usual plating
if(ranged)
user.Beam(floor, icon_state = "light_beam", time = 5)
for(var/main_root in floor_designs)
for(var/sub_category in floor_designs[main_root])
for(var/list/design_info in floor_designs[main_root][sub_category])
var/obj/item/stack/tile/tile_type = design_info["type"]
if(initial(tile_type.turf_type) != floor.type)
continue
//infer available overlays on the floor to recreate them to the best extent
QDEL_LIST(design_overlays)
var/floor_overlays = floor.managed_overlays
if(isnull(floor_overlays))
floor_overlays = list()
else if(!islist(floor_overlays))
floor_overlays = list(floor.managed_overlays)
for(var/mutable_appearance/appearance as anything in floor_overlays)
design_overlays += new /datum/overlay_info(appearance)
//store all information about this tile
root_category = main_root
design_category = sub_category
selected_design = design_info["datum"]
selected_direction = floor.dir
balloon_alert(user, "tile changed to [selected_design.name]")
return ITEM_INTERACT_SUCCESS
//can't infer floor type!
balloon_alert(user, "design not supported!")
return ITEM_INTERACT_BLOCKING
//resource sanity check before & after delay along with special effects
if(!useResource(selected_design.cost, user, TRUE))
return ITEM_INTERACT_BLOCKING
var/delay = CONSTRUCTION_TIME(selected_design.cost)
var/obj/effect/constructing_effect/rcd_effect = new(floor, delay, RCD_TURF)
var/beam
if(ranged)
beam = user.Beam(floor, icon_state = "light_beam", time = delay)
playsound(loc, 'sound/effects/light_flicker.ogg', 50, FALSE)
else
playsound(loc, 'sound/machines/click.ogg', 50, TRUE)
if(!build_delay(user, delay, target = floor))
qdel(beam)
qdel(rcd_effect)
return ITEM_INTERACT_BLOCKING
if(!useResource(selected_design.cost, user, TRUE))
qdel(rcd_effect)
return ITEM_INTERACT_BLOCKING
//do the tilling
//step 1 create tile
var/obj/item/stack/tile/final_tile = selected_design.new_tile(user.drop_location(), selected_direction)
if(QDELETED(final_tile)) //if you were standing on a stack of tiles this newly spawned tile could get merged with it cause its spawned on your location
qdel(rcd_effect)
balloon_alert(user, "tile got merged with the stack beneath you!")
return ITEM_INTERACT_BLOCKING
//step 2 lay tile
var/turf/open/new_turf = final_tile.place_tile(floor, user)
if(new_turf) //apply infered overlays
for(var/datum/overlay_info/info in design_overlays)
info.add_decal(new_turf)
rcd_effect.end_animation()
useResource(selected_design.cost, user)
return ITEM_INTERACT_SUCCESS
/obj/item/construction/rtd/ranged_interact_with_atom_secondary(atom/interacting_with, mob/living/user, list/modifiers)
if(!ranged || !range_check(interacting_with, user))
return NONE
return interact_with_atom_secondary(interacting_with, user, modifiers)
/obj/item/construction/rtd/interact_with_atom_secondary(atom/interacting_with, mob/living/user, list/modifiers)
var/turf/open/floor/floor = interacting_with
if(!istype(floor))
return NONE
if(istype(floor, /turf/open/floor/plating)) //cant deconstruct normal plating thats the RCD's job
balloon_alert(user, "nothing to deconstruct!")
return ITEM_INTERACT_BLOCKING
var/floor_designs = GLOB.floor_designs
//we only deconstruct floors which are supported by the RTD
var/cost = 0
for(var/main_root in floor_designs)
if(cost)
break
for(var/sub_category in floor_designs[main_root])
if(cost)
break
for(var/list/design_info in floor_designs[main_root][sub_category])
var/obj/item/stack/tile/tile_type = design_info["type"]
if(initial(tile_type.turf_type) == floor.type)
cost = design_info["tile_cost"]
break
if(!cost)
balloon_alert(user, "can't deconstruct this type!")
return ITEM_INTERACT_BLOCKING
//resource sanity check before & after delay along with beam effects
if(!useResource(cost * 0.7, user, TRUE)) //no ballon alert for checkResource as it already spans an alert to chat
return ITEM_INTERACT_BLOCKING
var/delay = DECONSTRUCTION_TIME(cost)
var/obj/effect/constructing_effect/rcd_effect = new(floor, delay, RCD_DECONSTRUCT)
var/beam
if(ranged)
beam = user.Beam(floor, icon_state = "light_beam", time = delay)
playsound(loc, 'sound/effects/light_flicker.ogg', 50, FALSE)
else
playsound(loc, 'sound/machines/click.ogg', 50, TRUE)
if(!do_after(user, delay, target = floor))
qdel(beam)
qdel(rcd_effect)
return ITEM_INTERACT_BLOCKING
if(!useResource(cost * 0.7, user, TRUE))
qdel(rcd_effect)
return ITEM_INTERACT_BLOCKING
//begin deconstruction
//find & collect all decals
var/list/all_decals = list()
for(var/obj/effect/decal in floor.contents)
all_decals += decal
//delete all decals
for(var/obj/effect/decal in all_decals)
floor.contents -= decal
qdel(decal)
if(floor.baseturf_at_depth(1) == /turf/baseturf_bottom) //for turfs whose base is open space we put regular plating in its place else everyone dies
floor.ChangeTurf(/turf/open/floor/plating, flags = CHANGETURF_INHERIT_AIR)
else //for every other turf we scrape away exposing base turf underneath
floor.ScrapeAway(flags = CHANGETURF_INHERIT_AIR)
rcd_effect.end_animation()
useResource(cost * 0.7, user)
return ITEM_INTERACT_SUCCESS
///Converting tile cost into joules
#define RTD_BORG_ENERGY_FACTOR (0.03 * STANDARD_CELL_CHARGE)
/obj/item/construction/rtd/borg
ranged = FALSE
///Cannot deconstruct floors
/obj/item/construction/rtd/borg/interact_with_atom_secondary(atom/interacting_with, mob/living/user, list/modifiers)
return NONE
/obj/item/construction/rtd/borg/get_matter(mob/user)
if(!iscyborg(user))
return 0
var/mob/living/silicon/robot/borgy = user
if(!borgy.cell)
return 0
max_matter = borgy.cell.maxcharge
return borgy.cell.charge
/obj/item/construction/rtd/borg/useResource(amount, mob/user, dry_run)
var/mob/living/silicon/robot/borgy = user
if(!iscyborg(borgy))
return FALSE
if(!borgy.cell)
balloon_alert(user, "no cell found!")
return FALSE
if(borgy.cell.charge < (amount * RTD_BORG_ENERGY_FACTOR))
balloon_alert(user, "insufficient charge!")
return FALSE
if(!dry_run)
playsound(loc, 'sound/items/deconstruct.ogg', 50, TRUE)
return borgy.cell.use(amount * RTD_BORG_ENERGY_FACTOR)
return TRUE
#undef RTD_BORG_ENERGY_FACTOR
/obj/item/construction/rtd/loaded
matter = 350
/obj/item/construction/rtd/admin
name = "admin RTD"
max_matter = INFINITY
matter = INFINITY
#undef CONSTRUCTION_TIME
#undef DECONSTRUCTION_TIME
Reference in New Issue View Git Blame Copy Permalink