mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-08-22 04:30:44 +01:00
Leland KembleandGitHub
06608081d2
## About The Pull Request 50 files, plus additonal file that was necessary because I slightly refactored windoor construction. This ended up like three and a half times larger than most of the other ones, I really wasn't meaning for that to happen. Maybe its because I more vigorously enforced the empty line after every return thing. The only way to find out is to read 1700 lines of changes, and I don't feel like doing that again. I pinky promise it all works, and I've tested every item changed individually. Changes beyond conversion: You can't welder down reinforced falsewalls anymore, pretty sure it was an oversight because they're supposed to be taken down by wirecutters You can right click to close gun lockers with an empty hand, because otherwise you can't close the lockers at all if there's a gun in them Meatspikes no longer runtime on construction due to the old trick of balloon alert + qdel Windoor assembly no longer SUCKS DICK!!, it's no longer storing essentially a boolean in an undocumented number in a string, it no longer requires a VERB to flip its direction. on a related note, the creator of the windoor assembly construction steps has been sent to live on a farm far out in the country Also, a quick note about how these prs are gonna fuck everything up until they're all together. There's a lot more places where `attackby()` is directly called than I would have assumed, and given as those are being changed to call `item_interaction()` potentially(usually) in a different pr than the pr in which that atom's `attackby()` is actually converted, that function's not going to work at all until both are merged. The good news is that almost every instance this is happening, it's pure convenience, where the user would have access to both items anyway and could just manually call the attack chain by clicking them together. Instances where this is not the case are being skipped over until they can be packaged together to avoid the issue, but I'm not bothering to do this on ones where the desync won't make an interaction actually unusable, because that would require me to turn a 1700 line pr into a 3500 line pr and I really was aiming for like 500 ## Why It's Good For The Game Ignore the paragraph about how I expect this to create a hostage situation where the only fix to the bugs I make is to merge my other prs, and instead think about how cool swing combat would be and how much you want it ## Changelog 🆑 fix: you now can only use a wirecutter to take down a reinforced falsewall fix: meatspikes no longer runtime on construction fix: you no longer have to use a verb that you can't use to flip windoor assemblies qol: you can right click a gun locker to close it code: 50 files have been moved from attackby() to item_interaction() /🆑
191 lines
4.9 KiB
Plaintext
191 lines
4.9 KiB
Plaintext
#define MAX_NOTICES 8
|
|
|
|
/obj/structure/noticeboard
|
|
name = "notice board"
|
|
desc = "A board for pinning important notices upon. It is made of the finest Spanish cork."
|
|
icon = 'icons/obj/wallmounts.dmi'
|
|
icon_state = "noticeboard"
|
|
density = FALSE
|
|
anchored = TRUE
|
|
max_integrity = 150
|
|
/// Current number of a pinned notices
|
|
var/notices = 0
|
|
|
|
MAPPING_DIRECTIONAL_HELPERS(/obj/structure/noticeboard, 32)
|
|
|
|
/obj/structure/noticeboard/on_object_saved()
|
|
var/data
|
|
|
|
for(var/obj/item/paper/paper in contents)
|
|
var/metadata = generate_tgm_metadata(paper)
|
|
data += "[data ? ",\n" : ""][paper.type][metadata]"
|
|
|
|
return data
|
|
|
|
/obj/structure/noticeboard/Initialize(mapload)
|
|
. = ..()
|
|
|
|
if(!mapload)
|
|
return
|
|
|
|
for(var/obj/item/paper/paper in loc)
|
|
if(notices >= MAX_NOTICES)
|
|
break
|
|
|
|
paper.forceMove(src)
|
|
notices++
|
|
update_appearance(UPDATE_ICON)
|
|
if(mapload)
|
|
find_and_mount_on_atom()
|
|
|
|
//attaching papers!!
|
|
/obj/structure/noticeboard/item_interaction(mob/living/user, obj/item/tool, list/modifiers)
|
|
if(!istype(tool, /obj/item/paper) && !istype(tool, /obj/item/photo))
|
|
return NONE
|
|
|
|
if(!allowed(user))
|
|
to_chat(user, span_warning("You are not authorized to add notices!"))
|
|
return ITEM_INTERACT_BLOCKING
|
|
|
|
if(notices >= MAX_NOTICES)
|
|
to_chat(user, span_warning("The notice board is full!"))
|
|
return ITEM_INTERACT_BLOCKING
|
|
|
|
if(!user.transferItemToLoc(tool, src))
|
|
return ITEM_INTERACT_BLOCKING
|
|
|
|
notices++
|
|
update_appearance(UPDATE_ICON)
|
|
to_chat(user, span_notice("You pin the [tool] to the noticeboard."))
|
|
return ITEM_INTERACT_SUCCESS
|
|
|
|
|
|
/obj/structure/noticeboard/ui_state(mob/user)
|
|
return GLOB.physical_state
|
|
|
|
/obj/structure/noticeboard/ui_interact(mob/user, datum/tgui/ui)
|
|
ui = SStgui.try_update_ui(user, src, ui)
|
|
if(!ui)
|
|
ui = new(user, src, "NoticeBoard", name)
|
|
ui.open()
|
|
|
|
/obj/structure/noticeboard/ui_data(mob/user)
|
|
var/list/data = list()
|
|
data["allowed"] = allowed(user)
|
|
data["items"] = list()
|
|
for(var/obj/item/content in contents)
|
|
var/list/content_data = list(
|
|
name = content.name,
|
|
ref = REF(content)
|
|
)
|
|
data["items"] += list(content_data)
|
|
return data
|
|
|
|
/obj/structure/noticeboard/ui_act(action, list/params, datum/tgui/ui, datum/ui_state/state)
|
|
. = ..()
|
|
if(.)
|
|
return
|
|
|
|
var/obj/item/item = locate(params["ref"]) in contents
|
|
if(!istype(item) || item.loc != src)
|
|
return
|
|
|
|
var/mob/user = usr
|
|
|
|
switch(action)
|
|
if("examine")
|
|
if(istype(item, /obj/item/paper))
|
|
item.ui_interact(user)
|
|
else
|
|
user.examinate(item)
|
|
return TRUE
|
|
if("remove")
|
|
if(!allowed(user))
|
|
return
|
|
remove_item(item, user)
|
|
return TRUE
|
|
|
|
/obj/structure/noticeboard/update_overlays()
|
|
. = ..()
|
|
if(notices)
|
|
. += "notices_[notices]"
|
|
|
|
/**
|
|
* Removes an item from the notice board
|
|
*
|
|
* Arguments:
|
|
* * item - The item that is to be removed
|
|
* * user - The mob that is trying to get the item removed, if there is one
|
|
*/
|
|
/obj/structure/noticeboard/proc/remove_item(obj/item/item, mob/user)
|
|
item.forceMove(drop_location())
|
|
if(user)
|
|
user.put_in_hands(item)
|
|
balloon_alert(user, "removed from board")
|
|
notices--
|
|
update_appearance(UPDATE_ICON)
|
|
|
|
/obj/structure/noticeboard/atom_deconstruct(disassembled = TRUE)
|
|
if(!disassembled)
|
|
new /obj/item/stack/sheet/mineral/wood(loc)
|
|
else
|
|
new /obj/item/wallframe/noticeboard(loc)
|
|
for(var/obj/item/content in contents)
|
|
remove_item(content)
|
|
|
|
/obj/item/wallframe/noticeboard
|
|
name = "notice board"
|
|
desc = "Right now it's more of a clipboard. Attach to a wall to use."
|
|
icon = 'icons/obj/wallmounts.dmi'
|
|
icon_state = "noticeboard"
|
|
custom_materials = list(
|
|
/datum/material/wood = SHEET_MATERIAL_AMOUNT,
|
|
)
|
|
resistance_flags = FLAMMABLE
|
|
result_path = /obj/structure/noticeboard
|
|
pixel_shift = 32
|
|
|
|
// Notice boards for the heads of staff (plus the qm)
|
|
|
|
/obj/structure/noticeboard/captain
|
|
name = "Captain's Notice Board"
|
|
desc = "Important notices from the Captain."
|
|
req_access = list(ACCESS_CAPTAIN)
|
|
|
|
/obj/structure/noticeboard/hop
|
|
name = "Head of Personnel's Notice Board"
|
|
desc = "Important notices from the Head of Personnel."
|
|
req_access = list(ACCESS_HOP)
|
|
|
|
/obj/structure/noticeboard/ce
|
|
name = "Chief Engineer's Notice Board"
|
|
desc = "Important notices from the Chief Engineer."
|
|
req_access = list(ACCESS_CE)
|
|
|
|
/obj/structure/noticeboard/hos
|
|
name = "Head of Security's Notice Board"
|
|
desc = "Important notices from the Head of Security."
|
|
req_access = list(ACCESS_HOS)
|
|
|
|
/obj/structure/noticeboard/cmo
|
|
name = "Chief Medical Officer's Notice Board"
|
|
desc = "Important notices from the Chief Medical Officer."
|
|
req_access = list(ACCESS_CMO)
|
|
|
|
/obj/structure/noticeboard/rd
|
|
name = "Research Director's Notice Board"
|
|
desc = "Important notices from the Research Director."
|
|
req_access = list(ACCESS_RD)
|
|
|
|
/obj/structure/noticeboard/qm
|
|
name = "Quartermaster's Notice Board"
|
|
desc = "Important notices from the Quartermaster."
|
|
req_access = list(ACCESS_QM)
|
|
|
|
/obj/structure/noticeboard/staff
|
|
name = "Staff Notice Board"
|
|
desc = "Important notices from the heads of staff."
|
|
req_access = list(ACCESS_COMMAND)
|
|
|
|
#undef MAX_NOTICES
|