cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-22 12:41:09 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
ok-behavior-trees
Bubberstation/code/game/objects/structures/reflector.dm
T
Leland KembleandGitHub 06608081d2 Moves a greater manyer morer things from attackby() to item_interaction() (#96739) 
## About The Pull Request

50 files, plus additonal file that was necessary because I slightly
refactored windoor construction. This ended up like three and a half
times larger than most of the other ones, I really wasn't meaning for
that to happen. Maybe its because I more vigorously enforced the empty
line after every return thing. The only way to find out is to read 1700
lines of changes, and I don't feel like doing that again. I pinky
promise it all works, and I've tested every item changed individually.

Changes beyond conversion:
You can't welder down reinforced falsewalls anymore, pretty sure it was
an oversight because they're supposed to be taken down by wirecutters
You can right click to close gun lockers with an empty hand, because
otherwise you can't close the lockers at all if there's a gun in them
Meatspikes no longer runtime on construction due to the old trick of
balloon alert + qdel
Windoor assembly no longer SUCKS DICK!!, it's no longer storing
essentially a boolean in an undocumented number in a string, it no
longer requires a VERB to flip its direction.
on a related note, the creator of the windoor assembly construction
steps has been sent to live on a farm far out in the country

Also, a quick note about how these prs are gonna fuck everything up
until they're all together. There's a lot more places where `attackby()`
is directly called than I would have assumed, and given as those are
being changed to call `item_interaction()` potentially(usually) in a
different pr than the pr in which that atom's `attackby()` is actually
converted, that function's not going to work at all until both are
merged. The good news is that almost every instance this is happening,
it's pure convenience, where the user would have access to both items
anyway and could just manually call the attack chain by clicking them
together. Instances where this is not the case are being skipped over
until they can be packaged together to avoid the issue, but I'm not
bothering to do this on ones where the desync won't make an interaction
actually unusable, because that would require me to turn a 1700 line pr
into a 3500 line pr and I really was aiming for like 500

## Why It's Good For The Game

Ignore the paragraph about how I expect this to create a hostage
situation where the only fix to the bugs I make is to merge my other
prs, and instead think about how cool swing combat would be and how much
you want it

## Changelog
🆑
fix: you now can only use a wirecutter to take down a reinforced
falsewall
fix: meatspikes no longer runtime on construction
fix: you no longer have to use a verb that you can't use to flip windoor
assemblies

qol: you can right click a gun locker to close it

code: 50 files have been moved from attackby() to item_interaction()
/🆑
2026-07-16 15:07:43 +02:00

351 lines
11 KiB
Plaintext
Raw Permalink Blame History

/obj/structure/reflector
name = "reflector base"
icon = 'icons/obj/structures.dmi'
icon_state = "reflector_map"
desc = "A base for reflector assemblies."
anchored = FALSE
density = FALSE
custom_materials = list(/datum/material/iron = SHEET_MATERIAL_AMOUNT * 5)
var/deflector_icon_state
var/mutable_appearance/deflector_overlay
var/finished = FALSE
var/admin = FALSE //Can't be rotated or deconstructed
var/can_rotate = TRUE
var/framebuildstacktype = /obj/item/stack/sheet/iron
var/framebuildstackamount = 5
var/buildstacktype = /obj/item/stack/sheet/iron
var/buildstackamount = 0
var/list/allowed_projectile_typecache = list(/obj/projectile/beam, /obj/projectile/energy/nuclear_particle)
var/rotation_angle = -1
/obj/structure/reflector/Initialize(mapload)
. = ..()
icon_state = "reflector_base"
allowed_projectile_typecache = typecacheof(allowed_projectile_typecache)
if(deflector_icon_state)
deflector_overlay = mutable_appearance(icon, deflector_icon_state)
// We offset our physical position DOWN, because TRANSFORM IS A FUCK
deflector_overlay.pixel_y = -32
deflector_overlay.pixel_z = 32
add_overlay(deflector_overlay)
if(rotation_angle == -1)
set_angle(dir2angle(dir))
else
set_angle(rotation_angle)
if(admin)
can_rotate = FALSE
AddComponent(/datum/component/usb_port, typecacheof(list(/obj/item/circuit_component/reflector), only_root_path = TRUE))
/obj/structure/reflector/examine(mob/user)
. = ..()
if(finished)
. += "It is set to [rotation_angle] degrees, and the rotation is [can_rotate ? "unlocked" : "locked"]."
if(!admin)
if(can_rotate)
. += span_notice("Use your <b>hand</b> to adjust its direction.")
. += span_notice("Use a <b>screwdriver</b> to lock the rotation.")
else
. += span_notice("Use <b>screwdriver</b> to unlock the rotation.")
/obj/structure/reflector/proc/set_angle(new_angle)
if(can_rotate)
rotation_angle = new_angle
if(deflector_overlay)
cut_overlay(deflector_overlay)
deflector_overlay.transform = turn(matrix(), new_angle)
add_overlay(deflector_overlay)
/obj/structure/reflector/setDir(new_dir)
return ..(NORTH)
/obj/structure/reflector/bullet_act(obj/projectile/proj)
var/pdir = proj.dir
var/pangle = proj.angle
var/ploc = get_turf(proj)
if(!finished || !allowed_projectile_typecache[proj.type] || !(proj.dir in GLOB.cardinals))
return ..()
if(auto_reflect(proj, pdir, ploc, pangle) != BULLET_ACT_FORCE_PIERCE)
return ..()
return BULLET_ACT_FORCE_PIERCE
/obj/structure/reflector/proc/auto_reflect(obj/projectile/proj, pdir, turf/ploc, pangle)
proj.ignore_source_check = TRUE
proj.range = proj.maximum_range
proj.maximum_range = max(proj.maximum_range--, 0)
return BULLET_ACT_FORCE_PIERCE
/obj/structure/reflector/tool_act(mob/living/user, obj/item/tool, list/modifiers)
if(admin && tool.tool_behaviour)
return ITEM_INTERACT_BLOCKING
return ..()
/obj/structure/reflector/screwdriver_act(mob/living/user, obj/item/tool)
can_rotate = !can_rotate
to_chat(user, span_notice("You [can_rotate ? "unlock" : "lock"] [src]'s rotation."))
tool.play_tool_sound(src)
return ITEM_INTERACT_SUCCESS
/obj/structure/reflector/wrench_act(mob/living/user, obj/item/tool)
if(anchored)
to_chat(user, span_warning("Unweld [src] from the floor first!"))
return ITEM_INTERACT_SUCCESS
user.visible_message(span_notice("[user] starts to dismantle [src]."), span_notice("You start to dismantle [src]..."))
if(!tool.use_tool(src, user, 8 SECONDS, volume=50))
return ITEM_INTERACT_BLOCKING
to_chat(user, span_notice("You dismantle [src]."))
new framebuildstacktype(drop_location(), framebuildstackamount)
if(buildstackamount)
new buildstacktype(drop_location(), buildstackamount)
qdel(src)
return ITEM_INTERACT_SUCCESS
/obj/structure/reflector/welder_act(mob/living/user, obj/item/tool)
if(!tool.tool_start_check(user, amount=1))
return ITEM_INTERACT_BLOCKING
if(atom_integrity < max_integrity)
user.visible_message(span_notice("[user] starts to repair [src]."),
span_notice("You begin repairing [src]..."),
span_hear("You hear welding."))
if(tool.use_tool(src, user, 4 SECONDS, volume=40))
atom_integrity = max_integrity
user.visible_message(span_notice("[user] repairs [src]."), \
span_notice("You finish repairing [src]."))
else if(!anchored)
user.visible_message(span_notice("[user] starts to weld [src] to the floor."),
span_notice("You start to weld [src] to the floor..."),
span_hear("You hear welding."))
if (tool.use_tool(src, user, 2 SECONDS, volume=50))
set_anchored(TRUE)
to_chat(user, span_notice("You weld [src] to the floor."))
else
user.visible_message(span_notice("[user] starts to cut [src] free from the floor."),
span_notice("You start to cut [src] free from the floor..."),
span_hear("You hear welding."))
if (tool.use_tool(src, user, 2 SECONDS, volume=50))
set_anchored(FALSE)
to_chat(user, span_notice("You cut [src] free from the floor."))
return ITEM_INTERACT_SUCCESS
/obj/structure/reflector/item_interaction(mob/living/user, obj/item/tool, list/modifiers)
if(admin)
return ITEM_INTERACT_BLOCKING
//Finishing the frame
if(!istype(tool, /obj/item/stack/sheet))
return NONE
if(finished)
return ITEM_INTERACT_BLOCKING
var/obj/item/stack/sheet/using_stack = tool
if(istype(using_stack, /obj/item/stack/sheet/glass))
if(!using_stack.use(5))
to_chat(user, span_warning("You need five sheets of glass to create a reflector!"))
return ITEM_INTERACT_BLOCKING
new /obj/structure/reflector/single(drop_location())
qdel(src)
return ITEM_INTERACT_SUCCESS
if(istype(using_stack, /obj/item/stack/sheet/rglass))
if(!using_stack.use(10))
to_chat(user, span_warning("You need ten sheets of reinforced glass to create a double reflector!"))
return ITEM_INTERACT_BLOCKING
new /obj/structure/reflector/double(drop_location())
qdel(src)
return ITEM_INTERACT_SUCCESS
if(istype(using_stack, /obj/item/stack/sheet/mineral/diamond))
if(!using_stack.use(1))
return ITEM_INTERACT_BLOCKING
new /obj/structure/reflector/box(drop_location())
qdel(src)
return ITEM_INTERACT_SUCCESS
/obj/structure/reflector/proc/rotate(mob/user)
if (!can_rotate || admin)
to_chat(user, span_warning("The rotation is locked!"))
return FALSE
var/new_angle = tgui_input_number(user, "New angle for primary reflection face", "Reflector Angle", rotation_angle, 360)
if(isnull(new_angle) || QDELETED(user) || QDELETED(src) || !usr.can_perform_action(src, FORBID_TELEKINESIS_REACH))
return FALSE
set_angle(SIMPLIFY_DEGREES(new_angle))
return TRUE
//TYPES OF REFLECTORS, SINGLE, DOUBLE, BOX
//SINGLE
/obj/structure/reflector/single
name = "reflector"
deflector_icon_state = "reflector"
desc = "An angled mirror for reflecting laser beams."
density = TRUE
finished = TRUE
buildstacktype = /obj/item/stack/sheet/glass
buildstackamount = 5
/obj/structure/reflector/single/anchored
anchored = TRUE
/obj/structure/reflector/single/mapping
admin = TRUE
anchored = TRUE
/obj/structure/reflector/single/auto_reflect(obj/projectile/proj, pdir, turf/ploc, pangle)
var/incidence = GET_ANGLE_OF_INCIDENCE(rotation_angle, (proj.angle + 180))
if(abs(incidence) > 90 && abs(incidence) < 270)
return FALSE
var/new_angle = SIMPLIFY_DEGREES(rotation_angle + incidence)
proj.set_angle_centered(loc, new_angle)
return ..()
//DOUBLE
/obj/structure/reflector/double
name = "double sided reflector"
deflector_icon_state = "reflector_double"
desc = "A double sided angled mirror for reflecting laser beams."
density = TRUE
finished = TRUE
buildstacktype = /obj/item/stack/sheet/rglass
buildstackamount = 10
custom_materials = list(/datum/material/iron = SHEET_MATERIAL_AMOUNT * 10, /datum/material/glass = SHEET_MATERIAL_AMOUNT * 10)
/obj/structure/reflector/double/anchored
anchored = TRUE
/obj/structure/reflector/double/mapping
admin = TRUE
anchored = TRUE
/obj/structure/reflector/double/auto_reflect(obj/projectile/proj, pdir, turf/ploc, pangle)
var/incidence = GET_ANGLE_OF_INCIDENCE(rotation_angle, (proj.angle + 180))
var/new_angle = SIMPLIFY_DEGREES(rotation_angle + incidence)
proj.forceMove(loc)
proj.set_angle_centered(loc, new_angle)
return ..()
//BOX
/obj/structure/reflector/box
name = "reflector box"
deflector_icon_state = "reflector_box"
desc = "A box with an internal set of mirrors that reflects all laser beams in a single direction."
density = TRUE
finished = TRUE
buildstacktype = /obj/item/stack/sheet/mineral/diamond
buildstackamount = 1
custom_materials = list(/datum/material/iron = SHEET_MATERIAL_AMOUNT * 10, /datum/material/diamond = SHEET_MATERIAL_AMOUNT)
/obj/structure/reflector/box/anchored
anchored = TRUE
/obj/structure/reflector/box/mapping
admin = TRUE
anchored = TRUE
/obj/structure/reflector/box/auto_reflect(obj/projectile/proj)
proj.set_angle_centered(loc, rotation_angle)
return ..()
/obj/structure/reflector/ex_act()
if(admin)
return FALSE
return ..()
/obj/structure/reflector/singularity_act()
if(admin)
return
else
return ..()
// USB
/obj/item/circuit_component/reflector
display_name = "Reflector"
desc = "Allows you to adjust the angle of a reflector."
circuit_flags = CIRCUIT_FLAG_INPUT_SIGNAL
///angle the reflector will be set to at trigger unless locked
var/datum/port/input/angle
var/obj/structure/reflector/attached_reflector
/obj/item/circuit_component/reflector/populate_ports()
angle = add_input_port("Angle", PORT_TYPE_NUMBER)
/obj/item/circuit_component/reflector/register_usb_parent(atom/movable/parent)
. = ..()
if(istype(parent, /obj/structure/reflector))
attached_reflector = parent
/obj/item/circuit_component/reflector/unregister_usb_parent(atom/movable/parent)
attached_reflector = null
return ..()
/obj/item/circuit_component/reflector/input_received(datum/port/input/port)
attached_reflector?.set_angle(angle.value)
// tgui menu
/obj/structure/reflector/ui_interact(mob/user, datum/tgui/ui)
if(!finished)
user.balloon_alert(user, "nothing to rotate!")
return
if(!can_rotate)
user.balloon_alert(user, "can't rotate!")
ui?.close()
return
ui = SStgui.try_update_ui(user, src, ui)
if(!ui)
ui = new(user, src, "Reflector")
ui.open()
/obj/structure/reflector/attack_robot(mob/user)
ui_interact(user)
return
/obj/structure/reflector/ui_state(mob/user)
return GLOB.physical_state //Prevents borgs from adjusting this at range
/obj/structure/reflector/ui_data(mob/user)
var/list/data = list()
data["rotation_angle"] = rotation_angle
data["reflector_name"] = name
return data
/obj/structure/reflector/ui_act(action, list/params, datum/tgui/ui, datum/ui_state/state)
. = ..()
if(.)
return
switch(action)
if("rotate")
if (!can_rotate || admin)
return FALSE
var/new_angle = params["rotation_angle"]
if(!isnull(new_angle))
set_angle(SIMPLIFY_DEGREES(new_angle))
return TRUE
if("calculate")
if (!can_rotate || admin)
return FALSE
var/new_angle = rotation_angle + params["rotation_angle"]
if(!isnull(new_angle))
set_angle(SIMPLIFY_DEGREES(new_angle))
return TRUE
/obj/structure/reflector/wrenched
/obj/structure/reflector/wrenched/Initialize(mapload)
. = ..()
set_anchored(TRUE)
Reference in New Issue View Git Blame Copy Permalink