mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-08-22 04:30:44 +01:00
GhomandGitHub
6eb2d1674a
## About The Pull Request In similar fashion to what was done with crafting recipes last year, this year it's time for techweb designs and printed items to be audited. This is mostly just about consistency, we've a lot of items that can be printed by protolathes, autolathes, circuit printers and techfab etc. However they almost all (except most stacks, mainly) have custom materials that do not match in one way or another with the materials used by the design, which is what this PR is for. "But items printed from lathes etc. already get the mats used to make them." Yes, they do, however that isn't the case for items of the same type that were spawned in some other way (cargo shuttle, space/maints loot, mapped, admins), this create a subtle discrepancy. It isn't a huge deal (in spite of the size of this PR, ton of designs), but given that I have done something similar with crafting recipes before, I may as well give it a second arc of some sort and bring things to completion. And fix a few possible oversights. TL;DR consistency and stuff ## Why It's Good For The Game Consistency, unit test checks to make it harder not to be consistent in the future. Still has a few TODOs like: - [x] Fixed newly printed, fully charged RCDs costing less than the RCD cartridges required to fully charge one. EDIT: I had to tweak the newly added RDD as well because it suffered from the same fundamental issue. - [x] Fixed plates being made of iron and yet shattering like ceramic ones. A new subtype for metallic ones has been made. ## Changelog 🆑 refactor: Refactored a few things with techweb designs (the ones for autolathes, protolathes, circuit printers, mechfabs etc.) to make sure that the materials of items that can be made from these designs more closely match the materials used to make them. fix: Lizard fries no longer need a plate to be made, like all other treats that used to require plates in a distant past. balance: Tweaked the materials cost of RCD, RDD and RCD cartridges. image: Oven trays now have a more metallic hue. balance: Plates printed printed from lathes won't shatter like ceramic ones, in virtue of them being made out of iron instead. /🆑
177 lines
6.6 KiB
Plaintext
177 lines
6.6 KiB
Plaintext
#define MODPAINT_MAX_COLOR_VALUE 1.25
|
|
#define MODPAINT_MIN_COLOR_VALUE 0
|
|
#define MODPAINT_MAX_SECTION_COLORS 2
|
|
#define MODPAINT_MIN_SECTION_COLORS 0.25
|
|
#define MODPAINT_MAX_OVERALL_COLORS 4
|
|
#define MODPAINT_MIN_OVERALL_COLORS 1.5
|
|
|
|
/obj/item/mod/paint
|
|
name = "MOD paint kit"
|
|
desc = "This kit will repaint your MODsuit to something unique."
|
|
icon = 'icons/obj/clothing/modsuit/mod_construction.dmi'
|
|
icon_state = "paintkit"
|
|
custom_materials = list(/datum/material/iron = SMALL_MATERIAL_AMOUNT * 5, /datum/material/plastic = SMALL_MATERIAL_AMOUNT * 5)
|
|
var/obj/item/mod/control/editing_mod
|
|
var/atom/movable/screen/map_view/proxy_view
|
|
var/list/current_color
|
|
|
|
/obj/item/mod/paint/Initialize(mapload)
|
|
. = ..()
|
|
current_color = COLOR_MATRIX_IDENTITY
|
|
|
|
/obj/item/mod/paint/examine(mob/user)
|
|
. = ..()
|
|
. += span_notice("<b>Left-click</b> a MODsuit to change skin.")
|
|
. += span_notice("<b>Right-click</b> a MODsuit to recolor.")
|
|
|
|
/obj/item/mod/paint/ui_interact(mob/user, datum/tgui/ui)
|
|
if(!editing_mod)
|
|
return
|
|
ui = SStgui.try_update_ui(user, src, ui)
|
|
if(!ui)
|
|
ui = new(user, src, "MODpaint", name)
|
|
ui.open()
|
|
proxy_view.display_to(user, ui.window)
|
|
|
|
/obj/item/mod/paint/ui_host()
|
|
return editing_mod
|
|
|
|
/obj/item/mod/paint/ui_close(mob/user)
|
|
. = ..()
|
|
editing_mod = null
|
|
QDEL_NULL(proxy_view)
|
|
current_color = COLOR_MATRIX_IDENTITY
|
|
|
|
/obj/item/mod/paint/ui_status(mob/user, datum/ui_state/state)
|
|
if(check_menu(editing_mod, user))
|
|
return ..()
|
|
return UI_CLOSE
|
|
|
|
/obj/item/mod/paint/ui_static_data(mob/user)
|
|
var/list/data = list()
|
|
data["mapRef"] = proxy_view.assigned_map
|
|
return data
|
|
|
|
/obj/item/mod/paint/ui_data(mob/user)
|
|
var/list/data = list()
|
|
data["currentColor"] = current_color
|
|
return data
|
|
|
|
/obj/item/mod/paint/ui_act(action, list/params, datum/tgui/ui, datum/ui_state/state)
|
|
. = ..()
|
|
if(.)
|
|
return
|
|
switch(action)
|
|
if("transition_color")
|
|
current_color = params["color"]
|
|
animate(proxy_view, time = 0.5 SECONDS, color = current_color)
|
|
if("confirm")
|
|
if(length(current_color) != 20) //20 is the length of a matrix identity list
|
|
return
|
|
for(var/color_value in current_color)
|
|
if(isnum(color_value))
|
|
continue
|
|
return
|
|
var/total_color_value = 0
|
|
var/list/total_colors = current_color.Copy()
|
|
total_colors.Cut(13, length(total_colors)) // 13 to 20 are just a and c, dont want to count them
|
|
var/red_value = current_color[1] + current_color[5] + current_color[9] //rr + gr + br
|
|
var/green_value = current_color[2] + current_color[6] + current_color[10] //rg + gg + bg
|
|
var/blue_value = current_color[3] + current_color[7] + current_color[11] //rb + gb + bb
|
|
if(red_value > MODPAINT_MAX_SECTION_COLORS)
|
|
balloon_alert(usr, "total red too high! ([red_value*100]%/[MODPAINT_MAX_SECTION_COLORS*100]%)")
|
|
return
|
|
else if(red_value < MODPAINT_MIN_SECTION_COLORS)
|
|
balloon_alert(usr, "total red too low! ([red_value*100]%/[MODPAINT_MIN_SECTION_COLORS*100]%)")
|
|
return
|
|
if(green_value > MODPAINT_MAX_SECTION_COLORS)
|
|
balloon_alert(usr, "total green too high! ([green_value*100]%/[MODPAINT_MAX_SECTION_COLORS*100]%)")
|
|
return
|
|
else if(green_value < MODPAINT_MIN_SECTION_COLORS)
|
|
balloon_alert(usr, "total green too low! ([green_value*100]%/[MODPAINT_MIN_SECTION_COLORS*100]%)")
|
|
return
|
|
if(blue_value > MODPAINT_MAX_SECTION_COLORS)
|
|
balloon_alert(usr, "total blue too high! ([blue_value*100]%/[MODPAINT_MAX_SECTION_COLORS*100]%)")
|
|
return
|
|
else if(blue_value < MODPAINT_MIN_SECTION_COLORS)
|
|
balloon_alert(usr, "total blue too low! ([blue_value*100]%/[MODPAINT_MIN_SECTION_COLORS*100]%)")
|
|
return
|
|
for(var/color_value in total_colors)
|
|
total_color_value += color_value
|
|
if(color_value > MODPAINT_MAX_COLOR_VALUE)
|
|
balloon_alert(usr, "one of colors too high! ([color_value*100]%/[MODPAINT_MAX_COLOR_VALUE*100]%")
|
|
return
|
|
else if(color_value < MODPAINT_MIN_COLOR_VALUE)
|
|
balloon_alert(usr, "one of colors too low! ([color_value*100]%/[MODPAINT_MIN_COLOR_VALUE*100]%")
|
|
return
|
|
if(total_color_value > MODPAINT_MAX_OVERALL_COLORS)
|
|
balloon_alert(usr, "total colors too high! ([total_color_value*100]%/[MODPAINT_MAX_OVERALL_COLORS*100]%)")
|
|
return
|
|
else if(total_color_value < MODPAINT_MIN_OVERALL_COLORS)
|
|
balloon_alert(usr, "total colors too low! ([total_color_value*100]%/[MODPAINT_MIN_OVERALL_COLORS*100]%)")
|
|
return
|
|
editing_mod.set_mod_color(current_color)
|
|
SStgui.close_uis(src)
|
|
|
|
/obj/item/mod/paint/proc/paint_skin(obj/item/mod/control/mod, mob/user)
|
|
if(length(mod.theme.variants) <= 1)
|
|
balloon_alert(user, "no alternate skins!")
|
|
return
|
|
var/list/skins = list()
|
|
for(var/mod_skin_name in mod.theme.variants)
|
|
var/list/mod_skin = mod.theme.variants[mod_skin_name]
|
|
skins[mod_skin_name] = image(icon = mod_skin[MOD_ICON_OVERRIDE] || mod.icon, icon_state = "[mod_skin_name]-control")
|
|
var/pick = show_radial_menu(user, mod, skins, custom_check = CALLBACK(src, PROC_REF(check_menu), mod, user), require_near = TRUE)
|
|
if(!pick)
|
|
balloon_alert(user, "no skin picked!")
|
|
return
|
|
mod.theme.set_skin(mod, pick)
|
|
|
|
/obj/item/mod/paint/proc/check_menu(obj/item/mod/control/mod, mob/user)
|
|
if(user.incapacitated || !user.is_holding(src) || !mod || mod.active || mod.activating)
|
|
return FALSE
|
|
return TRUE
|
|
|
|
#undef MODPAINT_MAX_COLOR_VALUE
|
|
#undef MODPAINT_MIN_COLOR_VALUE
|
|
#undef MODPAINT_MAX_SECTION_COLORS
|
|
#undef MODPAINT_MIN_SECTION_COLORS
|
|
#undef MODPAINT_MAX_OVERALL_COLORS
|
|
#undef MODPAINT_MIN_OVERALL_COLORS
|
|
|
|
/obj/item/mod/skin_applier
|
|
name = "MOD skin applier"
|
|
desc = "This one-use skin applier will add a skin to MODsuits of a specific type. Must be used on an inactive control unit."
|
|
icon = 'icons/obj/clothing/modsuit/mod_construction.dmi'
|
|
icon_state = "skinapplier"
|
|
var/skin = "civilian"
|
|
|
|
/obj/item/mod/skin_applier/Initialize(mapload)
|
|
. = ..()
|
|
name = "MOD [skin] skin applier"
|
|
|
|
/obj/item/mod/skin_applier/interact_with_atom(atom/attacked_atom, mob/living/user, params)
|
|
if(!istype(attacked_atom, /obj/item/mod/control))
|
|
return NONE
|
|
var/obj/item/mod/control/mod = attacked_atom
|
|
if(mod.active || mod.activating)
|
|
balloon_alert(user, "unit active!")
|
|
return ITEM_INTERACT_BLOCKING
|
|
if(!(skin in mod.theme.variants))
|
|
balloon_alert(user, "wrong theme for skin!")
|
|
return ITEM_INTERACT_BLOCKING
|
|
mod.theme.set_skin(mod, skin)
|
|
balloon_alert(user, "skin applied")
|
|
qdel(src)
|
|
return ITEM_INTERACT_SUCCESS
|
|
|
|
/obj/item/mod/skin_applier/honkerative
|
|
desc = /obj/item/mod/skin_applier::desc + " Additionally, this kit attempts to install a waddling module. Honk!"
|
|
skin = "honkerative"
|
|
|
|
/obj/item/mod/skin_applier/honkerative/interact_with_atom(obj/item/mod/control/controlunit, mob/living/user, params)
|
|
. = ..()
|
|
if(!(. & ITEM_INTERACT_SUCCESS))
|
|
return
|
|
controlunit.install(new /obj/item/mod/module/waddle(get_turf(user)), user)
|