mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-07-17 11:05:16 +01:00
Joshua Kidder
7a3ad79506
## About The Pull Request It's just a partial cleanup of anti-[STYLE](https://github.com/tgstation/tgstation/blob/master/.github/guides/STYLE.md) code from /tg/'s ancient history. I compiled & tested with my helpful assistant and damage is still working. <img width="1920" height="1040" alt="image" src="https://github.com/user-attachments/assets/26dabc17-088f-4008-b299-3ff4c27142c3" /> I'll upload the .cs script I used to do it shortly. ## Why It's Good For The Game Just minor code cleanup. Script used is located at https://metek.tech/camelTo-Snake.7z EDIT 11/23/25: Updated the script to use multithreading and sequential scan so it works a hell of a lot faster ``` /* // Copyright 2025 Joshua 'Joan Metekillot' Kidder This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with this program. If not, see <https://www.gnu.org/licenses/>. // */ using System.Text.RegularExpressions; class Program { static async Task Main(string[] args) { var readFile = new FileStreamOptions { Access = FileAccess.Read, Share = FileShare.ReadWrite, Options = FileOptions.Asynchronous | FileOptions.SequentialScan }; FileStreamOptions writeFile = new FileStreamOptions { Share = FileShare.ReadWrite, Access = FileAccess.ReadWrite, Mode = FileMode.Truncate, Options = FileOptions.Asynchronous }; RegexOptions regexOptions = RegexOptions.Multiline | RegexOptions.Compiled; Dictionary<string, int> changedProcs = new(); string regexPattern = @"(?<=\P{L})([a-z]+)([A-Z]{1,2}[a-z]+)*(Brute|Burn|Fire|Tox|Oxy|Organ|Stamina)(Loss)([A-Z]{1,2}[a-z]+)*"; Regex camelCaseProcRegex = new(regexPattern, regexOptions); string snakeify(Match matchingRegex) { var vals = matchingRegex.Groups.Cast<Group>().SelectMany(_ => _.Captures).Select(_ => _.Value).ToArray(); var newVal = string.Join("_", vals.Skip(1).ToArray()).ToLower(); string logString = $"{vals[0]} => {newVal}"; if (changedProcs.TryGetValue(logString, out int value)) { changedProcs[logString] = value + 1; } else { changedProcs.Add(logString, 1); } return newVal; } var dmFiles = Directory.EnumerateFiles(".", "*.dm", SearchOption.AllDirectories).ToAsyncEnumerable<string>(); // uses default ParallelOptions // https://learn.microsoft.com/en-us/dotnet/api/system.threading.tasks.paralleloptions?view=net-10.0#main await Parallel.ForEachAsync(dmFiles, async (filePath, UnusedCancellationToken) => { var reader = new StreamReader(filePath, readFile); string oldContent = await reader.ReadToEndAsync(); string newContent = camelCaseProcRegex.Replace(oldContent, new MatchEvaluator((Func<Match, string>)snakeify)); if (oldContent != newContent) { var writer = new StreamWriter(filePath, writeFile); await writer.WriteAsync(newContent); await writer.DisposeAsync(); } reader.Dispose(); }); var logToList = changedProcs.Cast<KeyValuePair<string, int>>().ToList(); foreach (var pair in logToList) { Console.WriteLine($"{pair.Key}: {pair.Value} locations"); } } } ``` ## Changelog 🆑 Bisar code: All (Brute|Burn|Fire|Tox|Oxy|Organ|Stamina)(Loss) procs now use snake_case, in-line with the STYLE guide. Underscores rule! /🆑
61 lines
1.8 KiB
Plaintext
61 lines
1.8 KiB
Plaintext
/**
|
|
* # Get Health Component
|
|
*
|
|
* Return the health of a mob
|
|
*/
|
|
/obj/item/circuit_component/health
|
|
display_name = "Get Health"
|
|
desc = "A component that returns the health of an organism."
|
|
category = "Entity"
|
|
|
|
/// The input port
|
|
var/datum/port/input/input_port
|
|
|
|
/// Brute damage
|
|
var/datum/port/output/brute
|
|
/// Burn damage
|
|
var/datum/port/output/burn
|
|
/// Toxin damage
|
|
var/datum/port/output/toxin
|
|
/// Oxyloss damage
|
|
var/datum/port/output/oxy
|
|
/// Health
|
|
var/datum/port/output/health
|
|
|
|
circuit_flags = CIRCUIT_FLAG_INPUT_SIGNAL|CIRCUIT_FLAG_OUTPUT_SIGNAL
|
|
|
|
var/max_range = 5
|
|
|
|
/obj/item/circuit_component/health/get_ui_notices()
|
|
. = ..()
|
|
. += create_ui_notice("Maximum Range: [max_range] tiles", "orange", "info")
|
|
|
|
/obj/item/circuit_component/health/populate_ports()
|
|
input_port = add_input_port("Organism", PORT_TYPE_ATOM)
|
|
|
|
brute = add_output_port("Brute Damage", PORT_TYPE_NUMBER)
|
|
burn = add_output_port("Burn Damage", PORT_TYPE_NUMBER)
|
|
toxin = add_output_port("Toxin Damage", PORT_TYPE_NUMBER)
|
|
oxy = add_output_port("Suffocation Damage", PORT_TYPE_NUMBER)
|
|
health = add_output_port("Health", PORT_TYPE_NUMBER)
|
|
|
|
/obj/item/circuit_component/health/input_received(datum/port/input/port)
|
|
|
|
var/mob/living/organism = input_port.value
|
|
var/turf/current_turf = get_location()
|
|
var/turf/target_location = get_turf(organism)
|
|
if(!istype(organism) || get_dist(current_turf, target_location) > max_range || current_turf.z != target_location.z)
|
|
brute.set_output(null)
|
|
burn.set_output(null)
|
|
toxin.set_output(null)
|
|
oxy.set_output(null)
|
|
health.set_output(null)
|
|
return
|
|
|
|
brute.set_output(organism.get_brute_loss())
|
|
burn.set_output(organism.get_fire_loss())
|
|
toxin.set_output(organism.get_tox_loss())
|
|
oxy.set_output(organism.get_oxy_loss())
|
|
health.set_output(organism.health)
|
|
|