mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-06-01 12:07:02 +01:00
SkyratBot
08ddf2a09e
* Small security / code passover for radar mod pc program (#76299) ## About The Pull Request I saw this line "randomly" and thought "well that can't be safe" https://github.com/tgstation/tgstation/blob/971fbf93629ff48d39302544889060ba69fa0ccc/code/modules/modular_computers/file_system/programs/radar.dm#L67-L68 So I went through and added a sanity check for it to ensure it's only getting passed `ref`s being tracked in the objects list This accompanied some general code improvements ## Why It's Good For The Game Just some extra safety Some of these apps do a follow up check that the selected ref is a valid ref to track, but not all of them (notably the Fission 360). It's unlikely this can be abused but it's good to have ## Changelog 🆑 Melbert qol: Scanning apps (Lifeline app) start with a scan fix: Fixes a potential exploit in radar apps /🆑 * Small security / code passover for radar mod pc program --------- Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com> Co-authored-by: Bloop <vinylspiders@gmail.com>