mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-02-04 21:39:20 +00:00
06b9606beb
* Fixes stowing suit storage jetpacks when retracting modsuit chestplates (#75844) ## About The Pull Request This is a bizare bug I discovered while trying to develop another feature, so let's just get into the reproduction steps: - Wear a modsuit and extend it's parts - Put a jetpack in the suit storage slot and turn it on. Currently, the only jetpack that fits in the storage slot on TG is the captain's jetpack. - While the jetpack is activated, deactivate your modsuit using the UI, which stows the jetpack into your storage module automatically. - This fails to unregister some signal thing because it can't find the user. My fix *could* be shitcode, so any feedback would be appreciated. Jetpack activation and deactivation signals now pass a user. `/datum/component/jetpack/proc/activate(datum/source, mob/user)` `/datum/component/jetpack/proc/deactivate(datum/source, mob/user)` Some jetpack `pre_move_react` thing now has a check to see if it's argument is null. ``` if(!trail) return FALSE ``` ## Why It's Good For The Game Stops a crash/runtime. ## Changelog 🆑 stonetear fix: jetpack signals now pass a user argument. This fixes an error when automatically stowing a captain jetpack into your modsuit. /🆑 * Fixes stowing suit storage jetpacks when retracting modsuit chestplates --------- Co-authored-by: Stonetear <89315023+Stonetear@users.noreply.github.com>