Ghom 7a28a34986 [NO GBP] Fixing fishing code not caring whether a reward is limited or not. (#86125) ...

## About The Pull Request
At some point, I must have removed the check for limited items from
`get_modified_fish_table()` and never replaced the `fish_table.Copy()`
call with `get_fish_table()` (which has it), causing limited rewards to
be yet `again` unlimited. This extends to explosive and lobstrosities
(clientless mobs with the profound fisher comp) once the associated
value of the reward in the `fish_counts` list (the list of keeps track
of these limited rewards) reaches a negative value, because the code
only checks if the value is equal to zero where it frankly it should
check if the value is equal or less than zero.

Also I've set `explosion_malus` to true for a few fish sources that
cover multiple turfs, revisited a few comments and a redundant
UnregisterSignal call in lazy_fishing_spot

## Why It's Good For The Game
Fixing an oversight.

## Changelog

🆑
fix: Fixing fishing not caring whether a reward is limited or not.
/🆑

2024-09-12 13:19:03 +02:00

..

decals

Wallening Revert [MDB Ignore][IDB Ignore] (#86161)

2024-09-03 10:41:51 +02:00

food

The fishening v3: Fishing lures. (#86007)

2024-09-06 19:50:28 -04:00

screentips

Standardizes object deconstruction throughout the codebase. (#82280)

2024-04-04 18:55:51 -06:00

_element.dm

Add a unit test to check that maploaded simple/basic mobs are in an environment they can survive in. (#82180)

2024-03-27 16:01:56 -06:00

ai_control_examine.dm

Monkey eyes fix and noticable organ display refactor; AI monkeys no longer catatonic (#82669)

2024-04-25 12:36:04 +01:00

ai_flee_while_injured.dm

Goats will randomly attack you (#78930)

2023-10-13 00:27:21 -06:00

ai_held_item.dm

Reworks examine (a little) (#86506)

2024-09-10 22:47:58 +02:00

ai_retaliate.dm

…

ai_swap_combat_mode.dm

Converts traders to basic mobs (#79187)

2023-10-31 01:49:56 +00:00

ai_target_damagesource.dm

…

animal_variety.dm

…

art.dm

Revert "Assorted changes to job assignment code and logging." (#85929)

2024-08-17 15:26:08 -07:00

atmos_requirements.dm

Add a unit test to check that maploaded simple/basic mobs are in an environment they can survive in. (#82180)

2024-03-27 16:01:56 -06:00

atmos_sensitive.dm

…

attack_equip.dm

…

attack_zone_randomiser.dm

Ian and Runtime can lick your wounds (#83746)

2024-06-14 18:27:15 -07:00

backblast.dm

Pacifists can no longer endlessly spam rocket launcher backblasts (#82992)

2024-05-02 20:03:41 -06:00

bane.dm

Spelling and Grammar Fixes (#85992)

2024-08-21 17:07:02 +12:00

basic_eating.dm

mothroaches in the wardrobe (#83695)

2024-06-19 15:38:29 -06:00

basic_health_examine.dm

Converts slimes to basic mobs (#82176)

2024-03-27 16:40:52 -06:00

beauty.dm

…

bed_tucking.dm

Allow beds to define what side their headrest is on, fixing medical/roller bed buckling and bed_tuckable directions (#86556)

2024-09-10 17:06:09 +02:00

befriend_petting.dm

…

block_turf_fingerprints.dm

Heretic Influences use alt appearances (so ghosts can now see them (semi-transparent)) (#85932)

2024-09-05 15:00:01 +02:00

blocks_explosives.dm

…

body_temp_sensitive.dm

Add a unit test to check that maploaded simple/basic mobs are in an environment they can survive in. (#82180)

2024-03-27 16:01:56 -06:00

bombable_turf.dm

…

bonus_damage.dm

…

bsa_blocker.dm

…

bugkiller_reagent.dm

…

bump_click.dm

…

can_barricade.dm

…

can_shatter.dm

The fishening v3: Fishing lures. (#86007)

2024-09-06 19:50:28 -04:00

caseless.dm

Refactors embedding to use datums instead of storing data in bespoke elements (#84599)

2024-07-07 23:20:07 +02:00

chemical_transfer.dm

Code compression for reagent holder. Lowers plumbing reaction chamber tick usage (#79686)

2023-11-16 21:44:48 +01:00

chewable.dm

Removes remove_any from the game (#82020)

2024-03-17 15:52:41 -04:00

cleaning.dm

virtual pets (#81342)

2024-02-29 04:24:10 +00:00

cliff_walker.dm

…

climbable.dm

Wallening Revert [MDB Ignore][IDB Ignore] (#86161)

2024-09-03 10:41:51 +02:00

connect_loc.dm

Fixes a decal hard del (#81093)

2024-01-26 02:23:24 +01:00

consumable_mob.dm

basic cats and mini kitchen helpers (#79800)

2023-11-28 21:51:37 -07:00

content_barfer.dm

…

corrupted_organ.dm

[no GBP] Corrupt organs check patient for Holy Water, not surgeon (#83500)

2024-05-29 14:22:25 -04:00

crackable.dm

…

crusher_loot.dm

…

cuffsnapping.dm

Removes final remnants of 'targetted' (#79626)

2023-11-11 07:46:02 -05:00

cult_eyes.dm

Cult Vs. Heretic: 7 Months Later Edition (#82877)

2024-06-29 12:40:33 -05:00

cult_halo.dm

/icons/ folder cleansing crusade part 3 (#83420)

2024-05-25 21:08:08 -07:00

curse_announcement.dm

…

cursed.dm

…

damage_threshold.dm

Fix "/datum/element/damage_threshold looks unharmed!" (#80546)

2023-12-24 20:44:44 +00:00

dangerous_surgical_removal.dm

…

death_drops.dm

…

death_explosion.dm

…

death_gases.dm

…

delete_on_drop.dm

…

deliver_first.dm

…

dextrous.dm

Reworks examine (a little) (#86506)

2024-09-10 22:47:58 +02:00

diggable.dm

…

digitalcamo.dm

HUD traits now apply their corresponding hud automatically. Most clothing/item/etc sources of HUDs now only use traits (#84984)

2024-07-19 01:24:07 +02:00

disarm_attack.dm

Disarm refactor, plus shoving people with shields (#80123)

2024-01-16 19:35:56 -06:00

door_pryer.dm

Xenomorphs and door pryer basic mobs can now attack airlocks in combat mode (#85172)

2024-07-25 20:29:43 +01:00

drag_pickup.dm

Fix mousedrop handling on some atoms (#83971)

2024-06-13 23:45:58 -06:00

dryable.dm

Dehydrator, machine version of drying rack (#85141)

2024-07-21 21:59:05 -07:00

earhealing.dm

…

easily_fragmented.dm

Afterattack is dead, long live Afterattack (#83818)

2024-06-11 21:58:09 -07:00

effect_trail.dm

…

ELEMENT_TEMPLATE.md

Revenants no longer make noise walking into gibs (#81420)

2024-02-13 17:07:16 +01:00

elevation.dm

fixes elevation being permanent if you spawn on it (#85952)

2024-08-19 11:06:58 +00:00

embed.dm

[NO GBP] Embedding hotfix (#84770)

2024-07-08 21:58:01 +02:00

empprotection.dm

…

envenomable_casing.dm

Afterattack is dead, long live Afterattack (#83818)

2024-06-11 21:58:09 -07:00

eyestab.dm

Cult Vs. Heretic: 7 Months Later Edition (#82877)

2024-06-29 12:40:33 -05:00

falling_hazard.dm

…

firestacker.dm

The fishening v3: Fishing lures. (#86007)

2024-09-06 19:50:28 -04:00

fish_safe_storage.dm

Refactored the fish case and examining fish. New bluespace fish case to fit large fish inside a backpack. (#85271)

2024-08-18 06:06:17 -07:00

floorloving.dm

[NO GBP] Fixes hoverboard being able to be used in space. (#84533)

2024-07-07 15:18:08 -04:00

footstep_override.dm

[NO GBP] Fixes catwalks over open space not making a sound when walked over. (#79738)

2023-11-15 18:31:01 -07:00

footstep.dm

Revert "Borg movement now has sounds" (#82795)

2024-04-21 17:13:23 -06:00

forced_gravity.dm

…

frozen.dm

The fishening v3: Fishing lures. (#86007)

2024-09-06 19:50:28 -04:00

gags_recolorable.dm

Corrects 200+ instances of "it's" where it should've been "its" instead (#85169)

2024-07-21 13:41:37 -06:00

give_turf_traits.dm

…

glass_pacifist.dm

Voidwalker Balancing, Fixes and Additions (#85045)

2024-07-20 21:41:44 +01:00

gravedigger.dm

Graveyard update take two (#83567)

2024-06-02 02:52:52 +01:00

hat_wearer.dm

[no gbp] some medbot fixes (#80150)

2023-12-06 18:05:44 -07:00

haunted.dm

Fixes some AI related runtimes (#80828)

2024-01-09 14:06:16 -05:00

high_fiver.dm

…

honkspam.dm

…

hostile_machine.dm

Reworks targeting behavior to fall back onto proximity monitors. Refactors ai cooldowns a bit (#82640)

2024-04-16 17:37:46 -06:00

human_biter.dm

Refactors UnarmedAttack so we don't have like 4 Unarmed Attack signals, kills two more snowflake species procs (#78991)

2023-10-15 22:25:19 -06:00

immerse.dm

Fixes immerse holding refs to qdeleted things (#85061)

2024-07-19 00:52:56 +02:00

inverted_movement.dm

[NO GBP] The deathmatch modifiers modal menu can actually be opened now. (#82041)

2024-03-18 21:10:57 +01:00

item_fov.dm

…

item_scaling.dm

…

kneecapping.dm

Removes final remnants of 'targetted' (#79626)

2023-11-11 07:46:02 -05:00

kneejerk.dm

…

knockback.dm

Afterattack is dead, long live Afterattack (#83818)

2024-06-11 21:58:09 -07:00

lazy_fishing_spot.dm

[NO GBP] Fixing fishing code not caring whether a reward is limited or not. (#86125)

2024-09-12 13:19:03 +02:00

leeching_walk.dm

Reverts an unintended change to Leeching Walk. (#86295)

2024-09-03 17:38:54 +02:00

lifesteal.dm

Refactored the on_hit_effect into an element. (#85034)

2024-07-23 13:50:55 -06:00

light_blocking.dm

Wallening Revert [MDB Ignore][IDB Ignore] (#86161)

2024-09-03 10:41:51 +02:00

light_eaten.dm

Fixes complex lights not handling moving well, renames lighting defines (#81423)

2024-02-12 20:50:20 +01:00

light_eater.dm

Light eater can eat all lights again (#84162)

2024-06-24 16:21:25 -05:00

living_limb_initialiser.dm

Living Limb fixes (feat: Basic mobs attack random body zones again) (#82556)

2024-04-13 15:30:14 -06:00

loomable.dm

loopable looms (#79680)

2023-11-14 13:57:52 -07:00

lube_walking.dm

Changes how lube crawling works and fixes a bug with snails (#83238)

2024-05-16 23:46:03 +02:00

mirage_border.dm

…

mob_access.dm

minebot buff (#82001)

2024-03-29 22:26:35 -06:00

mob_grabber.dm

Refactors UnarmedAttack so we don't have like 4 Unarmed Attack signals, kills two more snowflake species procs (#78991)

2023-10-15 22:25:19 -06:00

mob_killed_tally.dm

…

move_force_on_death.dm

[no gbp] fixes not being able to walk over mook corpses and turns it all to a element (#79054)

2023-10-21 13:39:45 -04:00

movement_turf_changer.dm

Splits placeontop proc (#79702)

2023-11-19 04:58:31 +01:00

movetype_handler.dm

Removes a signal and a list from the movetype handler element. (#86119)

2024-09-05 22:58:39 -06:00

muffles_speech.dm

Facehuggers dont sleep people + muzzle code exorcism (#83721)

2024-07-01 15:50:19 +00:00

nerfed_pulling.dm

…

no_crit_hitting.dm

Voidwalker Balancing, Fixes and Additions (#85045)

2024-07-20 21:41:44 +01:00

noisy_movement.dm

…

noticable_organ.dm

Monkey eyes fix and noticable organ display refactor; AI monkeys no longer catatonic (#82669)

2024-04-25 12:36:04 +01:00

obj_regen.dm

…

on_hit_effect.dm

Refactored the on_hit_effect into an element. (#85034)

2024-07-23 13:50:55 -06:00

only_pull_living.dm

Voidwalker Balancing, Fixes and Additions (#85045)

2024-07-20 21:41:44 +01:00

openspace_item_click_handler.dm

fix tile/rod/rcd multi-z hole repairs (#84255)

2024-06-25 00:34:17 -04:00

ore_collecting.dm

basic gutlunchers and ashwalker ranching (#79508)

2023-11-13 01:20:19 -07:00

organ_set_bonus.dm

…

permanent_fire_overlay.dm

Fix Flaky Failure From Fire (#81399)

2024-02-10 13:39:01 -08:00

pet_bonus.dm

Removes timeout_mod arg from add_mood_effect (#80964)

2024-01-16 20:57:42 +01:00

pet_collar.dm

converts most pet behavior into elements (#85290)

2024-08-04 21:59:12 -06:00

pet_cult.dm

converts most pet behavior into elements (#85290)

2024-08-04 21:59:12 -06:00

plant_backfire.dm

…

point_of_interest.dm

…

poster_tearer.dm

Regal Rats can now tear down posters (#82673)

2024-04-17 18:57:35 +01:00

prevent_attacking_of_types.dm

…

proficient_miner.dm

lavaland raptors (#82537)

2024-05-16 19:54:00 -07:00

projectile_drop.dm

…

projectile_shield.dm

…

quality_food_ingredient.dm

Fishing expansion 2: one-year later boogaloo (#85252)

2024-08-20 06:46:11 +02:00

radiation_protected_clothing.dm

…

radioactive.dm

…

ranged_armour.dm

adds a new fish to lava and plasma rivers (#83146)

2024-05-22 23:11:45 -06:00

relay_attackers.dm

Ancient and recent mecha bug fixes (#84171)

2024-07-01 00:50:05 +02:00

ridable.dm

Wallening Revert [MDB Ignore][IDB Ignore] (#86161)

2024-09-03 10:41:51 +02:00

rust.dm

[NO GBP] Post-Rust Heretic's Rework adjustments. (#83765)

2024-06-07 13:35:39 -04:00

selfknockback.dm

Afterattack is dead, long live Afterattack (#83818)

2024-06-11 21:58:09 -07:00

series.dm

…

sideway_movement.dm

[NO GBP] fixes crab walking (#78648)

2023-09-28 13:42:23 -06:00

simple_flying.dm

Small hulk cleanup / nukes TRAIT_IGNOREDAMAGESLOWDOWN (#85003)

2024-07-17 01:14:08 +02:00

skill_reward.dm

Items in your hands can catch fire (#83867)

2024-06-19 12:15:27 +12:00

skittish.dm

…

slapcrafting.dm

Converts slapcrafting into a bespoke element (#84226)

2024-07-05 22:20:30 +00:00

soft_landing.dm

…

spooky.dm

Spooky element fixes (#83795)

2024-06-08 19:26:03 -04:00

squish_sound.dm

Revenants no longer make noise walking into gibs (#81420)

2024-02-13 17:07:16 +01:00

squish.dm

…

strippable.dm

Fixes that one alien feature that uses mouse drag (#84916)

2024-07-19 01:35:12 +02:00

structure_repair.dm

Refactors UnarmedAttack so we don't have like 4 Unarmed Attack signals, kills two more snowflake species procs (#78991)

2023-10-15 22:25:19 -06:00

swabbable.dm

…

temporary_atom.dm

…

tenacious.dm

…

tiny_mob_hunter.dm

…

tool_flash.dm

Fixes tool-based flashes being stuck at intensity 1 (#83703)

2024-06-06 00:41:40 -04:00

tool_renaming.dm

Refactor renaming UNIQUE_RENAME items from the pen to an element (#82491)

2024-04-12 03:30:32 +00:00

toy_talk.dm

Let's you talk through action figures, plushies, and toy mechs with .l and .r. Also a big clean up of say because its support for non-mobs was lackluster. (#81848)

2024-03-07 09:21:12 -07:00

turf_transparency.dm

Wallening Revert [MDB Ignore][IDB Ignore] (#86161)

2024-09-03 10:41:51 +02:00

undertile.dm

Fixes catwalk rendering layering and catwalk pipe cap issues (#85236)

2024-08-14 13:06:22 +02:00

unfriend_attacker.dm

…

update_icon_blocker.dm

…

update_icon_updates_onmob.dm

…

uplink_reimburse.dm

Adds a signal to buying items from the uplink (& fixes TC misinfo) (#81372)

2024-02-10 18:57:19 +01:00

venomous.dm

Refactored the on_hit_effect into an element. (#85034)

2024-07-23 13:50:55 -06:00

volatile_gas_storage.dm

…

waddling.dm

event based incapicated and able_to_run (#86031)

2024-09-04 10:02:49 -04:00

wall_engraver.dm

…

wall_smasher.dm

Refactors UnarmedAttack so we don't have like 4 Unarmed Attack signals, kills two more snowflake species procs (#78991)

2023-10-15 22:25:19 -06:00

wall_tearer.dm

basic gutlunchers and ashwalker ranching (#79508)

2023-11-13 01:20:19 -07:00

wall_walker.dm

Cult Vs. Heretic: 7 Months Later Edition (#82877)

2024-06-29 12:40:33 -05:00

watery_tile.dm

Water tiles now put out burning atoms (#82735)

2024-04-18 19:53:57 -04:00

weapon_description.dm

…

wearable_client_colour.dm

Converts glasses client colour into an element, appliable to other worn items. (#84542)

2024-07-03 11:45:15 -04:00

weather_listener.dm

Shapechange health transfer tweaks (#79009)

2023-10-26 01:30:53 +00:00

web_walker.dm

…

wheel.dm

event based incapicated and able_to_run (#86031)

2024-09-04 10:02:49 -04:00

window_smash.dm

Tram mob throwing adjustments (#81617)

2024-02-27 01:33:12 +00:00