mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-11 18:22:14 +00:00
c1d68698fb
Productionizes #80615. The core optimization is this: ```patch - var/hint = to_delete.Destroy(arglist(args.Copy(2))) // Let our friend know they're about to get fucked up. + var/hint = to_delete.Destroy(force) // Let our friend know they're about to get fucked up. ``` We avoid a heap allocation in the form of copying the args over to a new list. A/B testing shows this results in 33% better overtime, and in a real round shaving off a full second of self time and 0.4 seconds of overtime--both of these would be doubled in the event this is merged as the new proc was only being run 50% of the time.
94 lines
2.9 KiB
Plaintext
94 lines
2.9 KiB
Plaintext
/datum/component/manual_blinking
|
|
dupe_mode = COMPONENT_DUPE_UNIQUE
|
|
|
|
var/obj/item/organ/internal/eyes/E
|
|
var/warn_grace = FALSE
|
|
var/warn_dying = FALSE
|
|
var/last_blink
|
|
var/check_every = 20 SECONDS
|
|
var/grace_period = 6 SECONDS
|
|
var/damage_rate = 1 // organ damage taken per tick
|
|
var/list/valid_emotes = list(/datum/emote/living/carbon/blink, /datum/emote/living/carbon/blink_r)
|
|
|
|
/datum/component/manual_blinking/Initialize()
|
|
if(!iscarbon(parent))
|
|
return COMPONENT_INCOMPATIBLE
|
|
|
|
var/mob/living/carbon/C = parent
|
|
E = C.get_organ_slot(ORGAN_SLOT_EYES)
|
|
|
|
if(E)
|
|
START_PROCESSING(SSdcs, src)
|
|
last_blink = world.time
|
|
to_chat(C, span_notice("You suddenly realize you're blinking manually."))
|
|
|
|
/datum/component/manual_blinking/Destroy(force)
|
|
E = null
|
|
STOP_PROCESSING(SSdcs, src)
|
|
to_chat(parent, span_notice("You revert back to automatic blinking."))
|
|
return ..()
|
|
|
|
/datum/component/manual_blinking/RegisterWithParent()
|
|
RegisterSignal(parent, COMSIG_MOB_EMOTE, PROC_REF(check_emote))
|
|
RegisterSignal(parent, COMSIG_CARBON_GAIN_ORGAN, PROC_REF(check_added_organ))
|
|
RegisterSignal(parent, COMSIG_CARBON_LOSE_ORGAN, PROC_REF(check_removed_organ))
|
|
RegisterSignal(parent, COMSIG_LIVING_REVIVE, PROC_REF(restart))
|
|
RegisterSignal(parent, COMSIG_LIVING_DEATH, PROC_REF(pause))
|
|
|
|
/datum/component/manual_blinking/UnregisterFromParent()
|
|
UnregisterSignal(parent, COMSIG_MOB_EMOTE)
|
|
UnregisterSignal(parent, COMSIG_CARBON_GAIN_ORGAN)
|
|
UnregisterSignal(parent, COMSIG_CARBON_LOSE_ORGAN)
|
|
UnregisterSignal(parent, COMSIG_LIVING_REVIVE)
|
|
UnregisterSignal(parent, COMSIG_LIVING_DEATH)
|
|
|
|
/datum/component/manual_blinking/proc/restart()
|
|
SIGNAL_HANDLER
|
|
|
|
START_PROCESSING(SSdcs, src)
|
|
|
|
/datum/component/manual_blinking/proc/pause()
|
|
SIGNAL_HANDLER
|
|
|
|
STOP_PROCESSING(SSdcs, src)
|
|
|
|
/datum/component/manual_blinking/process()
|
|
var/mob/living/carbon/C = parent
|
|
|
|
if(world.time > (last_blink + check_every + grace_period))
|
|
if(!warn_dying)
|
|
to_chat(C, span_userdanger("Your eyes begin to wither, you need to blink!"))
|
|
warn_dying = TRUE
|
|
|
|
E.apply_organ_damage(damage_rate)
|
|
else if(world.time > (last_blink + check_every))
|
|
if(!warn_grace)
|
|
to_chat(C, span_danger("You feel a need to blink!"))
|
|
warn_grace = TRUE
|
|
|
|
/datum/component/manual_blinking/proc/check_added_organ(mob/who_cares, obj/item/organ/O)
|
|
SIGNAL_HANDLER
|
|
|
|
var/obj/item/organ/internal/eyes/new_eyes = O
|
|
|
|
if(istype(new_eyes,/obj/item/organ/internal/eyes))
|
|
E = new_eyes
|
|
START_PROCESSING(SSdcs, src)
|
|
|
|
/datum/component/manual_blinking/proc/check_removed_organ(mob/who_cares, obj/item/organ/O)
|
|
SIGNAL_HANDLER
|
|
|
|
var/obj/item/organ/internal/eyes/bye_beyes = O // oh come on, that's pretty good
|
|
|
|
if(istype(bye_beyes, /obj/item/organ/internal/eyes))
|
|
E = null
|
|
STOP_PROCESSING(SSdcs, src)
|
|
|
|
/datum/component/manual_blinking/proc/check_emote(mob/living/carbon/user, datum/emote/emote)
|
|
SIGNAL_HANDLER
|
|
|
|
if(emote.type in valid_emotes)
|
|
warn_grace = FALSE
|
|
warn_dying = FALSE
|
|
last_blink = world.time
|