SkyratBot 4f50d64667 [MIRROR] /datum/element/skill_reward attempting to drop "itself" fix (#27214) ...

* `/datum/element/skill_reward` attempting to drop "itself" fix (#82489)

## About The Pull Request

`src` vs `source` moment.

Plus some minor code cleaup.

## Changelog

🆑 Melbert
fix: Skill rewards should properly be dropped out of unworthy player's
hands
/🆑

* `/datum/element/skill_reward` attempting to drop "itself" fix

---------

Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>

2024-04-16 12:46:02 +02:00

..

decals

[MIRROR] [NO GBP] fixes item blood overlays "leaking" onto other objects (#26639)

2024-02-26 21:28:24 +01:00

food

[MIRROR] General maintenance for grilling related stuff. (#26835)

2024-03-12 00:01:24 -04:00

screentips

[MIRROR] Scopes NODECONSTRUCT_1 from flags_1 to obj_flags [MDB IGNORE] (#25496)

2023-12-08 23:24:46 -05:00

_element.dm

Yet another mirror batch (#27314)

2024-04-16 06:05:57 +00:00

ai_control_examine.dm

…

ai_flee_while_injured.dm

[MIRROR] Goats will randomly attack you [MDB IGNORE] (#24312)

2023-10-13 00:30:01 -07:00

ai_held_item.dm

[MIRROR] Adds p_They (and friends) for capitalized pronoun helpers [MDB IGNORE] (#22555)

2023-07-18 22:10:59 -04:00

ai_retaliate.dm

[MIRROR] Unit Tests for AI Planning Subtrees not having required element/component [MDB IGNORE] (#23047)

2023-08-12 18:34:53 -04:00

ai_swap_combat_mode.dm

[MIRROR] Converts traders to basic mobs [MDB IGNORE] (#24673)

2023-10-31 02:16:50 -04:00

ai_target_damagesource.dm

…

amputating_limbs.dm

[MIRROR] Refactors UnarmedAttack so we don't have like 4 Unarmed Attack signals, kills two more snowflake species procs [MDB IGNORE] (#24356)

2023-10-16 12:37:49 -04:00

animal_variety.dm

…

art.dm

[MIRROR] Adds p_They (and friends) for capitalized pronoun helpers [MDB IGNORE] (#22555)

2023-07-18 22:10:59 -04:00

atmos_requirements.dm

Yet another mirror batch (#27314)

2024-04-16 06:05:57 +00:00

atmos_sensitive.dm

…

attack_equip.dm

…

backblast.dm

…

bane.dm

…

basic_eating.dm

[MIRROR] Cultist pets (#26983)

2024-04-03 23:44:23 +02:00

basic_health_examine.dm

Yet another mirror batch (#27314)

2024-04-16 06:05:57 +00:00

beauty.dm

…

bed_tucking.dm

Missingmirrors (#26743)

2024-03-13 04:07:27 +01:00

befriend_petting.dm

[MIRROR] Adds p_They (and friends) for capitalized pronoun helpers [MDB IGNORE] (#22555)

2023-07-18 22:10:59 -04:00

blocks_explosives.dm

…

body_temp_sensitive.dm

Yet another mirror batch (#27314)

2024-04-16 06:05:57 +00:00

bombable_turf.dm

[MIRROR] Replace wall/indestructible/destructible typepath with mapping helper [MDB IGNORE] (#23735)

2023-09-17 14:41:05 -04:00

bonus_damage.dm

[MIRROR] Spider Evolution - Young Spiders [Ready] [MDB IGNORE] (#22972)

2023-08-09 17:59:34 -04:00

bsa_blocker.dm

…

bugkiller_reagent.dm

…

bump_click.dm

…

can_barricade.dm

[MIRROR] [NO GBP] Fix barricade description element spam [MDB IGNORE] (#23783)

2023-09-18 14:42:59 -04:00

can_shatter.dm

[MIRROR] Adds a small cafeteria behind the right wing shutters of the museum. (#26766)

2024-03-07 08:53:28 -06:00

caseless.dm

[MIRROR] Different pen types have unique behavior when used in foam darts. [MDB IGNORE] (#25183)

2023-11-21 22:54:35 -05:00

chemical_transfer.dm

[MIRROR] Code compression for reagent holder. Lowers plumbing reaction chamber tick usage [MDB IGNORE] (#25050)

2023-11-16 18:27:20 -05:00

chewable.dm

[MIRROR] Removes remove_any from the game (#26930)

2024-04-01 21:41:23 -04:00

cleaning.dm

[MIRROR] virtual pets (#26692)

2024-03-01 19:05:23 +01:00

cliff_walker.dm

[MIRROR] Adds cliffs to icebox [MDB IGNORE] (#22744)

2023-07-28 14:31:06 -04:00

climbable.dm

[MIRROR] Meat Hook Rework (Accidental Features) [MDB IGNORE] (#25343)

2023-12-03 01:07:56 -05:00

connect_loc.dm

[MIRROR] Fixes a decal hard del (#26250)

2024-01-25 23:10:21 -05:00

consumable_mob.dm

[MIRROR] basic cats and mini kitchen helpers [MDB IGNORE] (#25330)

2023-12-03 00:37:58 -05:00

content_barfer.dm

[MIRROR] Synchronise AI and Player basic mob melee behaviours [MDB IGNORE] (#23780)

2023-09-18 15:23:14 -04:00

crackable.dm

…

crusher_loot.dm

…

cuffsnapping.dm

[MIRROR] Removes final remnants of 'targetted' [MDB IGNORE] (#24927)

2023-11-11 08:11:32 -05:00

cult_eyes.dm

[MIRROR] Fix cult halo and eyes affecting deconverted cultists [MDB IGNORE] (#25477)

2023-12-07 03:11:20 +00:00

cult_halo.dm

[MIRROR] Fix cult halo and eyes affecting deconverted cultists [MDB IGNORE] (#25477)

2023-12-07 03:11:20 +00:00

curse_announcement.dm

…

cursed.dm

…

damage_threshold.dm

[MIRROR] Fix "/datum/element/damage_threshold looks unharmed!" [MDB IGNORE] (#25825)

2023-12-24 20:58:11 +00:00

dangerous_surgical_removal.dm

[MIRROR] Bargain bin organ quirks: Prosthetic organ and Tin Man [MDB IGNORE] (#22297)

2023-07-20 16:37:43 -04:00

death_drops.dm

…

death_explosion.dm

…

death_gases.dm

…

delete_on_drop.dm

…

deliver_first.dm

…

dextrous.dm

[MIRROR] Basic Guardians/Holoparasites [MDB IGNORE] (#24921)

2023-11-11 07:07:34 -05:00

diggable.dm

…

digitalcamo.dm

…

disarm_attack.dm

[MIRROR] Disarm refactor, plus shoving people with shields [MDB IGNORE] (#26144)

2024-01-19 01:58:37 +00:00

door_pryer.dm

[MIRROR] Targeting Datums Renamed (and global) [MDB IGNORE] (#24885)

2023-11-09 16:37:48 -05:00

drag_pickup.dm

…

dryable.dm

[MIRROR] Dead code removal, redundant text macros, drying rack now applies TRAIT_FOOD_CHEF_MADE. [MDB IGNORE] (#25971)

2024-01-04 16:58:31 +00:00

earhealing.dm

[MANUAL MIRROR] Robotic organ and disease improvements (#22631)

2023-08-04 15:07:07 -04:00

easily_fragmented.dm

…

effect_trail.dm

…

ELEMENT_TEMPLATE.md

[MIRROR] Revenants no longer make noise walking into gibs (#26500)

2024-02-14 06:26:40 -05:00

elevation.dm

[MIRROR] [NO GBP] Fixes the larva "hide" ability not properly hiding larvas under tables. (#26879)

2024-03-13 19:49:48 -04:00

embed.dm

[MIRROR] Standing on structures such as crates, tables and bed will now look like it. [MDB IGNORE] (#25324)

2023-11-28 19:37:33 -05:00

empprotection.dm

[MIRROR] Refactors chameleon actions, Adds chameleon outfit saving, Adds chameleon scanner [MDB IGNORE] (#22773)

2023-07-29 21:09:06 -04:00

envenomable_casing.dm

…

eyestab.dm

…

falling_hazard.dm

…

firestacker.dm

…

floorloving.dm

…

footstep_override.dm

[MIRROR] [NO GBP] Fixes catwalks over open space not making a sound when walked over. [MDB IGNORE] (#25036)

2023-11-15 21:29:11 -05:00

footstep.dm

[MIRROR] Fix footsteps not working [MDB IGNORE] (#25939)

2024-01-01 19:23:48 +00:00

forced_gravity.dm

[MIRROR] Attempts to fix an issue with gravity generators triggering CI failures [MDB IGNORE] (#22588)

2023-07-19 15:26:25 -04:00

frozen.dm

[MIRROR] Adds and improves logging for various shit. (#26831)

2024-03-11 22:35:39 -04:00

gags_recolorable.dm

[MIRROR] New GaGs clothing: Part 1 - 'Dress'ing up! (#26905)

2024-04-11 11:42:17 +02:00

give_turf_traits.dm

[MIRROR] Removes two redundant components [MDB IGNORE] (#22613)

2023-07-21 13:27:45 -04:00

hat_wearer.dm

[MIRROR] [no gbp] some medbot fixes [MDB IGNORE] (#25472)

2023-12-06 22:00:04 -05:00

haunted.dm

[MIRROR] Fixes some AI related runtimes [MDB IGNORE] (#26046)

2024-01-09 15:35:22 -05:00

high_fiver.dm

…

honkspam.dm

…

hostile_machine.dm

[MIRROR] Optimize find_potential_targets self cost [MDB IGNORE] (#25883)

2023-12-28 07:55:30 -08:00

human_biter.dm

[MIRROR] Refactors UnarmedAttack so we don't have like 4 Unarmed Attack signals, kills two more snowflake species procs [MDB IGNORE] (#24356)

2023-10-16 12:37:49 -04:00

immerse.dm

[MIRROR] Revert "Makes immerse use weakrefs", prioritizing some ref removal lines instead. [MDB IGNORE] (#26149)

2024-01-18 17:03:36 +00:00

inverted_movement.dm

[MIRROR] [NO GBP] The deathmatch modifiers modal menu can actually be opened now. (#26942)

2024-03-20 06:28:45 -04:00

item_fov.dm

…

item_scaling.dm

…

kneecapping.dm

[MIRROR] Removes final remnants of 'targetted' [MDB IGNORE] (#24927)

2023-11-11 08:11:32 -05:00

kneejerk.dm

…

knockback.dm

[MIRROR] Implements usage of the REVERSE_DIR macro throughout the code. [MDB IGNORE] (#22743)

2023-07-28 14:32:01 -04:00

lazy_fishing_spot.dm

[MIRROR] Miscellaneous fishing code changes. [MDB IGNORE] (#23237)

2023-08-21 11:39:47 -04:00

lifesteal.dm

…

light_blocking.dm

…

light_eaten.dm

[MIRROR] Fixes complex lights not handling moving well, renames lighting defines (#26484)

2024-02-12 22:25:22 +00:00

light_eater.dm

[MIRROR] Fix light eater affecting lava, space, openspace, and transparent turfs [MDB IGNORE] (#24826)

2023-11-06 21:21:31 -05:00

loomable.dm

[MIRROR] loopable looms [MDB IGNORE] (#25013)

2023-11-14 17:11:49 -05:00

mirage_border.dm

[MIRROR] Optimize mirage_border by converting it to an element and a movable [MDB IGNORE] (#22913)

2023-08-07 09:41:46 -04:00

mob_access.dm

[MIRROR] minebot buff (#27106)

2024-04-04 14:48:31 -04:00

mob_grabber.dm

[MIRROR] Refactors UnarmedAttack so we don't have like 4 Unarmed Attack signals, kills two more snowflake species procs [MDB IGNORE] (#24356)

2023-10-16 12:37:49 -04:00

mob_killed_tally.dm

…

move_force_on_death.dm

[MIRROR] [no gbp] fixes not being able to walk over mook corpses and turns it all to a element [MDB IGNORE] (#24497)

2023-10-21 18:18:44 -04:00

movement_turf_changer.dm

[MIRROR] Splits placeontop proc [MDB IGNORE] (#25103)

2023-11-19 10:28:18 -05:00

movetype_handler.dm

…

nerfed_pulling.dm

…

noisy_movement.dm

…

noticable_organ.dm

[MIRROR] Adds p_They (and friends) for capitalized pronoun helpers [MDB IGNORE] (#22555)

2023-07-18 22:10:59 -04:00

obj_regen.dm

…

openspace_item_click_handler.dm

[MIRROR] Multi-Z Support for Lazy Templates | Cleans up some turf flag misuse [MDB IGNORE] (#23794)

2023-09-19 13:26:14 -04:00

ore_collecting.dm

[MIRROR] basic gutlunchers and ashwalker ranching [MDB IGNORE] (#24970)

2023-11-13 09:42:16 -05:00

organ_set_bonus.dm

…

permanent_fire_overlay.dm

[MIRROR] 81182 81367 81399 (#26492)

2024-02-12 19:03:58 -05:00

pet_bonus.dm

CI Fix (#26177)

2024-01-19 14:02:59 +00:00

plant_backfire.dm

…

point_of_interest.dm

…

prevent_attacking_of_types.dm

…

projectile_drop.dm

[MIRROR] Fixing embedding for projectiles. [MDB IGNORE] (#23217)

2023-08-20 20:11:26 -04:00

projectile_shield.dm

…

radiation_protected_clothing.dm

…

radioactive.dm

[MIRROR] [NO-GBP] Optimizes rad nebula [MDB IGNORE] (#22675)

2023-07-25 13:26:22 -04:00

ranged_armour.dm

…

relay_attackers.dm

[MIRROR] Fixes Relay Attackers Misfire [MDB IGNORE] (#25039)

2023-11-15 21:28:10 -05:00

ridable.dm

[MIRROR] Refactor removing unused defines. (#26998)

2024-04-03 03:39:46 +02:00

rust.dm

[MIRROR] Attack chain refactoring: Broadening tool_act into item_interact, moving some item interactions to... atom/item_interact / item/interact_with_atom [MDB IGNORE] (#25516)

2023-12-09 08:22:19 -05:00

selfknockback.dm

…

series.dm

…

sideway_movement.dm

[MIRROR] [NO GBP] fixes crab walking [MDB IGNORE] (#24000)

2023-09-28 19:57:20 -04:00

simple_flying.dm

…

skill_reward.dm

[MIRROR] /datum/element/skill_reward attempting to drop "itself" fix (#27214)

2024-04-16 12:46:02 +02:00

skittish.dm

[MIRROR] minor changes to living and mob vars [MDB IGNORE] (#23330)

2023-08-26 04:21:42 -04:00

snail_crawl.dm

[THE HALF-MODULAR PRINCE] Snalance (Snail Balance) and Snissues (Snail Issues) Adjustment (#25439)

2023-12-20 00:53:54 -05:00

soft_landing.dm

…

spooky.dm

…

squish_sound.dm

[MIRROR] Revenants no longer make noise walking into gibs (#26500)

2024-02-14 06:26:40 -05:00

squish.dm

…

strippable.dm

[MIRROR] Strip Menu Suit Sensors (#27073)

2024-04-04 01:49:03 -04:00

structure_repair.dm

[MIRROR] Refactors UnarmedAttack so we don't have like 4 Unarmed Attack signals, kills two more snowflake species procs [MDB IGNORE] (#24356)

2023-10-16 12:37:49 -04:00

swabbable.dm

…

temporary_atom.dm

…

tenacious.dm

…

tiny_mob_hunter.dm

…

tool_flash.dm

…

toy_talk.dm

[MIRROR] Let's you talk through action figures, plushies, and toy mechs with .l and .r. Also a big clean up of say because its support for non-mobs was lackluster. (#26790)

2024-03-26 11:36:14 -04:00

turf_transparency.dm

[MIRROR] Multi-Z Support for Lazy Templates | Cleans up some turf flag misuse [MDB IGNORE] (#23794)

2023-09-19 13:26:14 -04:00

undertile.dm

[MIRROR] Invisibility refactor [MDB IGNORE] (#24405)

2023-10-18 00:36:09 -04:00

unfriend_attacker.dm

…

update_icon_blocker.dm

…

update_icon_updates_onmob.dm

…

uplink_reimburse.dm

[MIRROR] Adds a signal to buying items from the uplink (& fixes TC misinfo) (#26449)

2024-02-10 23:17:36 -05:00

venomous.dm

[MIRROR] Throwing a bee at someone injects reagents [MDB IGNORE] (#25663)

2023-12-17 10:06:35 -05:00

volatile_gas_storage.dm

…

waddling.dm

[MIRROR] Cardboard cutouts are now tactical. (#26545)

2024-02-17 13:25:03 -05:00

wall_engraver.dm

…

wall_smasher.dm

[MIRROR] Refactors UnarmedAttack so we don't have like 4 Unarmed Attack signals, kills two more snowflake species procs [MDB IGNORE] (#24356)

2023-10-16 12:37:49 -04:00

wall_tearer.dm

[MIRROR] basic gutlunchers and ashwalker ranching [MDB IGNORE] (#24970)

2023-11-13 09:42:16 -05:00

wall_walker.dm

[MIRROR] Basic Constructs: parent type + Harvester [MDB IGNORE] (#24258)

2023-10-10 18:37:00 -04:00

weapon_description.dm

[MIRROR] Adds p_They (and friends) for capitalized pronoun helpers [MDB IGNORE] (#22555)

2023-07-18 22:10:59 -04:00

weather_listener.dm

[MIRROR] Shapechange health transfer tweaks [MDB IGNORE] (#24590)

2023-10-26 06:16:19 -04:00

web_walker.dm

…

wheel.dm

[MIRROR] Basic Mob Raw Prophet [MDB IGNORE] (#24099)

2023-10-03 19:59:50 -04:00

window_smash.dm

[MIRROR] Tram mob throwing adjustments (#26662)

2024-02-27 16:47:19 +01:00