mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-08-21 20:20:33 +01:00
e65a48e91f
* Adds SIGNAL_HANDLER and SIGNAL_HANDLER_DOES_SLEEP to prevent signal callbacks from blocking (#52761) Adds SIGNAL_HANDLER, a macro that sets SHOULD_NOT_SLEEP(TRUE). This should ideally be required on all new signal callbacks. Adds BLOCKING_SIGNAL_HANDLER, a macro that does nothing except symbolize "this is an older signal that didn't necessitate a code rewrite". It should not be allowed for new work. This comes from discussion around #52735, which yields by calling input, and (though it sets the return type beforehand) will not properly return the flag to prevent attack from slapping. To fix 60% of the yielding cases, WrapAdminProcCall no longer waits for another admin's proc call to finish. I'm not an admin, so I don't know how many behinds this has saved, but if this is problematic for admins I can just make it so that it lets you do it anyway. I'm not sure what the point of this babysitting was anyway. Requested by @optimumtact. Changelog cl admin: Calling a proc while another admin is calling one will no longer wait for the first to finish. You will simply just have to call it again. /cl * Adds SIGNAL_HANDLER and SIGNAL_HANDLER_DOES_SLEEP to prevent signal callbacks from blocking Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com>
34 lines
846 B
Plaintext
34 lines
846 B
Plaintext
//adds godmode while in the container, prevents moving, and clears these effects up after leaving the stone
|
|
/datum/component/soulstoned
|
|
var/atom/movable/container
|
|
|
|
/datum/component/soulstoned/Initialize(atom/movable/container)
|
|
if(!isanimal(parent))
|
|
return COMPONENT_INCOMPATIBLE
|
|
var/mob/living/simple_animal/S = parent
|
|
|
|
src.container = container
|
|
|
|
S.forceMove(container)
|
|
|
|
S.status_flags |= GODMODE
|
|
S.mobility_flags = NONE
|
|
S.health = S.maxHealth
|
|
S.bruteloss = 0
|
|
|
|
RegisterSignal(S, COMSIG_MOVABLE_MOVED, .proc/free_prisoner)
|
|
|
|
/datum/component/soulstoned/proc/free_prisoner()
|
|
SIGNAL_HANDLER
|
|
|
|
var/mob/living/simple_animal/S = parent
|
|
if(S.loc != container)
|
|
qdel(src)
|
|
|
|
/datum/component/soulstoned/UnregisterFromParent()
|
|
var/mob/living/simple_animal/S = parent
|
|
S.status_flags &= ~GODMODE
|
|
S.mobility_flags = MOBILITY_FLAGS_DEFAULT
|
|
|
|
|