mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-08-20 19:49:39 +01:00
e65a48e91f
* Adds SIGNAL_HANDLER and SIGNAL_HANDLER_DOES_SLEEP to prevent signal callbacks from blocking (#52761) Adds SIGNAL_HANDLER, a macro that sets SHOULD_NOT_SLEEP(TRUE). This should ideally be required on all new signal callbacks. Adds BLOCKING_SIGNAL_HANDLER, a macro that does nothing except symbolize "this is an older signal that didn't necessitate a code rewrite". It should not be allowed for new work. This comes from discussion around #52735, which yields by calling input, and (though it sets the return type beforehand) will not properly return the flag to prevent attack from slapping. To fix 60% of the yielding cases, WrapAdminProcCall no longer waits for another admin's proc call to finish. I'm not an admin, so I don't know how many behinds this has saved, but if this is problematic for admins I can just make it so that it lets you do it anyway. I'm not sure what the point of this babysitting was anyway. Requested by @optimumtact. Changelog cl admin: Calling a proc while another admin is calling one will no longer wait for the first to finish. You will simply just have to call it again. /cl * Adds SIGNAL_HANDLER and SIGNAL_HANDLER_DOES_SLEEP to prevent signal callbacks from blocking Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com>
30 lines
876 B
Plaintext
30 lines
876 B
Plaintext
/datum/element/waddling
|
|
|
|
/datum/element/waddling/Attach(datum/target)
|
|
. = ..()
|
|
if(!ismovable(target))
|
|
return ELEMENT_INCOMPATIBLE
|
|
if(isliving(target))
|
|
RegisterSignal(target, COMSIG_MOVABLE_MOVED, .proc/LivingWaddle)
|
|
else
|
|
RegisterSignal(target, COMSIG_MOVABLE_MOVED, .proc/Waddle)
|
|
|
|
/datum/element/waddling/Detach(datum/source, force)
|
|
. = ..()
|
|
UnregisterSignal(source, COMSIG_MOVABLE_MOVED)
|
|
|
|
/datum/element/waddling/proc/LivingWaddle(mob/living/target)
|
|
SIGNAL_HANDLER
|
|
|
|
if(target.incapacitated() || !(target.mobility_flags & MOBILITY_STAND))
|
|
return
|
|
Waddle(target)
|
|
|
|
/datum/element/waddling/proc/Waddle(atom/movable/target)
|
|
SIGNAL_HANDLER
|
|
|
|
animate(target, pixel_z = 4, time = 0)
|
|
var/prev_trans = matrix(target.transform)
|
|
animate(pixel_z = 0, transform = turn(target.transform, pick(-12, 0, 12)), time=2)
|
|
animate(pixel_z = 0, transform = prev_trans, time = 0)
|