Bubberstation

mirror of https://github.com/Bubberstation/Bubberstation.git synced 2025-12-11 10:11:09 +00:00

Files

Lucy 0c519008cb Master-overlayed screen alerts (i.e aura healing) now use appearance cloning instead of directly overlaying the master (#87281 )

## About The Pull Request

This reworks the `/mob/proc/throw_alert(new_master = ...)` to use
appearance cloning instead of just directly adding the master atom as an
overlay.

There's several advantages to this:
- We don't have to change anything about the original target at all
- Setting the plane/layer, adding the overlay, then resetting it to
before (as it does without this PR), feels like an awful hack ngl.
- We can ensure the target is always facing south, and has no pixel
x/y/z shift.

<details>
<summary><h3>Proof of testing / screenshots</h3></summary>

I had the healing rod holder standing on a table when the alert was
added, to ensure that the pixel_x/y/z reset worked.

![2024-10-17 (1729221218) ~
dreamseeker](https://github.com/user-attachments/assets/664abbef-d543-4d13-99ec-3264e05edfd8)
![2024-10-17 (1729221245) ~
dreamseeker](https://github.com/user-attachments/assets/6073dcd4-75e0-404a-bea1-6bea5fbd7591)

</details>

## Why It's Good For The Game

Ensures the aura healing alerts and such always look consistent - no
pixel offsets, always facing south, with more reliable code.

## Changelog
🆑
refactor: Refactored how some screen alerts, such as aura healing, show
atom overlays.
/🆑

2024-10-20 16:26:31 +02:00

hud

Master-overlayed screen alerts (i.e aura healing) now use appearance cloning instead of directly overlaying the master (#87281 )

2024-10-20 16:26:31 +02:00

adjacent.dm

Fix inventory item interactions sometimes being blocked due to not counting as adjacent when not on a turf (#85478 )

2024-08-14 13:43:10 +02:00

ai.dm

event based incapicated and able_to_run (#86031 )

2024-09-04 10:02:49 -04:00

click_alt.dm

Some alt & ctrl click improvements (#84203 )