mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-25 09:01:40 +00:00
About The Pull Request Alternative to #65354 Ok so like, there was a lot of not floor types on /floor. They didn't actually want any of their parent type's functionality, except maybe reacting to breaking (which was easy to move down) and some other minor stuff. Part of what we don't want them to have is "plateable" logic. I should not be able to put floor tiles on the snow and be fine. It's dumb. Instead, I've moved all non floor types down to a new type, called /misc. It holds very little logic. Mostly allowing pipes and wires and preventing blob stuff. It also supports lattice based construction, which is one of the major changes here. I think it makes more sense, and it fixes an assumption in shuttle code that assumed you couldn't place "a new tile" by just hitting some snow with a floor tile. Oh and lattices don't smooth with asteroid tiles anymore, this looks nicer I think. Moving on to commits, and minor changes Changes clf3 to try and burn any turfs it's exposed to, instead of just floors Moves break_tile down to the turf definition, alongside burn_tile If you're in basic buildmode and click on anything that's not handled in a targeted way, you just build plating FUNCTION CHANGE: you can't use cult pylons to convert misc tiles over anymore Generalizes building floors on top of something into two helper procs on /turf/open, reducing copypasta Adds a new turf flag, IS_SOLID, that describes if a turf is tangible or not. Uses this alongside a carpet and open check to replace plating and floor checks in carpet code. This does mean that non iron tiles can be carpeted, but I think that's fine Moves the /floor update_icon -> update_visuals call to /open This change is horrificly old, dating back to8e112f6but that commit describes nothing about why it was done. Choosing to believe it was a newfriend mistake. Uncomfortable nuking it though, because of just how old it is. Moving down instead Create a buildable "misc" type off open, moves /dirt onto it Basically, we want a type we can use to make something support construction, since that can be a messy bit of logic. Also enough structure to set things up sanely. I'm planning on moving most misc turfs onto it, if only because constructing on a dirt tile with rods should be possible, and the same applies to most things Murders captain planet, disentangles /turf/open/floor/grass/snow/basalt Adds a diggable component that applies the behavior of "digging" something out from a turf. Uses it to free the above pain typepath into something a bit more sensible The typepaths that aren't actually used by floor tiles are moved onto /misc The others are given names that better describe them, and kept in fancy_floor Oh and snowshoes don't work on basalt anymore, sorry Snowed over platings now actually have broken/burned icon states, fixing black holes to nowhere Misc turfs no longer smooth as floors, so lattices will ignore them Placing a lattice will no longer scrape the tile it's on Ok this is a really old one. I believe this logic is a holdover from kor's baseturf pr (97990c9) It used to be that turfs didn't have a concept of "beneath" and instead just decided what should be under them by induction. This logic of "if it's being latticed scapeaway to space" made sense then, but has since been somewhat distorted We do want to scape away on lattice spawn sometimes, mostly when we're being destroyed, but not always. We especially don't want to scape away if someone is just placing a rod, that's dumb. Adds a path updating script for this change I've done my best to find all the errors this repathing will pull out, but I may have missed some. I'm sorry. Why It's Good For The Game Very old code made better, more consistent turfs for lavaland and icebox, better visuals, minor fix to snowed plating, demon banishment in lattice placement, fixes the icebox mining shuttle not being repairable Changelog cl add: Rather then being tileable with just floor tiles, lavaland turfs, asteroid and snow (among other things) now support lattice -> floor tile construction fix: Because of the above, you can now properly fix the icebox mining shuttle refactor: Non floor turfs are no longer typed as floor. This may break things, please yell at me if it does /cl
by RemieRichards ////////////////////////////// // CODER INFORMATIVE README // ////////////////////////////// (See below for Mapper Friendly Readme) mapGenerator: Desc: a mapGenerator is a master datum that collects and syncs all mapGeneratorModules in it's modules list defineRegion(var/turf/Start, turf/End, replace = 0) Example: defineRegion(locate(1,1,1),locate(5,5,5),0) Desc: Sets the bounds of the mapGenerator's "map" defineCircularRegion(var/turf/Start, turf/End, replace = 0) Example: defineCircularRegion(locate(1,1,1),locate(5,5,5),0) Desc: Sets the mapGenerator's "map" as a circle, with center in the middle of Start and End's X,Y,Z coordinates undefineRegion() Example: undefineRegion() Desc: Empties the map generator list checkRegion(var/turf/Start, turf/End) Example: checkRegion(locate(1,1,1), locate(5,5,5)) Desc: Checks if a rectangle between Start's coords and End's coords is valid Existing Calls: mapGenerator/defineRegion(), mapGenerator/defineCircularRegion() generate() Example: generate() Desc: Orders all mapGeneratorModules in the modules list to generate() generateOneTurf(var/turf/T) Example: generateOneTurf(locate(1,1,1)) Desc: Orders all mapGeneratorModules in the modules list to place(T) on this turf initialiseModules() Example: initialiseModules() Desc: Replaces all typepaths in the modules list with actual /datum/map_generator/Module types Existing Calls: mapGenerator/New() syncModules() Example: syncModules() Desc: Sets the Mother variable on all mapGeneratorModules in the modules list to this mapGenerator Existing Calls: initialiseModules(),generate(),generateOneTurf() mapGeneratorModule Desc: a mapGeneratorModule has spawnableAtoms and spawnableTurfs lists which it will generate on turfs in it's mother's map based on cluster variables sync(var/datum/map_generator/mum) Example: sync(a_mapGenerator_as_a_variable) Desc: Sets the Mother variable to the mum argument Existing Calls: mapGenerator/syncModules() generate() Example: generate() Desc: Calls place(T) on all turfs in it's mother's map Existing Calls: mapGenerator/generate() place(var/turf/T) Example: place(locate(1,1,1)) Desc: Run this mapGeneratorModule's effects on this turf (Spawning atoms, Changing turfs) Existing Calls: mapGenerator/generate(), mapGenerator/generateOneTurf() checkPlaceAtom(var/turf/T) Example: checkPlace(locate(1,1,1)) Desc: Checks if the turf is valid for placing atoms Existing Calls: place() //////////////////////////// // MAPPER FRIENDLY README // //////////////////////////// Simple Workflow: 1. Define a/some mapGeneratorModule(s) to your liking, choosing atoms and turfs to spawn #Note: I chose to split Turfs and Atoms off into separate modules, but this is NOT required. #Note: A mapGeneratorModule may have turfs AND atoms, so long as each is in it's appropriate list 2. Define a mapGenerator type who's modules list contains the typepath(s) of all the module(s) you wish to use #Note: The order of the typepaths in the modules list is the order they will happen in, this is important for clusterCheckFlags. 3. Take notes of the Bottom Left and Top Right turfs of your rectangular "map"'s coordinates #Note: X,Y AND Z, Yes you can created 3D "maps" by having differing Z coords 4. Create the mapGenerator type you created 5. Call yourMapGeneratorType.defineRegion(locate(X,Y,Z), locate(X,Y,Z)) #Note: The above X/Y/Zs are the coordinates of the start and end turfs, the locate() simply finds the turf for the code 6. Call yourMapGeneratorType.generate(), this will cause all the modules in the generator to build within the map bounds Option Suggestions: * Have separate modules for Turfs and Atoms, this is not enforced, but it is how I have structured my nature example. * If your map doesn't look quite to your liking, simply jiggle with the variables on your modules and the type probabilities * You can mix and map premade areas with the procedural generation, for example mapping an entire flat land but having code generate just the grass tufts Using the Modules list Simply think of it like each module is a layer in a graphics editing program! To help you do this templates such as /mapGeneratorModule/bottomLayer have been provided with appropriate default settings. These are located near the bottom of mapGeneratorModule.dm you would order your list left to right, top to bottom, e.g: modules = list(bottomLayer,nextLayer,nextNextLayer) etc. Variable Breakdown (For Mappers): mapGenerator map - INTERNAL, do not touch modules - A list of typepaths of mapGeneratorModules mapGeneratorModule mother - INTERNAL, do not touch spawnableAtoms - A list of typepaths and their probability to spawn, eg: spawnableAtoms = list(/obj/structure/flora/tree/pine = 30) spawnableTurfs - A list of typepaths and their probability to spawn, eg: spawnableTurfs = list(/turf/unsimulated/floor/grass = 100) clusterMax - The max range to check for something being "too close" for this atom/turf to spawn, the true value is random between clusterMin and clusterMax clusterMin - The min range to check for something being "too close" for this atom/turf to spawn, the true value is random between clusterMin and clusterMax clusterCheckFlags - A Bitfield that controls how the cluster checks work, All based on clusterMin and clusterMax guides allowAtomsOnSpace - A Boolean for if we allow atoms to spawn on space tiles clusterCheckFlags flags: CLUSTER_CHECK_NONE 0 //No checks are done, cluster as much as possible CLUSTER_CHECK_DIFFERENT_TURFS 2 //Don't let turfs of DIFFERENT types cluster CLUSTER_CHECK_DIFFERENT_ATOMS 4 //Don't let atoms of DIFFERENT types cluster CLUSTER_CHECK_SAME_TURFS 8 //Don't let turfs of the SAME type cluster CLUSTER_CHECK_SAME_ATOMS 16 //Don't let atoms of the SAME type cluster CLUSTER_CHECK_SAMES 24 //Don't let any of the same type cluster CLUSTER_CHECK_DIFFERENTS 6 //Don't let any different types cluster CLUSTER_CHECK_ALL_TURFS 10 //Don't let ANY turfs cluster same and different types CLUSTER_CHECK_ALL_ATOMS 20 //Don't let ANY atoms cluster same and different types CLUSTER_CHECK_ALL 30 //Don't let anything cluster, like, at all