mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-07 23:42:44 +00:00
1e9baf3c7c
* Bot Code Improvement - Cleanbots (#69925) About The Pull Request Removes a ton of unused vars Replaces blood/trash/pests/drawn vars with flags Adds docs to most remaining vars Registers cleanbot's on_entered when they get deputized instead of on initialize, removing calling procs uselessly. Also makes the title only update when they get a new one, also removing useless proc calls. Reworks how updating titles work so it isn't copy pasting its own code. Cleanbot stealing names now check for the mind's assigned job, rather than the living's job. Replaces single letter vars in many areas Removes two places of checking what targets to scan for, makes use of the generalized scanning proc instead. Slightly reworks process_scan to return null Replaces cleanbot's cleaning time with a define replaces 'initial' weapon force with just initial(weapon.force) Why It's Good For The Game Continuing my past work that since I haven't done a bot code improvement PR in a pretty long while, I thought I would try to get back into this with cleanbots, which used to be one of the worst bots but I fixed some major problems in the past already, so it wasn't too bad. Changelog cl refactor: Cleanbots have been entirely reworked, please report any bugs you might find. /cl * Bot Code Improvement - Cleanbots Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>