mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-10 17:52:36 +00:00
1cf4aa84bc
## About The Pull Request That's really it. I had a bit of time to kill, so I've gone ahead and used a regular expression Ninja sent me (`var(/[^/\s]+)*/[^ijk\s]\s`) in order to detect some single-letter variable declarations, and dealt with them. Could I have done more of them? Yeah. But I didn't want to spend more time on it, just wanted to chip in even if just a bit. ## Why It's Good For The Game Single letter variables bad. ## Changelog 🆑 GoldenAlpharex code: Got rid of a few more single-letter variables. Only over six thousand left to go, woo! /🆑
51 lines
1.7 KiB
Plaintext
51 lines
1.7 KiB
Plaintext
#define pick_list(FILE, KEY) (pick(strings(FILE, KEY)))
|
|
#define pick_list_weighted(FILE, KEY) (pick_weight(strings(FILE, KEY)))
|
|
#define pick_list_replacements(FILE, KEY) (strings_replacement(FILE, KEY))
|
|
#define json_load(FILE) (json_decode(file2text(FILE)))
|
|
|
|
GLOBAL_LIST(string_cache)
|
|
GLOBAL_VAR(string_filename_current_key)
|
|
|
|
|
|
/proc/strings_replacement(filepath, key)
|
|
filepath = sanitize_filepath(filepath)
|
|
load_strings_file(filepath)
|
|
|
|
if((filepath in GLOB.string_cache) && (key in GLOB.string_cache[filepath]))
|
|
var/response = pick(GLOB.string_cache[filepath][key])
|
|
var/regex/needs_replacing = regex("@pick\\((\\D+?)\\)", "g")
|
|
response = needs_replacing.Replace(response, GLOBAL_PROC_REF(strings_subkey_lookup))
|
|
return response
|
|
else
|
|
CRASH("strings list not found: [STRING_DIRECTORY]/[filepath], index=[key]")
|
|
|
|
/proc/strings(filepath as text, key as text, directory = STRING_DIRECTORY)
|
|
if(IsAdminAdvancedProcCall())
|
|
return
|
|
|
|
filepath = sanitize_filepath(filepath)
|
|
load_strings_file(filepath, directory)
|
|
if((filepath in GLOB.string_cache) && (key in GLOB.string_cache[filepath]))
|
|
return GLOB.string_cache[filepath][key]
|
|
else
|
|
CRASH("strings list not found: [directory]/[filepath], index=[key]")
|
|
|
|
/proc/strings_subkey_lookup(match, group1)
|
|
return pick_list(GLOB.string_filename_current_key, group1)
|
|
|
|
/proc/load_strings_file(filepath, directory = STRING_DIRECTORY)
|
|
if(IsAdminAdvancedProcCall())
|
|
return
|
|
|
|
GLOB.string_filename_current_key = filepath
|
|
if(filepath in GLOB.string_cache)
|
|
return //no work to do
|
|
|
|
if(!GLOB.string_cache)
|
|
GLOB.string_cache = new
|
|
|
|
if(fexists("[directory]/[filepath]"))
|
|
GLOB.string_cache[filepath] = json_load("[directory]/[filepath]")
|
|
else
|
|
CRASH("file not found: [directory]/[filepath]")
|