mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-10 09:42:29 +00:00
8603a6ef99
## About The Pull Request ports https://github.com/DaedalusDock/daedalusdock/pull/1123 credit to kapu for the code, I just adapted some of it for us While testing this I noticed that some ambience sounds have no fades, so I added them, you can see comparisons here: <details> <summary> Click me for comparisons! </summary> https://github.com/user-attachments/assets/0a93ec2f-7600-4510-9773-e2c721f06613 https://github.com/user-attachments/assets/3328a097-5dbc-402f-9dee-ece5aa7f9479 https://github.com/user-attachments/assets/b94157d4-a8a6-4877-94f6-1f07dc6ba860 https://github.com/user-attachments/assets/dc326c0c-7c8c-46ab-8149-97fd02dcc7f7 https://github.com/user-attachments/assets/e3309d6f-6d8d-4595-8c88-172c406f577d https://github.com/user-attachments/assets/64109759-cbf6-446f-baf9-5705e1c81662 https://github.com/user-attachments/assets/28c0a112-a758-49d6-9f44-8e451a895d7a https://github.com/user-attachments/assets/fec33b2e-6704-4d97-9c73-d0e58fef52ef https://github.com/user-attachments/assets/4dc780bf-3fb4-402a-8803-7aef2968e012 https://github.com/user-attachments/assets/93d63a31-36aa-437f-95bc-840427155701 https://github.com/user-attachments/assets/59fd09d4-207d-4f7c-8355-34fb37981df4 https://github.com/user-attachments/assets/8c14e1e8-75be-4081-acac-d2cea05f8638 https://github.com/user-attachments/assets/3dac481c-62ea-4fd9-93c5-36f8cbbfab9b https://github.com/user-attachments/assets/c92dd2aa-93f8-4c2e-9e00-7dbef3146280 https://github.com/user-attachments/assets/02baae83-2e51-4d83-8d97-be15bc58c6c9 https://github.com/user-attachments/assets/fcd969ac-7f29-4bb4-873c-30874e13516e https://github.com/user-attachments/assets/24a053a3-1a71-4758-bb90-149ebc6b50b6 https://github.com/user-attachments/assets/40e7adee-d0bf-4636-b4d0-bc1c5c17688f </details> ## Why It's Good For The Game - sound caching will open possibilities for seamless sound loops and overall knowing the length of a sound file is very useful - closes https://github.com/tgstation/tgstation/issues/87054 - fade ins and fade outs prevent audio glitches on abrupt audio ends and are nicer for the ears ## Changelog 🆑 kapu and grungussuss fix: fixed ambience sounds getting cut off mid play sound: addes fades for maintenance ambiences refactor: changed the way maintenance sounds are /🆑 --------- Co-authored-by: Kapu1178 <75460809+Kapu1178@users.noreply.github.com>