Bubberstation

mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-01-30 19:11:52 +00:00

Files

Timberpoes 1b87da5122 Fixes multiple players being picked for the same single-slot command job roundstart. (#87005 )

## About The Pull Request

Fixes #86899

Assigning head positions doesn't use the `available_occupations` list
and instead just iterates through all command roles direct from some
department job helper, jumping over any that are at capacity.

This means the `available_occupations` list doesn't get updated when
head positions are assigned and can lead to an edge case where two
players can both get a single-slot job. The first player gets it via
`fill_all_head_positions_at_priority()`. The second player gets it via
being given a random role when any now-full head job doesn't get removed
from the `available_occupations` list.

There are many ways to fix this. The solution I've opted for is removing
command roles from the `available_occupations` list entirely, letting
`fill_all_head_positions_at_priority()` handle the logic for this
exclusively.
## Why It's Good For The Game

I feex.
## Changelog
🆑
fix: Fixes a bug where the game would assign multiple players to
single-slot command roles.
/🆑

2024-10-04 02:41:23 +02:00

configuration

Persistent Map Vote Tallies (#86788 )

2024-09-30 13:09:08 +13:00

subsystem

Fixes multiple players being picked for the same single-slot command job roundstart. (#87005 )

2024-10-04 02:41:23 +02:00

admin.dm

Admin Verb Datums MkIII | Now with functional command bar (#82511 )

2024-04-12 12:27:09 -07:00

controller.dm

…