mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-09 00:13:55 +00:00
18fe4b547e
* Stopgap fix for polymorphed headrevs counting towards a rev loss (#77636) ## About The Pull Request Revheads being a simplemob, basic mob, or xenomorph no longer count towards a rev loss. ## Why It's Good For The Game Strictly checking that a revhead is a human introduces several edge cases in which a revolution would be considered defeated, even if the last headrev is alive, on station, and able to eliminate command staff. Such cases include: - A promoted traitor getting the final objective that lets them turn into a dragon. - A promoted, ascended Flesh heretic. - A headrev getting brain transplanted into a xenomorph, especially a queen. - The Polymorphic Field Inverter. - Other crew-obtainable sources of polymorphing (ash drake/wendigo blood, colossus crystal, etc.) Heads of staff don't count towards a rev win in any of these cases, so it should be fair that revheads in these cases don't count towards a loss either. There are probably some more rigorous checks that should be done because the original intention of the strict humanity check for revheads probably had to do with being able to convert, but those seem a bit too complicated for now. Fixes #77634 ## Changelog 🆑 fix: Head Revolutionaries no longer count towards a revolution's defeat if they have become simplemobs, basic mobs, or xenomorphs. /🆑 * Stopgap fix for polymorphed headrevs counting towards a rev loss --------- Co-authored-by: Y0SH1M4S73R <legoboyo@earthlink.net>