cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-02-10 00:08:19 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
1b7316cb85917764cb7d8674c4bdcd69cda2bc86
Bubberstation/code/modules
History
SkyratBot ae2b3569c1 [MIRROR] Fixes a runtime with BotKeeper and observers [MDB IGNORE] (#18681) 
* Fixes a runtime with BotKeeper and observers (#72631)

## About The Pull Request

Viewing the botkeeper app on an open computer as an observer would cause
a runtime. check_access runtimes when passed something that isn't a
mob/living, so an observer who opens the UI would be passed into
check_access for every bot on station, causing runtimes.

![image](https://user-images.githubusercontent.com/28870487/211671642-7461229d-16e0-42c4-a64f-35f8d95a65c7.png)
## Why It's Good For The Game

This runtime fix was brought to you by
[https://runtimes.moth.fans/runtime/](https://runtimes.moth.fans/runtime)
## Changelog
🆑
fix: viewing the botkeeper app as an observer will no longer runtime.
/🆑

* Fixes a runtime with BotKeeper and observers

Co-authored-by: Rhials <Datguy33456@gmail.com>
2023-01-12 20:51:41 -08:00
..
actionspeed
…
admin
[MIRROR] Adds the Cursed quirk [MDB IGNORE] (#18492)
2023-01-12 15:21:21 -05:00
antagonists
Mirror #72195 (#18651)
2023-01-12 10:42:31 -05:00
art
[MIRROR] fixes chisels [MDB IGNORE] (#18662)
2023-01-12 12:19:46 -08:00
assembly
Mirror #72280 (#18648)
2023-01-12 08:48:06 -05:00
asset_cache
[MIRROR] RTD Rapid Tiling Device [MDB IGNORE] (#18546)
2023-01-12 22:15:08 +00:00
atmospherics
Mirror #72280 (#18648)
2023-01-12 08:48:06 -05:00
autowiki
…
awaymissions
[MIRROR] Optimizes explosions (very slightly) [MDB IGNORE] (#18624)
2023-01-10 12:34:26 -08:00
balloon_alert
…
buildmode
…
capture_the_flag
[MIRROR] Refactors armor into dedicated subtypes [MDB IGNORE] (#18291)
2023-01-07 20:06:16 -08:00
cards
…
cargo
[MIRROR] Adds the Cursed quirk [MDB IGNORE] (#18492)
2023-01-12 15:21:21 -05:00
chatter
…
client
[MIRROR] Preference support for Guests [MDB IGNORE] (#18505)
2023-01-11 07:46:45 -08:00
clothing
[MIRROR] Experiment with holding hard references to objects being qdeleted in 515 (saves 1.1+ seconds on init times, more on prod) [MDB IGNORE] (#18361)
2023-01-12 16:16:33 -05:00
detectivework
[MIRROR] afterattack now returns a flag if it's reasonable to suspect the user intends to act on an item [MDB IGNORE] (#18519)
2023-01-07 06:55:38 +00:00
discord
…
economy
[MIRROR] Refactors armor into dedicated subtypes [MDB IGNORE] (#18291)
2023-01-07 20:06:16 -08:00
emoji
…
error_handler
…
events
[MIRROR] Adds an announce_to_ghosts for the Scrubber Clog event [MDB IGNORE] (#18678)
2023-01-12 20:51:12 -08:00
experisci
[MIRROR] Basic Mob Carp Part VIII: Basic Mob Carp [MDB IGNORE] (#18344)
2023-01-09 05:48:50 -05:00
explorer_drone
[MIRROR] afterattack now returns a flag if it's reasonable to suspect the user intends to act on an item [MDB IGNORE] (#18519)
2023-01-07 06:55:38 +00:00
fishing
[MIRROR] Crafting/Cooking menu update [MDB IGNORE] (#18334)
2023-01-08 15:02:18 -05:00
flufftext
…
food_and_drinks
[MIRROR] Adds the Cursed quirk [MDB IGNORE] (#18492)
2023-01-12 15:21:21 -05:00
forensics
…
hallucination
[MIRROR] Converts drowsy and eye blur to status effects, striking yet another two carbon level status vars [MDB IGNORE] (#18348)
2023-01-09 13:14:47 -05:00
holiday
…
holodeck
[MANUAL MIRROR] Abstract away stuff that acts on baseturfs directly into their own procs, and kills some dead code related to baseturfs + tests (#72117) (#18655)
2023-01-12 12:18:28 -08:00
hydroponics
MIrror #72127 (#18652)
2023-01-12 10:04:20 -05:00
industrial_lift
[MIRROR] Fix JSON description for solo bench and tram [NO GBP] [MDB IGNORE] (#18661)
2023-01-12 13:58:59 -08:00
instruments
[MIRROR] [ready] unit tests all worn icons [MDB IGNORE] (#18491)
2023-01-09 21:10:28 -05:00
interview
[MANUAL MIRROR] Refactor /ui_state/new_player_state to what it's designed for (#71959) (#18610)
2023-01-09 10:12:22 -08:00
jobs
[MIRROR] Completely Culls req_access_txt/req_one_access_txt [MDB IGNORE] (#18458)
2023-01-12 11:43:52 -05:00
keybindings
…
language
[MIRROR] Refactors how tongue languages are set [MDB IGNORE] (#18362)
2023-01-12 12:27:47 -05:00
library
[MIRROR] Refactors armor into dedicated subtypes [MDB IGNORE] (#18291)
2023-01-07 20:06:16 -08:00
lighting
…
mafia
[MIRROR] Fixes HOS Beret (and all of its subtypes) having wrong path and thus not being armored [MDB IGNORE] (#18191)
2023-01-06 23:22:43 -05:00
mapfluff
[MIRROR] Optimizes explosions (very slightly) [MDB IGNORE] (#18624)
2023-01-10 12:34:26 -08:00
mapping
[MANUAL MIRROR] Abstract away stuff that acts on baseturfs directly into their own procs, and kills some dead code related to baseturfs + tests (#72117) (#18655)
2023-01-12 12:18:28 -08:00
meteors
[MIRROR] Basic Mob Carp Part VIII: Basic Mob Carp [MDB IGNORE] (#18344)
2023-01-09 05:48:50 -05:00
mining
Mirror #72280 (#18648)
2023-01-12 08:48:06 -05:00
mob
[MIRROR] Fixes a runtime with BotKeeper and observers [MDB IGNORE] (#18681)
2023-01-12 20:51:41 -08:00
mob_spawn
Mirror #72345 (#18649)
2023-01-12 08:53:45 -05:00
mod
Mirror #72280 (#18648)
2023-01-12 08:48:06 -05:00
modular_computers
[MIRROR] Minor improvements to mining order console [MDB IGNORE] (#18467)
2023-01-12 13:40:14 -05:00
movespeed
…
ninja
[MIRROR] Crafting/Cooking menu update [MDB IGNORE] (#18334)
2023-01-08 15:02:18 -05:00
NTNet
…
pai
[MIRROR] Experiment with holding hard references to objects being qdeleted in 515 (saves 1.1+ seconds on init times, more on prod) [MDB IGNORE] (#18361)
2023-01-12 16:16:33 -05:00
paperwork
[MIRROR] Converts drowsy and eye blur to status effects, striking yet another two carbon level status vars [MDB IGNORE] (#18348)
2023-01-09 13:14:47 -05:00
photography
[MIRROR] afterattack now returns a flag if it's reasonable to suspect the user intends to act on an item [MDB IGNORE] (#18519)
2023-01-07 06:55:38 +00:00
plumbing
…
point
…
power
Mirror #72280 (#18648)
2023-01-12 08:48:06 -05:00
procedural_mapping
[MIRROR] Turned most syndicate mobs (+ viscerators) into basicmobs [MDB IGNORE] (#18270)
2023-01-07 02:48:07 -05:00
projectiles
[MIRROR] Experiment with holding hard references to objects being qdeleted in 515 (saves 1.1+ seconds on init times, more on prod) [MDB IGNORE] (#18361)
2023-01-12 16:16:33 -05:00
reagents
[MIRROR] Converts drowsy and eye blur to status effects, striking yet another two carbon level status vars [MDB IGNORE] (#18348)
2023-01-09 13:14:47 -05:00
recycling
[MIRROR] [ready] unit tests all worn icons [MDB IGNORE] (#18491)
2023-01-09 21:10:28 -05:00
religion
[MIRROR] Adds the Cursed quirk [MDB IGNORE] (#18492)
2023-01-12 15:21:21 -05:00
requests
…
research
[MIRROR] RTD Rapid Tiling Device [MDB IGNORE] (#18546)
2023-01-12 22:15:08 +00:00
security_levels
…
shuttle
[MANUAL MIRROR] Abstract away stuff that acts on baseturfs directly into their own procs, and kills some dead code related to baseturfs + tests (#72117) (#18655)
2023-01-12 12:18:28 -08:00
spatial_grid
…
spells
[MIRROR] Converts drowsy and eye blur to status effects, striking yet another two carbon level status vars [MDB IGNORE] (#18348)
2023-01-09 13:14:47 -05:00
station_goals
…
surgery
[MIRROR] Adds surgery for fixing ears/hearing. [MDB IGNORE] (#18657)
2023-01-12 12:14:05 -08:00
tgchat
…
tgs
…
tgui
[MANUAL MIRROR] Refactor /ui_state/new_player_state to what it's designed for (#71959) (#18610)
2023-01-09 10:12:22 -08:00
tgui_input
…
tgui_panel
…
tooltip
…
tutorials
[MIRROR] Contextual tutorials for swapping hands and dropping items [MDB IGNORE] (#18604)
2023-01-10 14:26:08 +01:00
unit_tests
[MANUAL MIRROR] Abstract away stuff that acts on baseturfs directly into their own procs, and kills some dead code related to baseturfs + tests (#72117) (#18655)
2023-01-12 12:18:28 -08:00
uplink
holopara qol update (#72042) (#18438)
2023-01-09 05:39:54 -05:00
vehicles
[MIRROR] fixes silly stuff about basic mobs [MDB IGNORE] (#18368)
2023-01-09 06:00:48 -05:00
vending
[MIRROR] Completely Culls req_access_txt/req_one_access_txt [MDB IGNORE] (#18458)
2023-01-12 11:43:52 -05:00
wiremod
[MIRROR] Completely Culls req_access_txt/req_one_access_txt [MDB IGNORE] (#18458)
2023-01-12 11:43:52 -05:00
zombie
[MIRROR] afterattack now returns a flag if it's reasonable to suspect the user intends to act on an item [MDB IGNORE] (#18519)
2023-01-07 06:55:38 +00:00