mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-10 08:54:15 +00:00
23bfdec8f4
About The Pull Request I've reworked multiz. This was done because our current implementation of multiz flattens planes down into just the openspace plane. This breaks any effects we attach to plane masters (including lighting), but it also totally kills the SIDE_MAP map format, which we NEED for wallening (A major 3/4ths resprite of all wall and wall adjacent things, making them more then one tile high. Without sidemap we would be unable to display things both in from of and behind objects on map. Stupid.) This required MASSIVE changes. Both to all uses of the plane var for reasons I'll discuss later, and to a ton of different systems that interact with rendering. I'll do my best to keep this compact, but there's only so much I can do. Sorry brother. Core idea OK: first thing. vis_contents as it works now squishes the planes of everything inside it down into the plane of the vis_loc. This is bad. But how to do better? It's trivially easy to make copies of our existing plane masters but offset, and relay them to the bottom of the plane above. Not a problem. The issue is how to get the actual atoms on the map to "land" on them properly. We could use FLOAT_PLANE to offset planes based off how they're being seen, in theory this would allow us to create lens for how objects are viewed. But that's not a stable thing to do, because properly "landing" a plane on a desired plane master would require taking into account every bit of how it's being seen, would inherently break this effect. Ok so we need to manually edit planes based off "z layer" (IE: what layer of a z stack are you on). That's the key conceit of this pr. Implementing the plane cube, and ensuring planes are always offset properly. Everything else is just gravy. About the Plane Cube Each plane master (except ones that opt out) is copied down by some constant value equal to the max absolute change between the first and the last plane. We do this based off the max z stack size detected by SSmapping. This is also where updates come from, and where all our updating logic will live. As mentioned, plane masters can choose to opt out of being mirrored down. In this case, anything that interacts with them assuming that they'll be offset will instead just get back the valid plane value. This works for render targets too, since I had to work them into the system as well. Plane masters can also be temporarily hidden from the client's screen. This is done as an attempt at optimization, and applies to anything used in niche cases, or planes only used if there's a z layer below you. About Plane Master Groups BYOND supports having different "maps" on screen at once (IE: groups of items/turfs/etc) Plane masters cannot cover 2 maps at once, since their location is determined by their screen_loc. So we need to maintain a mirror of each plane for every map we have open. This was quite messy, so I've refactored it (and maps too) to be a bit more modular. Rather then storing a list of plane masters, we store a list of plane master group datums. Each datum is in charge of the plane masters for its particular map, both creating them, and managing them. Like I mentioned, I also refactored map views. Adding a new mapview is now as simple as newing a /atom/movable/screen/map_view, calling generate_view with the appropriate map id, setting things you want to display in its vis_contents, and then calling display_to on it, passing in the mob to show ourselves to. Much better then the hardcoded pattern we used to use. So much duplicated code man. Oh and plane master controllers, that system we have that allows for applying filters to sets of plane masters? I've made it use lookups on plane master groups now, rather then hanging references to all impacted planes. This makes logic easier, and prevents the need to manage references and update the controllers. image In addition, I've added a debug ui for plane masters. It allows you to view all of your own plane masters and short descriptions of what they do, alongside tools for editing them and their relays. It ALSO supports editing someone elses plane masters, AND it supports (in a very fragile and incomplete manner) viewing literally through someone else's eyes, including their plane masters. This is very useful, because it means you can debug "hey my X is yorked" issues yourself, on live. In order to accomplish this I have needed to add setters for an ungodly amount of visual impacting vars. Sight flags, eye, see_invis, see_in_dark, etc. It also comes with an info dump about the ui, and plane masters/relays in general. Sort of on that note. I've documented everything I know that's niche/useful about our visual effects and rendering system. My hope is this will serve to bring people up to speed on what can be done more quickly, alongside making my sin here less horrible. See https://github.com/LemonInTheDark/tgstation/blob/multiz-hell/.github/guides/VISUALS.md. "Landing" planes Ok so I've explained the backend, but how do we actually land planes properly? Most of the time this is really simple. When a plane var is set, we need to provide some spokesperson for the appearance's z level. We can use this to derive their z layer, and thus what offset to use. This is just a lot of gruntwork, but it's occasionally more complex. Sometimes we need to cache a list of z layer -> effect, and then use that. Also a LOT of updating on z move. So much z move shit. Oh. and in order to make byond darkness work properly, I needed to add SEE_BLACKNESS to all sight flags. This draws darkness to plane 0, which means I'm able to relay it around and draw it on different z layers as is possible. fun darkness ripple effects incoming someday I also need to update mob overlays on move. I do this by realiizing their appearances, mutating their plane, and then readding the overlay in the correct order. The cost of this is currently 3N. I'm convinced this could be improved, but I've not got to it yet. It can also occasionally cause overlays to corrupt. This is fixed by laying a protective ward of overlays.Copy in the sand, but that spell makes the compiler confused, so I'll have to bully lummy about fixing it at some point. Behavior changes We've had to give up on the already broken gateway "see through" effect. Won't work without managing gateway plane masters or something stupid. Not worth it. So instead we display the other side as a ui element. It's worse, but not that bad. Because vis_contents no longer flattens planes (most of the time), some uses of it now have interesting behavior. The main thing that comes to mind is alert popups that display mobs. They can impact the lighting plane. I don't really care, but it should be fixable, I think, given elbow grease. Ah and I've cleaned up layers and plane defines to make them a bit easier to read/reason about, at least I think. Why It's Good For The Game <visual candy> Fixes #65800 Fixes #68461 Changelog cl refactor: Refactored... well a lot really. Map views, anything to do with planes, multiz, a shit ton of rendering stuff. Basically if you see anything off visually report it admin: VV a mob, and hit View/Edit Planes in the dropdown to steal their view, and modify it as you like. You can do the same to yourself using the Edit/Debug Planes verb /cl
60 lines
2.2 KiB
Plaintext
60 lines
2.2 KiB
Plaintext
#define SEE_INVISIBLE_MINIMUM 5
|
|
|
|
#define INVISIBILITY_LIGHTING 20
|
|
|
|
#define SEE_INVISIBLE_LIVING 25
|
|
|
|
//#define SEE_INVISIBLE_LEVEL_ONE 35 //currently unused
|
|
//#define INVISIBILITY_LEVEL_ONE 35 //currently unused
|
|
|
|
//#define SEE_INVISIBLE_LEVEL_TWO 45 //currently unused
|
|
//#define INVISIBILITY_LEVEL_TWO 45 //currently unused
|
|
|
|
#define INVISIBILITY_REVENANT 50
|
|
|
|
#define INVISIBILITY_OBSERVER 60
|
|
#define SEE_INVISIBLE_OBSERVER 60
|
|
|
|
#define INVISIBILITY_MAXIMUM 100 //the maximum allowed for "real" objects
|
|
|
|
#define INVISIBILITY_ABSTRACT 101 //only used for abstract objects (e.g. spacevine_controller), things that are not really there.
|
|
|
|
#define BORGMESON (1<<0)
|
|
#define BORGTHERM (1<<1)
|
|
#define BORGXRAY (1<<2)
|
|
#define BORGMATERIAL (1<<3)
|
|
|
|
//for clothing visor toggles, these determine which vars to toggle
|
|
#define VISOR_FLASHPROTECT (1<<0)
|
|
#define VISOR_TINT (1<<1)
|
|
#define VISOR_VISIONFLAGS (1<<2) //all following flags only matter for glasses
|
|
#define VISOR_DARKNESSVIEW (1<<3)
|
|
#define VISOR_INVISVIEW (1<<4)
|
|
|
|
// BYOND internal values for the sight flags
|
|
// See [https://www.byond.com/docs/ref/#/mob/var/sight]
|
|
/// can't see anything
|
|
//#define BLIND (1<<0)
|
|
/// can see all mobs, no matter what
|
|
//#define SEE_MOBS (1<<2)
|
|
/// can see all objs, no matter what
|
|
//#define SEE_OBJS (1<<3)
|
|
// can see all turfs (and areas), no matter what
|
|
//#define SEE_TURFS (1<<4)
|
|
/// can see self, no matter what
|
|
//#define SEE_SELF (1<<5)
|
|
/// can see infra-red objects (different sort of luminosity, essentially a copy of it, one we do not use)
|
|
//#define SEE_INFRA (1<<6)
|
|
/// if an object is located on an unlit area, but some of its pixels are
|
|
/// in a lit area (via pixel_x,y or smooth movement), can see those pixels
|
|
//#define SEE_PIXELS (1<<8)
|
|
/// can see through opaque objects
|
|
//#define SEE_THRU (1<<9)
|
|
/// render dark tiles as blackness (Note, this basically means we draw dark tiles to plane 0)
|
|
/// we can then hijack that plane with a plane master, and start drawing it anywhere we want
|
|
//#define SEE_BLACKNESS (1<<10)
|
|
|
|
/// Bitfield of sight flags that show things "inside" the blackness plane
|
|
/// We've gotta alpha it down if we get this, cause otherwise the sight flag won't work
|
|
#define BLACKNESS_CUTTING (SEE_MOBS|SEE_OBJS|SEE_TURFS|SEE_TURFS|SEE_TURFS)
|