mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-13 11:12:14 +00:00
Ladies, Gentlemen, Gamers. You're probably wondering why I've called you all here (through the automatic reviewer request system). So, mineral balance! Mineral balance is less a balance and more of a nervous white dude juggling spinning plates on a high-wire on his first day. The fact it hasn't failed after going on this long is a miracle in and of itself. This PR does not change mineral balance. What this does is moves over every individual cost, both in crafting recipes attached to an object over to a define based system. We have 3 defines: `sheet_material_amount=2000` . Stock standard mineral sheet. This being our central mineral unit, this is used for all costs 2000+. `half_sheet_material_amount=1000` . Same as above, but using iron rods as our inbetween for costs of 1000-1999. `small_material_amount=100` . This hits 1-999. This covers... a startlingly large amount of the codebase. It's feast or famine out here in terms of mineral costs as a result, items are either sheets upon sheets, or some fraction of small mats. Shout out to riot darts for being the worst material cost in the game. I will not elaborate. Regardless, this has no functional change, but it sets the groundwork for making future changes to material costs much, MUCH easier, and moves over to a single, standardized set of units to help enforce coding standards on new items, and will bring up lots of uncomfortable balance questions down the line. For now though, this serves as some rough boundaries on how items costs are related, and will make adjusting these values easier going forward. Except for foam darts. I did round up foam darts. Adjusting mineral balance on the macro scale will be as simple as changing the aforementioned mineral defines, where the alternative is a rats nest of magic number defines. ~~No seriously, 11.25 iron for a foam dart are you kidding me what is the POINT WHY NOT JUST MAKE IT 11~~ Items individual numbers have not been adjusted yet, but we can standardize how the conversation can be held and actually GET SOMEWHERE on material balance as opposed to throwing our hands up or ignoring it for another 10 years.
174 lines
5.2 KiB
Plaintext
174 lines
5.2 KiB
Plaintext
|
|
/obj/item/assembly
|
|
name = "assembly"
|
|
desc = "A small electronic device that should never exist."
|
|
icon = 'icons/obj/assemblies/new_assemblies.dmi'
|
|
icon_state = ""
|
|
flags_1 = CONDUCT_1
|
|
w_class = WEIGHT_CLASS_SMALL
|
|
custom_materials = list(/datum/material/iron=SMALL_MATERIAL_AMOUNT)
|
|
throwforce = 2
|
|
throw_speed = 3
|
|
throw_range = 7
|
|
drop_sound = 'sound/items/handling/component_drop.ogg'
|
|
pickup_sound = 'sound/items/handling/component_pickup.ogg'
|
|
|
|
/**
|
|
* Set to true if the device has different icons for each position.
|
|
* This will prevent things such as visible lasers from facing the incorrect direction when transformed by assembly_holder's update_appearance()
|
|
*/
|
|
var/is_position_sensitive = FALSE
|
|
/// Flags related to this assembly. See [assemblies.dm]
|
|
var/assembly_flags = NONE
|
|
var/secured = TRUE
|
|
var/list/attached_overlays = null
|
|
var/obj/item/assembly_holder/holder = null
|
|
var/attachable = FALSE // can this be attached to wires
|
|
var/datum/wires/connected = null
|
|
var/next_activate = 0 //When we're next allowed to activate - for spam control
|
|
|
|
/obj/item/assembly/Destroy()
|
|
holder = null
|
|
return ..()
|
|
|
|
/obj/item/assembly/get_part_rating()
|
|
return 1
|
|
|
|
/**
|
|
* on_attach: Called when attached to a holder, wiring datum, or other special assembly
|
|
*
|
|
* Will also be called if the assembly holder is attached to a plasma (internals) tank or welding fuel (dispenser) tank.
|
|
*/
|
|
/obj/item/assembly/proc/on_attach()
|
|
if(!holder && connected)
|
|
holder = connected.holder
|
|
|
|
/**
|
|
* on_detach: Called when removed from an assembly holder or wiring datum
|
|
*/
|
|
/obj/item/assembly/proc/on_detach()
|
|
if(connected)
|
|
connected = null
|
|
if(!holder)
|
|
return FALSE
|
|
forceMove(holder.drop_location())
|
|
holder = null
|
|
return TRUE
|
|
|
|
/**
|
|
* holder_movement: Called when the assembly's holder detects movement
|
|
*/
|
|
/obj/item/assembly/proc/holder_movement()
|
|
if(!holder)
|
|
return FALSE
|
|
setDir(holder.dir)
|
|
return TRUE
|
|
|
|
/obj/item/assembly/proc/is_secured(mob/user)
|
|
if(!secured)
|
|
to_chat(user, span_warning("The [name] is unsecured!"))
|
|
return FALSE
|
|
return TRUE
|
|
|
|
/**
|
|
* Pulsed: This device was pulsed by another device
|
|
*
|
|
* * pulser: Who triggered the pulse
|
|
*/
|
|
/obj/item/assembly/proc/pulsed(mob/pulser)
|
|
INVOKE_ASYNC(src, PROC_REF(activate), pulser)
|
|
SEND_SIGNAL(src, COMSIG_ASSEMBLY_PULSED)
|
|
return TRUE
|
|
|
|
/**
|
|
* Pulse: This device is emitting a pulse to act on another device
|
|
*/
|
|
/obj/item/assembly/proc/pulse()
|
|
// if we have connected wires and are a pulsing assembly, pulse it
|
|
if(connected)
|
|
connected.pulse_assembly(src)
|
|
// otherwise if we're attached to a holder, process the activation of it with our flags
|
|
else if(holder)
|
|
holder.process_activation(src)
|
|
return TRUE
|
|
|
|
/// What the device does when turned on
|
|
/obj/item/assembly/proc/activate(mob/activator)
|
|
if(QDELETED(src) || !secured || (next_activate > world.time))
|
|
return FALSE
|
|
next_activate = world.time + 30
|
|
return TRUE
|
|
|
|
/obj/item/assembly/proc/toggle_secure()
|
|
secured = !secured
|
|
update_appearance()
|
|
return secured
|
|
|
|
// This is overwritten so that clumsy people can set off mousetraps even when in a holder.
|
|
// We are not going deeper than that however (won't set off if in a tank bomb or anything with wires)
|
|
// That would need to be added to all parent objects, or a signal created, whatever.
|
|
// Anyway this return check prevents you from picking up every assembly inside the holder at once.
|
|
/obj/item/assembly/attack_hand(mob/living/user, list/modifiers)
|
|
if(holder || connected)
|
|
return
|
|
. = ..()
|
|
|
|
/obj/item/assembly/attackby(obj/item/attacking_item, mob/user, params)
|
|
if(isassembly(attacking_item))
|
|
var/obj/item/assembly/new_assembly = attacking_item
|
|
// Check both our's and their's assembly flags to see if either should not duplicate
|
|
// If so, and we match types, don't create a holder - block it
|
|
if(((new_assembly.assembly_flags|assembly_flags) & ASSEMBLY_NO_DUPLICATES) && istype(new_assembly, type))
|
|
balloon_alert(user, "can't attach another of that!")
|
|
return
|
|
if(new_assembly.secured || secured)
|
|
balloon_alert(user, "both devices not attachable!")
|
|
return
|
|
|
|
holder = new /obj/item/assembly_holder(drop_location())
|
|
holder.assemble(src, new_assembly, user)
|
|
holder.balloon_alert(user, "parts combined")
|
|
return
|
|
|
|
if(istype(attacking_item, /obj/item/assembly_holder))
|
|
var/obj/item/assembly_holder/added_to_holder = attacking_item
|
|
added_to_holder.try_add_assembly(src, user)
|
|
return
|
|
|
|
return ..()
|
|
|
|
/obj/item/assembly/screwdriver_act(mob/living/user, obj/item/I)
|
|
if(..())
|
|
return TRUE
|
|
if(toggle_secure())
|
|
to_chat(user, span_notice("\The [src] is ready!"))
|
|
else
|
|
to_chat(user, span_notice("\The [src] can now be attached!"))
|
|
add_fingerprint(user)
|
|
return TRUE
|
|
|
|
/obj/item/assembly/examine(mob/user)
|
|
. = ..()
|
|
. += span_notice("\The [src] [secured? "is secured and ready to be used!" : "can be attached to other things."]")
|
|
|
|
/obj/item/assembly/attack_self(mob/user)
|
|
if(!user)
|
|
return FALSE
|
|
user.set_machine(src)
|
|
interact(user)
|
|
return TRUE
|
|
|
|
/obj/item/assembly/interact(mob/user)
|
|
return ui_interact(user)
|
|
|
|
/obj/item/assembly/ui_host(mob/user)
|
|
// In order, return:
|
|
// - The conencted wiring datum's owner, or
|
|
// - The thing your assembly holder is attached to, or
|
|
// - the assembly holder itself, or
|
|
// - us
|
|
return connected?.holder || holder?.master || holder || src
|
|
|
|
/obj/item/assembly/ui_state(mob/user)
|
|
return GLOB.hands_state
|