mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-09 16:05:07 +00:00
1f3894e793
My original plan was to just implement materials into crafting so that items would inherit the materials of their components, allowing for some interesting stuff if the material flags of the item allow it. However to my dismay crafting is a pile of old tech debt, starting from the old `del_reqs` and `CheckParts` which still contain lines about old janky bandaids that are no longer in use nor reachable, up to the `customizable_reagent_holder` component which has some harddel issues when your custom food is sliced, and items used in food recipes not being deleted and instead stored inside the result with no purpose as well as other inconsistencies like stack recipes that transfer materials having counterparts in the UI that don't do that. EDIT: Several things have come up while working on this, so I apologise that it ended up changing over 100+ files. I managed to atomize some of the changes, but it's a bit tedious. EDIT: TLDR because I was told this section is too vague and there's too much going on. This PR: - Improves the dated crafting code (not the UI). - replaced `atom/CheckParts` and `crafting_recipe/on_craft_completion` with `atom/on_craft_completion`. - Reqs used in food recipes are now deleted by default and not stored inside the result (they did nothing). - Renames the customizable_reagent_holder comp and improves it (No harddels/ref issues). - Adds a unit test that tries to craft all recipes to see what's wrong (it skips some of the much more specific reqs for now). - In the unit test is also the code to make sure materials of the crafted item and a non-crafted item of the same type are roughly the same, so far only applied to food. - Some mild material/food refactoring around the fact that food item code has been changed to support materials. Improving the backbone of the crafting system. Also materials and food code. 🆑 refactor: Refactored crafting backend. Report possible pesky bugs. balance: the MEAT backpack (from the MEAT cargo pack) may be a smidge different because of code standardization. /🆑
114 lines
5.7 KiB
Plaintext
114 lines
5.7 KiB
Plaintext
//Defines for amount of material retrieved from sheets & other items
|
|
/// The amount of materials you get from a sheet of mineral like iron/diamond/glass etc. 100 Units.
|
|
#define SHEET_MATERIAL_AMOUNT 100
|
|
/// The amount of materials you get from half a sheet. Used in standard object quantities. 50 units.
|
|
#define HALF_SHEET_MATERIAL_AMOUNT (SHEET_MATERIAL_AMOUNT / 2)
|
|
/// The amount of materials used in the smallest of objects, like pens and screwdrivers. 10 units.
|
|
#define SMALL_MATERIAL_AMOUNT (HALF_SHEET_MATERIAL_AMOUNT / 5)
|
|
/// The amount of material that goes into a coin, which determines the value of the coin.
|
|
#define COIN_MATERIAL_AMOUNT (HALF_SHEET_MATERIAL_AMOUNT * 0.4)
|
|
|
|
//Cable related values
|
|
/// The maximum size of a stack object.
|
|
#define MAX_STACK_SIZE 50
|
|
/// Maximum amount of cable in a coil
|
|
#define MAXCOIL 30
|
|
|
|
//Category of materials
|
|
/// Can this material be stored in the ore silo
|
|
#define MAT_CATEGORY_SILO "silo capable"
|
|
/// Hard materials, such as iron or silver
|
|
#define MAT_CATEGORY_RIGID "rigid material"
|
|
/// Materials that can be used to craft items
|
|
#define MAT_CATEGORY_ITEM_MATERIAL "item material"
|
|
/**
|
|
* Materials that can also be used to craft items for designs that require two custom mats.
|
|
* This is mainly a work around to the fact we can't (easily) have the same category show
|
|
* multiple times in a list with different values, because list access operator [] will fetch the
|
|
* top-most value.
|
|
*/
|
|
#define MAT_CATEGORY_ITEM_MATERIAL_COMPLEMENTARY "item material complementary"
|
|
|
|
/// Use this flag on TRUE if you want the basic recipes
|
|
#define MAT_CATEGORY_BASE_RECIPES "basic recipes"
|
|
|
|
///Flags for map loaded materials
|
|
/// Used to make a material initialize at roundstart.
|
|
#define MATERIAL_INIT_MAPLOAD (1<<0)
|
|
/// Used to make a material type able to be instantiated on demand after roundstart.
|
|
#define MATERIAL_INIT_BESPOKE (1<<1)
|
|
|
|
//Material Container Flags.
|
|
///If the container shows the amount of contained materials on examine.
|
|
#define MATCONTAINER_EXAMINE (1<<0)
|
|
///If the container cannot have materials inserted through attackby().
|
|
#define MATCONTAINER_NO_INSERT (1<<1)
|
|
///If the user can insert mats into the container despite the intent.
|
|
#define MATCONTAINER_ANY_INTENT (1<<2)
|
|
///If the user won't receive a warning when attacking the container with an unallowed item.
|
|
#define MATCONTAINER_SILENT (1<<3)
|
|
///Alloys won't be disassembled in its components when inserted.
|
|
#define MATCONTAINER_ACCEPT_ALLOYS (1<<4)
|
|
|
|
/// Whether a material's mechanical effects should apply to the atom. This is necessary for other flags to work.
|
|
#define MATERIAL_EFFECTS (1<<0)
|
|
/// Applies the material color to the atom's color. Deprecated, use MATERIAL_GREYSCALE instead
|
|
#define MATERIAL_COLOR (1<<1)
|
|
/// Whether a prefix describing the material should be added to the name
|
|
#define MATERIAL_ADD_PREFIX (1<<2)
|
|
/// Whether a material should affect the stats of the atom
|
|
#define MATERIAL_AFFECT_STATISTICS (1<<3)
|
|
/// Applies the material greyscale color to the atom's greyscale color.
|
|
#define MATERIAL_GREYSCALE (1<<4)
|
|
/// Materials like plasteel and alien alloy won't apply slowdowns.
|
|
#define MATERIAL_NO_SLOWDOWN (1<<5)
|
|
/**
|
|
* This item is not affected by the standard food-related effects of materials like meat and pizza.
|
|
* Necessary for the edible component counterparts, on_edible_applied() and on_edible_removed()
|
|
*/
|
|
#define MATERIAL_NO_EDIBILITY (1<<6)
|
|
|
|
//Special return values of [/datum/component/material_container/insert_item]
|
|
/// No material was found inside them item
|
|
#define MATERIAL_INSERT_ITEM_NO_MATS -1
|
|
/// The container does not have the space for the item
|
|
#define MATERIAL_INSERT_ITEM_NO_SPACE -2
|
|
/// The item material type was not accepted or other reasons
|
|
#define MATERIAL_INSERT_ITEM_FAILURE 0
|
|
|
|
|
|
// Slowdown values.
|
|
/// The slowdown value of one [SHEET_MATERIAL_AMOUNT] of plasteel.
|
|
#define MATERIAL_SLOWDOWN_PLASTEEL (0.05)
|
|
/// The slowdown value of one [SHEET_MATERIAL_AMOUNT] of alien alloy.
|
|
#define MATERIAL_SLOWDOWN_ALIEN_ALLOY (0.1)
|
|
|
|
//Stock market stock values.
|
|
/// How much quantity of a material stock exists for common materials like iron & glass.
|
|
#define MATERIAL_QUANTITY_COMMON 5000
|
|
/// How much quantity of a material stock exists for uncommon materials like silver & titanium.
|
|
#define MATERIAL_QUANTITY_UNCOMMON 1000
|
|
/// How much quantity of a material stock exists for rare materials like gold, uranium, & diamond.
|
|
#define MATERIAL_QUANTITY_RARE 200
|
|
/// How much quantity of a material stock exists for exotic materials like diamond & bluespace crystals.
|
|
#define MATERIAL_QUANTITY_EXOTIC 50
|
|
|
|
// The number of ore vents that will spawn boulders with this material.
|
|
/// Is this material going to spawn often in ore vents? (80% of vents on lavaland)
|
|
#define MATERIAL_RARITY_COMMON 12
|
|
/// Is this material going to spawn often in ore vents? (53% of vents on lavaland)
|
|
#define MATERIAL_RARITY_SEMIPRECIOUS 8
|
|
/// Is this material going to spawn uncommonly in ore vents? (33% of vents on lavaland)
|
|
#define MATERIAL_RARITY_PRECIOUS 5
|
|
/// Is this material going to spawn rarely in ore vents? (20% of vents on lavaland)
|
|
#define MATERIAL_RARITY_RARE 3
|
|
/// Is this material only going to spawn once in ore vents? (6% of vents on lavaland)
|
|
#define MATERIAL_RARITY_UNDISCOVERED 1
|
|
|
|
///The key to access the 'optimal' amount of a material key from its assoc value list.
|
|
#define MATERIAL_LIST_OPTIMAL_AMOUNT "optimal_amount"
|
|
///The key to access the multiplier used to selectively control effects and modifiers of a material.
|
|
#define MATERIAL_LIST_MULTIPLIER "multiplier"
|
|
///A macro that ensures some multiplicative modifiers higher than 1 don't become lower than 1 and vice-versa because of the multiplier.
|
|
#define GET_MATERIAL_MODIFIER(modifier, multiplier) (modifier >= 1 ? 1 + ((modifier) - 1) * (multiplier) : (modifier)**(multiplier))
|