mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-09 16:05:07 +00:00
1f3894e793
My original plan was to just implement materials into crafting so that items would inherit the materials of their components, allowing for some interesting stuff if the material flags of the item allow it. However to my dismay crafting is a pile of old tech debt, starting from the old `del_reqs` and `CheckParts` which still contain lines about old janky bandaids that are no longer in use nor reachable, up to the `customizable_reagent_holder` component which has some harddel issues when your custom food is sliced, and items used in food recipes not being deleted and instead stored inside the result with no purpose as well as other inconsistencies like stack recipes that transfer materials having counterparts in the UI that don't do that. EDIT: Several things have come up while working on this, so I apologise that it ended up changing over 100+ files. I managed to atomize some of the changes, but it's a bit tedious. EDIT: TLDR because I was told this section is too vague and there's too much going on. This PR: - Improves the dated crafting code (not the UI). - replaced `atom/CheckParts` and `crafting_recipe/on_craft_completion` with `atom/on_craft_completion`. - Reqs used in food recipes are now deleted by default and not stored inside the result (they did nothing). - Renames the customizable_reagent_holder comp and improves it (No harddels/ref issues). - Adds a unit test that tries to craft all recipes to see what's wrong (it skips some of the much more specific reqs for now). - In the unit test is also the code to make sure materials of the crafted item and a non-crafted item of the same type are roughly the same, so far only applied to food. - Some mild material/food refactoring around the fact that food item code has been changed to support materials. Improving the backbone of the crafting system. Also materials and food code. 🆑 refactor: Refactored crafting backend. Report possible pesky bugs. balance: the MEAT backpack (from the MEAT cargo pack) may be a smidge different because of code standardization. /🆑
92 lines
4.2 KiB
Plaintext
92 lines
4.2 KiB
Plaintext
/// Return this from `/datum/component/Initialize` or `/datum/component/OnTransfer` or `/datum/component/on_source_add` to have the component be deleted if it's applied to an incorrect type.
|
|
/// `parent` must not be modified if this is to be returned.
|
|
/// This will be noted in the runtime logs
|
|
#define COMPONENT_INCOMPATIBLE 1
|
|
/// Returned in PostTransfer to prevent transfer, similar to `COMPONENT_INCOMPATIBLE`
|
|
#define COMPONENT_NOTRANSFER 2
|
|
/// Deletes the component silently. This is for valid, non-error cases where you still want to execute some of the component's logic.
|
|
#define COMPONENT_REDUNDANT 3
|
|
|
|
/// Return value to cancel attaching
|
|
#define ELEMENT_INCOMPATIBLE 1
|
|
|
|
// /datum/element flags
|
|
/// Causes the detach proc to be called when the host object is being deleted.
|
|
/// Should only be used if you need to perform cleanup not related to the host object.
|
|
/// You do not need this if you are only unregistering signals, for instance.
|
|
/// You would need it if you are doing something like removing the target from a processing list.
|
|
#define ELEMENT_DETACH_ON_HOST_DESTROY (1 << 0)
|
|
/**
|
|
* Only elements created with the same arguments given after `argument_hash_start_idx` share an element instance
|
|
* The arguments are the same when the text and number values are the same and all other values have the same ref
|
|
*/
|
|
#define ELEMENT_BESPOKE (1 << 1)
|
|
/// Causes all detach arguments to be passed to detach instead of only being used to identify the element
|
|
/// When this is used your Detach proc should have the same signature as your Attach proc
|
|
#define ELEMENT_COMPLEX_DETACH (1 << 2)
|
|
/**
|
|
* Elements with this flag will have their datum lists arguments compared as is,
|
|
* without the contents being sorted alpha-numerically first.
|
|
* This is good for those elements where the position of the keys matter, like in the case of color matrices.
|
|
*/
|
|
#define ELEMENT_DONT_SORT_LIST_ARGS (1<<3)
|
|
/**
|
|
* Elements with this flag will be ignored by the dcs_check_list_arguments test.
|
|
* A good example is connect_loc, for which it's practically undoable unless we force every signal proc to have a different name.
|
|
*/
|
|
#define ELEMENT_NO_LIST_UNIT_TEST (1<<4)
|
|
|
|
// How multiple components of the exact same type are handled in the same datum
|
|
/// old component is deleted (default)
|
|
#define COMPONENT_DUPE_HIGHLANDER 0
|
|
/// duplicates allowed
|
|
#define COMPONENT_DUPE_ALLOWED 1
|
|
/// new component is deleted
|
|
#define COMPONENT_DUPE_UNIQUE 2
|
|
/**
|
|
* Component uses source tracking to manage adding and removal logic.
|
|
* Add a source/spawn to/the component by using AddComponentFrom(source, component_type, args...)
|
|
* Removing the last source will automatically remove the component from the parent.
|
|
* Arguments will be passed to on_source_add(source, args...); ensure that Initialize and on_source_add have the same signature.
|
|
*/
|
|
#define COMPONENT_DUPE_SOURCES 3
|
|
/// old component is given the initialization args of the new
|
|
#define COMPONENT_DUPE_UNIQUE_PASSARGS 4
|
|
/// each component of the same type is consulted as to whether the duplicate should be allowed
|
|
#define COMPONENT_DUPE_SELECTIVE 5
|
|
|
|
//Redirection component init flags
|
|
#define REDIRECT_TRANSFER_WITH_TURF 1
|
|
|
|
//Arch
|
|
#define ARCH_PROB "probability" //Probability for each item
|
|
#define ARCH_MAXDROP "max_drop_amount" //each item's max drop amount
|
|
|
|
//Ouch my toes!
|
|
#define CALTROP_BYPASS_SHOES (1 << 0)
|
|
#define CALTROP_IGNORE_WALKERS (1 << 1)
|
|
#define CALTROP_SILENT (1 << 2)
|
|
#define CALTROP_NOSTUN (1 << 3)
|
|
#define CALTROP_NOCRAWL (1 << 4)
|
|
|
|
//Ingredient type in datum/component/ingredients_holder
|
|
#define CUSTOM_INGREDIENT_TYPE_EDIBLE 1
|
|
#define CUSTOM_INGREDIENT_TYPE_DRYABLE 2
|
|
|
|
//Icon overlay type in datum/component/ingredients_holder
|
|
#define CUSTOM_INGREDIENT_ICON_NOCHANGE 0
|
|
#define CUSTOM_INGREDIENT_ICON_FILL 1
|
|
#define CUSTOM_INGREDIENT_ICON_SCATTER 2
|
|
#define CUSTOM_INGREDIENT_ICON_STACK 3
|
|
#define CUSTOM_INGREDIENT_ICON_LINE 4
|
|
#define CUSTOM_INGREDIENT_ICON_STACKPLUSTOP 5
|
|
|
|
//declarations for various sources of the edible component.
|
|
|
|
//The standard source of the edible component which is not expected to e removable
|
|
#define SOURCE_EDIBLE_INNATE "innate"
|
|
#define SOURCE_EDIBLE_FRIED "fried"
|
|
#define SOURCE_EDIBLE_GRILLED "grilled"
|
|
#define SOURCE_EDIBLE_MEAT_MAT "meat"
|
|
#define SOURCE_EDIBLE_PIZZA_MAT "pizza"
|