mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-09 16:05:07 +00:00
1f3894e793
My original plan was to just implement materials into crafting so that items would inherit the materials of their components, allowing for some interesting stuff if the material flags of the item allow it. However to my dismay crafting is a pile of old tech debt, starting from the old `del_reqs` and `CheckParts` which still contain lines about old janky bandaids that are no longer in use nor reachable, up to the `customizable_reagent_holder` component which has some harddel issues when your custom food is sliced, and items used in food recipes not being deleted and instead stored inside the result with no purpose as well as other inconsistencies like stack recipes that transfer materials having counterparts in the UI that don't do that. EDIT: Several things have come up while working on this, so I apologise that it ended up changing over 100+ files. I managed to atomize some of the changes, but it's a bit tedious. EDIT: TLDR because I was told this section is too vague and there's too much going on. This PR: - Improves the dated crafting code (not the UI). - replaced `atom/CheckParts` and `crafting_recipe/on_craft_completion` with `atom/on_craft_completion`. - Reqs used in food recipes are now deleted by default and not stored inside the result (they did nothing). - Renames the customizable_reagent_holder comp and improves it (No harddels/ref issues). - Adds a unit test that tries to craft all recipes to see what's wrong (it skips some of the much more specific reqs for now). - In the unit test is also the code to make sure materials of the crafted item and a non-crafted item of the same type are roughly the same, so far only applied to food. - Some mild material/food refactoring around the fact that food item code has been changed to support materials. Improving the backbone of the crafting system. Also materials and food code. 🆑 refactor: Refactored crafting backend. Report possible pesky bugs. balance: the MEAT backpack (from the MEAT cargo pack) may be a smidge different because of code standardization. /🆑
126 lines
4.9 KiB
Plaintext
126 lines
4.9 KiB
Plaintext
/obj/machinery/power/manufacturing/crafter
|
|
name = "manufacturing assembling machine"
|
|
desc = "Assembles (crafts) the set recipe until it runs out of resources. Only resources on it will be used."
|
|
icon_state = "crafter"
|
|
density = FALSE
|
|
circuit = /obj/item/circuitboard/machine/manucrafter
|
|
/// power used per process() spent crafting
|
|
var/power_cost = 5 KILO WATTS
|
|
/// list of weakrefs to crafted items still on the machine that we failed to send forward
|
|
var/list/datum/weakref/withheld = list()
|
|
/// current recipe
|
|
var/datum/crafting_recipe/recipe
|
|
/// crafting component
|
|
var/datum/component/personal_crafting/machine/craftsman
|
|
/// current timer for our crafting
|
|
var/craft_timer
|
|
/// do we use cooking recipes instead
|
|
var/cooking = FALSE
|
|
|
|
/obj/machinery/power/manufacturing/crafter/Initialize(mapload)
|
|
. = ..()
|
|
craftsman = AddComponent(/datum/component/personal_crafting/machine)
|
|
if(ispath(recipe))
|
|
recipe = locate(recipe) in (cooking ? GLOB.cooking_recipes : GLOB.crafting_recipes)
|
|
START_PROCESSING(SSmanufacturing, src)
|
|
|
|
/obj/machinery/power/manufacturing/crafter/examine(mob/user)
|
|
. = ..()
|
|
. += span_notice("It is currently manufacturing <b>[isnull(recipe) ? "nothing. Use a multitool to set it" : recipe.name]</b>.")
|
|
if(isnull(recipe))
|
|
return
|
|
. += span_notice("It needs:")
|
|
for(var/valid_type in recipe.reqs)
|
|
// Check if they're datums, specifically reagents.
|
|
var/datum/reagent/reagent_ingredient = valid_type
|
|
if(istype(reagent_ingredient))
|
|
var/amount = recipe.reqs[reagent_ingredient]
|
|
. += "[amount] unit[amount > 1 ? "s" : ""] of [initial(reagent_ingredient.name)]"
|
|
|
|
var/atom/ingredient = valid_type
|
|
var/amount = recipe.reqs[ingredient]
|
|
|
|
. += "[amount > 1 ? ("[amount]" + " of") : "a"] [initial(ingredient.name)]"
|
|
|
|
/obj/machinery/power/manufacturing/crafter/receive_resource(obj/receiving, atom/from, receive_dir)
|
|
var/turf/machine_turf = get_turf(src)
|
|
if(length(machine_turf.contents) >= MANUFACTURING_TURF_LAG_LIMIT)
|
|
return MANUFACTURING_FAIL
|
|
receiving.forceMove(machine_turf)
|
|
return MANUFACTURING_SUCCESS
|
|
|
|
/obj/machinery/power/manufacturing/crafter/multitool_act(mob/living/user, obj/item/tool)
|
|
. = NONE
|
|
var/list/unavailable = list()
|
|
for(var/datum/crafting_recipe/potential_recipe as anything in cooking ? GLOB.cooking_recipes : GLOB.crafting_recipes)
|
|
var/obj/as_obj = potential_recipe.result
|
|
if(!(ispath(as_obj, /obj) && !ispath(as_obj, /obj/effect) && initial(as_obj.anchored)) && craftsman.is_recipe_available(potential_recipe, user))
|
|
continue
|
|
unavailable += potential_recipe
|
|
var/result = tgui_input_list(usr, "Recipe", "Select Recipe", (cooking ? GLOB.cooking_recipes : GLOB.crafting_recipes) - unavailable)
|
|
if(isnull(result) || result == recipe || !user.can_perform_action(src))
|
|
return ITEM_INTERACT_FAILURE
|
|
recipe = result
|
|
balloon_alert(user, "set")
|
|
return ITEM_INTERACT_SUCCESS
|
|
|
|
/obj/machinery/power/manufacturing/crafter/Destroy()
|
|
. = ..()
|
|
recipe = null
|
|
craftsman = null
|
|
withheld.Cut()
|
|
|
|
/obj/machinery/power/manufacturing/crafter/process(seconds_per_tick)
|
|
send_withheld() // try send any pending stuff
|
|
if(!isnull(craft_timer))
|
|
if(surplus() >= power_cost)
|
|
add_load()
|
|
else
|
|
deltimer(craft_timer)
|
|
craft_timer = null
|
|
say("Power failure!")
|
|
return
|
|
if(isnull(recipe) || !craftsman.check_contents(src, recipe, craftsman.get_surroundings(src)))
|
|
return
|
|
flick_overlay_view(mutable_appearance(icon, "crafter_printing"), recipe.time)
|
|
craft_timer = addtimer(CALLBACK(src, PROC_REF(craft), recipe), recipe.time, TIMER_STOPPABLE)
|
|
|
|
/obj/machinery/power/manufacturing/crafter/proc/send_withheld()
|
|
if(!length(withheld))
|
|
return FALSE
|
|
for(var/datum/weakref/weakref as anything in withheld)
|
|
var/atom/movable/resolved = weakref?.resolve()
|
|
if(isnull(resolved))
|
|
withheld -= weakref
|
|
continue
|
|
if(resolved.loc != loc || send_resource(resolved, dir))
|
|
withheld -= weakref
|
|
return length(withheld)
|
|
|
|
/obj/machinery/power/manufacturing/crafter/proc/craft(datum/crafting_recipe/recipe)
|
|
if(QDELETED(src))
|
|
return
|
|
craft_timer = null
|
|
var/list/prediff = get_overfloor_objects()
|
|
var/result = craftsman.construct_item(src, recipe)
|
|
if(istext(result))
|
|
say("Crafting failed[result]")
|
|
return
|
|
if(isstack(result)) //it doesn't have hands to pick up stacks so let's try to merge them instead
|
|
var/obj/item/stack/stack = result
|
|
stack.merge_with_loc()
|
|
var/list/diff = get_overfloor_objects() - prediff
|
|
for(var/atom/movable/diff_result as anything in diff)
|
|
if(iseffect(diff_result) || ismob(diff_result)) // PLEASE dont stuff cats (or other mobs) into the cat grinder 9000
|
|
continue
|
|
if(isitem(diff_result))
|
|
diff_result.pixel_x += rand(-4, 4)
|
|
diff_result.pixel_y += rand(-4, 4)
|
|
withheld += WEAKREF(diff_result)
|
|
send_withheld()
|
|
|
|
/obj/machinery/power/manufacturing/crafter/cooker
|
|
name = "manufacturing cooking machine" // maybe this shouldnt be available dont wanna make chef useless, though otherwise it would need a sprite
|
|
desc = "Cooks the set recipe until it runs out of resources. Inputs irrelevant to the recipe are ignored."
|
|
cooking = TRUE
|