Files
Bubberstation/code/modules/events/ghost_role
SkyratBot 36bae270a0 [MIRROR] Fixes ghost roles announcing when they fail [MDB IGNORE] (#19175)
* Fixes ghost roles announcing when they fail (#73175)

## About The Pull Request

Fixes ghost roles from being announced if they haven't managed to get a
player to spawn as the mob. We do this by killing and returning when we
fail to spawn a player, while the ruleset isn't processing.

Also makes these rulesets FAIL by default, so they aren't secretly
passing events that don't exist.

## Why It's Good For The Game

Closes https://github.com/tgstation/tgstation/issues/38241
Players no longer get announced about events that aren't occurring, and
weren't intended to be played (like fake announcements), making actual
fake announcements actually fake.

## Changelog

🆑
fix: Announcements of ghost roles don't play if no one accepts the poll
to play as the role.
/🆑

* Fixes ghost roles announcing when they fail

---------

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
2023-02-05 12:44:24 +00:00
..