mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-17 05:03:28 +00:00
244558afdc
* Refactors and defuckulates dbcore. Adds support for min_threads rustg setting, Reduce query delay, Make unit tests faster (#74852) dbcore was very fuckulated. It had 3 lists of queries, but they all had their own current_run style list to support mc_tick_check (as it was already being done before with the undeleted query check, so i can understand why they ~~cargo culted~~ mirrored the behavior) This was silly and confusing and unneeded given two of those loops can only process at most 25 items at a time on default config, plus these were cheap operations (ask rustg to start thread, ask rustg to check on thread). Because of the confusingness of the 6 lists for 3 query states, The code to run pending/queued queries immediately during world shutdown was instead looking at the current_run list for active queries, **meaning those queries got ran twice.** The queued query system only checked the current active query count in fire(), meaning even when there was nothing going on in this subsystem new queries had to wait for the next fire() to run (10 ticks, so 500ms on default config) Those have all been fixed. the config `BSQL_THREAD_LIMIT` has been renamed to `POOLING_MAX_SQL_CONNECTIONS` and its default was lowered to match MAX_CONCURRENT_QUERIES . added a new config `POOLING_MIN_SQL_CONNECTIONS`, allowing you to pre-allocate a reserve of sql threads. The queue processing part of SSdbcore's fire() has been made to not obey mc_tick_check for clarity and to make the following change easier to do: If there is less than `MAX_CONCURRENT_QUERIES` in the active queue, new queries activate immediately. (its ok that there are two configs that kinda do the same thing, POOLING_MAX_SQL_CONNECTIONS maps to max-threads in the mysql crate, and it seems to only be a suggestion, meanwhile MAX_CONCURRENT_QUERIES can't do anything during init, which is when the highest amount of concurrent queries tend to happen.) 🆑 config: database configs have been updated for better control over the connection pool server: BSQL_THREAD_LIMIT has been renamed to POOLING_MAX_SQL_CONNECTIONS, old configs will whine but still work. fix: fixed rare race condition that could lead to a sql query being ran twice during world shutdown. /🆑 I have not tested this pr. * Refactors and defuckulates dbcore. Adds support for min_threads rustg setting, Reduce query delay, Make unit tests faster --------- Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com>