mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-24 00:21:52 +00:00
* Micro-optimize qdel by only permitting one parameter (#80628) Productionizes #80615. The core optimization is this: ```patch - var/hint = to_delete.Destroy(arglist(args.Copy(2))) // Let our friend know they're about to get fucked up. + var/hint = to_delete.Destroy(force) // Let our friend know they're about to get fucked up. ``` We avoid a heap allocation in the form of copying the args over to a new list. A/B testing shows this results in 33% better overtime, and in a real round shaving off a full second of self time and 0.4 seconds of overtime--both of these would be doubled in the event this is merged as the new proc was only being run 50% of the time. * Micro-optimize qdel by only permitting one parameter --------- Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
64 lines
1.8 KiB
Plaintext
64 lines
1.8 KiB
Plaintext
#define BASE_HEAL 4
|
|
|
|
/datum/component/netpod_healing
|
|
|
|
/datum/component/netpod_healing/Initialize(obj/machinery/netpod/pod)
|
|
if (!iscarbon(parent))
|
|
return COMPONENT_INCOMPATIBLE
|
|
|
|
RegisterSignal(pod, COMSIG_BITRUNNER_NETPOD_OPENED, PROC_REF(on_opened))
|
|
|
|
var/mob/living/carbon/player = parent
|
|
player.apply_status_effect(/datum/status_effect/embryonic, STASIS_NETPOD_EFFECT)
|
|
|
|
START_PROCESSING(SSmachines, src)
|
|
|
|
/datum/component/netpod_healing/Destroy(force)
|
|
STOP_PROCESSING(SSmachines, src)
|
|
|
|
var/mob/living/carbon/player = parent
|
|
player.remove_status_effect(/datum/status_effect/embryonic)
|
|
|
|
return ..()
|
|
|
|
/datum/component/netpod_healing/process(seconds_per_tick)
|
|
var/mob/living/carbon/owner = parent
|
|
if(isnull(owner))
|
|
qdel(src)
|
|
return
|
|
|
|
var/need_mob_update = FALSE
|
|
need_mob_update += owner.adjustBruteLoss(-BASE_HEAL * seconds_per_tick, updating_health = FALSE)
|
|
need_mob_update += owner.adjustFireLoss(-BASE_HEAL * seconds_per_tick, updating_health = FALSE)
|
|
need_mob_update += owner.adjustToxLoss(-BASE_HEAL * seconds_per_tick, updating_health = FALSE, forced = TRUE)
|
|
|
|
if(owner.blood_volume < BLOOD_VOLUME_NORMAL)
|
|
owner.blood_volume += BASE_HEAL * seconds_per_tick
|
|
|
|
if(need_mob_update)
|
|
owner.updatehealth()
|
|
|
|
/// Deletes itself when the machine was opened
|
|
/datum/component/netpod_healing/proc/on_opened()
|
|
SIGNAL_HANDLER
|
|
|
|
qdel(src)
|
|
|
|
/datum/status_effect/embryonic
|
|
id = "embryonic"
|
|
alert_type = /atom/movable/screen/alert/status_effect/embryonic
|
|
|
|
/datum/status_effect/embryonic/on_apply()
|
|
ADD_TRAIT(owner, TRAIT_STASIS, TRAIT_STATUS_EFFECT(id))
|
|
return TRUE
|
|
|
|
/datum/status_effect/embryonic/on_remove()
|
|
REMOVE_TRAIT(owner, TRAIT_STASIS, TRAIT_STATUS_EFFECT(id))
|
|
|
|
/atom/movable/screen/alert/status_effect/embryonic
|
|
name = "Embryonic Stasis"
|
|
icon_state = "netpod_stasis"
|
|
desc = "You feel like you're in a dream."
|
|
|
|
#undef BASE_HEAL
|