cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-06-06 06:40:42 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
271fa9e862553cac8bb2ec0d34bb820fea481bcb
Bubberstation/code/datums/components
T
History
LemonInTheDark daf55e611c Cleans up/renames as private some internal var definitions, removes some fucked uses of internal list vars (#75769) 
## About The Pull Request

[Improves the documentation of DCS lists, removes old list of callback
docs that no longer
apply](https://github.com/tgstation/tgstation/commit/c3821d9f5ffaeaa4772f927c819da0c1de0ca27c)

[Adds a second signal register to decal rotating, adds a trait to
objects under a tile. STOP DIRECTLY READING HIDDEN LISTS I SWEAR TO
GOD](https://github.com/tgstation/tgstation/commit/6b3f97a76a6f7d24ab952739a1561633922994e1)

[Removes direct reads of the timer list, they were redundant
mostly](https://github.com/tgstation/tgstation/commit/14fcd9f8a6d1b2d42ec6df3493ebc76fe7c12032)

[Please stop directly reading/modifying the traits list to ensure your
dna rot follows the
brain](https://github.com/tgstation/tgstation/commit/ec0e5237ec2b7c3b7806cb993670acc8ce388bdc)

[Marks internal datum lists as well internal with
_](https://github.com/tgstation/tgstation/pull/75769/commits/57c6577ff61629b8ea792ee37ec4f2490a8e2865)

[57c6577](https://github.com/tgstation/tgstation/pull/75769/commits/57c6577ff61629b8ea792ee37ec4f2490a8e2865)

Does the same to _clear_signal_refs() in hopes of keeping people from
touching it

## Why It's Good For The Game

They pissed me off.

Users should not be touching these lists, especially in ways that make
assumptions about their structure and are thus prone to breaking if that
ever changes.
Most of these are close to zero cost changes, using a wrapper to solve
the problem, or just yeeting it

Two aren't, Decals with a direction have gained a second signal register
on init, and things that sit underfloor (cables/pipes) now get a trait
when inserted there.

This should have a minimal impact on memory/init time, bugging
@Mothblocks about it just in case
2023-06-05 22:25:09 -06:00
..
container_item
…
crafting
Fixes some missing textures on the labcoat suit storage + makes the paper hat a craftable item (#75681)
2023-05-27 22:35:56 -06:00
fantasy
Buff scythes, goats, and plantbgone vs PLANT biotypes (#72889)
2023-01-26 14:29:48 -08:00
food
Cleans up/renames as private some internal var definitions, removes some fucked uses of internal list vars (#75769)
2023-06-05 22:25:09 -06:00
pet_commands
Cosmic Ascension Balance Patch (#74715)
2023-04-27 19:11:13 +01:00
plumbing
Cleans up/renames as private some internal var definitions, removes some fucked uses of internal list vars (#75769)
2023-06-05 22:25:09 -06:00
riding
Stock Part Resprite (#75149)
2023-05-07 23:52:03 -07:00
style
Miners with style meter can now parry kisses (#75148)
2023-05-04 19:54:11 +01:00
_component.dm
Cleans up/renames as private some internal var definitions, removes some fucked uses of internal list vars (#75769)
2023-06-05 22:25:09 -06:00
acid.dm
Burning and acid components fixes and improvements (#74803)
2023-04-23 17:50:58 -06:00
action_item_overlay.dm
Fixes Luminescence actions (#73802)
2023-03-06 17:42:23 -05:00
admin_popup.dm
Renames delta time to be a more obvious name (#74654)
2023-04-11 21:31:07 -07:00
ai_retaliate_advanced.dm
Experiment with replacing weakrefs in AI blackboard with deleting signals, ideally making it easier to work with and harder to cause hard deletes (#74791)
2023-04-23 17:07:17 -06:00
anti_magic.dm
…
aquarium.dm
…
area_sound_manager.dm
…
areabound.dm
…
armor_plate.dm
Refactors armor into dedicated subtypes (#71986)
2022-12-23 16:21:22 -08:00
atmos_reaction_recorder.dm
…
attached_sticker.dm
Turns stickers into a component and an element (#74091)
2023-03-25 21:57:20 +00:00
aura_healing.dm
Renames delta time to be a more obvious name (#74654)
2023-04-11 21:31:07 -07:00
bakeable.dm
Renames delta time to be a more obvious name (#74654)
2023-04-11 21:31:07 -07:00
beetlejuice.dm
Saycode refactor, unit tests, and fixes (#69799)
2022-12-09 20:28:17 +01:00
blood_walk.dm
…
bloodysoles.dm
…
boomerang.dm
Lints Against Unmanaged Local Defines (#74333)
2023-03-29 10:17:03 -07:00
bumpattack.dm
…
burning.dm
Burning and acid components fixes and improvements (#74803)
2023-04-23 17:50:58 -06:00
butchering.dm
New Medical job: The Coroner (#75065)
2023-05-05 21:31:28 -04:00
caltrop.dm
New Medical job: The Coroner (#75065)
2023-05-05 21:31:28 -04:00
chasm.dm
Blobs and Kudzu are killed by chasms. (#75469)
2023-05-16 17:13:01 -06:00
chuunibyou.dm
Adds Chuunibyou Spell + Granter (#74404)
2023-04-03 17:11:00 +02:00
cleaner.dm
afterattack now returns a flag if it's reasonable to suspect the user intends to act on an item (#72320)
2023-01-04 21:10:41 -08:00
clickbox.dm
…
clothing_fov_visor.dm
…
codeword_hearing.dm
Saycode refactor, unit tests, and fixes (#69799)
2022-12-09 20:28:17 +01:00
combo_attacks.dm
makes cursed katana combos into a generic component (#74543)
2023-04-08 16:30:11 +01:00
combustible_flooder.dm
Makes gasses use defines (#75542)
2023-05-27 19:45:22 -04:00
COMPONENT_TEMPLATE.md
…
connect_containers.dm
…
connect_loc_behalf.dm
…
connect_mob_behalf.dm
…
connect_range.dm
…
construction.dm
Lints Against Unmanaged Local Defines (#74333)
2023-03-29 10:17:03 -07:00
conveyor_movement.dm
Being moved around by conveyor belt or tram no longer plays footsteps and wheelchair sounds. (#75732)
2023-05-31 14:29:44 -04:00
cracked.dm
Converts the crackable element to mutable appearances, saves 0.15 seconds of init (#73941)
2023-03-13 16:25:40 -06:00
crate_carrier.dm
…
creamed.dm
Refactors memories to be less painful to add and apply, moves memory detail / text to memory subtypes. Adds some new memories to demonstrate. (#72110)
2023-01-03 11:23:31 -08:00
cult_ritual_item.dm
Refactors Regenerate Organs, and a few organ helpers (#74219)
2023-03-26 17:54:36 +01:00
curse_of_hunger.dm
Renames delta time to be a more obvious name (#74654)
2023-04-11 21:31:07 -07:00
customizable_reagent_holder.dm
Adjusts Reagent Holder Code To Ignore Reagent Container (#72454)
2023-01-06 08:12:00 +01:00
damage_aura.dm
Cosmic Ascension Balance Patch (#74715)
2023-04-27 19:11:13 +01:00
deadchat_control.dm
Lints Against Unmanaged Local Defines (#74333)
2023-03-29 10:17:03 -07:00
dejavu.dm
Refactors Regenerate Organs, and a few organ helpers (#74219)
2023-03-26 17:54:36 +01:00
deployable.dm
…
drift.dm
Being moved around by conveyor belt or tram no longer plays footsteps and wheelchair sounds. (#75732)
2023-05-31 14:29:44 -04:00
earprotection.dm
…
echolocation.dm
Basic pollen-particles for plants pollenating. (#74675)
2023-04-15 21:42:27 -06:00
edit_complainer.dm
…
effect_remover.dm
…
egg_layer.dm
Renames delta time to be a more obvious name (#74654)
2023-04-11 21:31:07 -07:00
electrified_buckle.dm
Renames delta time to be a more obvious name (#74654)
2023-04-11 21:31:07 -07:00
embedded.dm
Renames delta time to be a more obvious name (#74654)
2023-04-11 21:31:07 -07:00
engraved.dm
Refactors memories to be less painful to add and apply, moves memory detail / text to memory subtypes. Adds some new memories to demonstrate. (#72110)
2023-01-03 11:23:31 -08:00
evolutionary_leap.dm
Bileworms won't evolve if they're dead (#73427)
2023-02-15 16:37:55 +01:00
explodable.dm
Removes bad nodamage var from projectiles, fixes Juggernaut / Rust Walker projectiles doing zero damage (#73806)
2023-03-10 17:51:31 -07:00
faction_granter.dm
…
fertile_egg.dm
Renames delta time to be a more obvious name (#74654)
2023-04-11 21:31:07 -07:00
fishing_spot.dm
Memory Expansion! New memories, and prisoners are tattoo'd to the degree of their crime. (#72457)
2023-01-13 20:11:08 +00:00
food_storage.dm
…
force_move.dm
…
fov_handler.dm
Prevents nulls in the always_visible_inventory list (which caused runtimes blocking PM reapplication) (#73400)
2023-02-13 15:56:14 -07:00
fullauto.dm
Renames delta time to be a more obvious name (#74654)
2023-04-11 21:31:07 -07:00
gags_recolorable.dm
…
gas_leaker.dm
…
geiger_sound.dm
…
gps.dm
Refactor, improve, and rename canUseTopic to be can_perform_action (#73434)
2023-02-16 20:22:14 -05:00
grillable.dm
Grilling items now only smoke when the griddle is on (#75265)
2023-05-11 20:00:11 -06:00
ground_sinking.dm
Renames delta time to be a more obvious name (#74654)
2023-04-11 21:31:07 -07:00
growth_and_differentiation.dm
Refactors chicks into basic mobs (#75663)
2023-06-03 14:40:55 +12:00
gunpoint.dm
Gunpoints now take half a second to activate, make gasp sounds, and briefly immobilize the shooter and target, other small balance changes (#74036)
2023-05-02 10:38:02 +12:00
hazard_area.dm
Fixes atmos machinery breaking when the area is edited/renamed via station blueprints & Deletes empty areas, ARCD upgrades (#73850)
2023-03-16 11:32:54 -04:00
healing_touch.dm
Lightgeists won't try to heal toxin damage (#73467)
2023-02-17 15:03:57 -07:00
health_scaling_effects.dm
Replaces Netherworld mob health scaling component (#73629)
2023-02-27 16:27:50 -07:00
heirloom.dm
…
hide_highest_offset.dm
…
holderloving.dm
…
igniter.dm
afterattack now returns a flag if it's reasonable to suspect the user intends to act on an item (#72320)
2023-01-04 21:10:41 -08:00
infective.dm
Refactors armor into dedicated subtypes (#71986)
2022-12-23 16:21:22 -08:00
interaction_booby_trap.dm
Reworks sabotage progression traitor objective (#73750)
2023-03-10 22:58:11 +00:00
irradiated.dm
Renames delta time to be a more obvious name (#74654)
2023-04-11 21:31:07 -07:00
itembound.dm
…
itempicky.dm
…
jetpack.dm
Fixes jetpack "Cannot modify null.oldposition" runtimes (#75355)
2023-05-11 19:58:30 -06:00
jousting.dm
…
keep_me_secure.dm
Renames delta time to be a more obvious name (#74654)
2023-04-11 21:31:07 -07:00
knockoff.dm
…
label.dm
…
light_eater.dm
…
lock_on_cursor.dm
Restores Spell Card targetting behaviour (#73706)
2023-03-10 21:49:23 -07:00
manual_blinking.dm
Refactors Regenerate Organs, and a few organ helpers (#74219)
2023-03-26 17:54:36 +01:00
manual_breathing.dm
Refactors Regenerate Organs, and a few organ helpers (#74219)
2023-03-26 17:54:36 +01:00
material_container.dm
Refactors for material container, ammo box & recycler (#75422)
2023-05-29 20:30:16 +00:00
mind_linker.dm
Re-pr of #70522 "Space Dragon Update: Up Close and Personal" (#75607)
2023-05-31 10:51:07 -07:00
mirage_border.dm
…
mirv.dm
…
mob_harvest.dm
Renames delta time to be a more obvious name (#74654)
2023-04-11 21:31:07 -07:00
multiple_lives.dm
Refactors Suiciding Variable Into Trait (#74150)
2023-03-21 20:06:45 -04:00
mutant_hands.dm
Refactors species mutanthands into human component (#73286)
2023-02-14 17:24:50 -07:00
nuclear_bomb_operator.dm
Implements AddTraits and RemoveTraits procs for adding/removing multiple traits + swag unit test (#74037)
2023-03-18 01:57:06 +00:00
omen.dm
Cursed quirk doesn't go away after triggering a single time (#75477)
2023-05-17 18:47:36 -06:00
on_hit_effect.dm
Cleans up + Improves bows, Sorts files, Adds the Divine Archer clothing, weapon, rite (#74811)
2023-04-29 02:07:44 +00:00
onwear_mood.dm
Fixes a bad argument for onwear comp (#72653)
2023-01-13 17:53:50 -08:00
orbiter.dm
…
overlay_lighting.dm
Refactors High Luminosity Eyes, fixes a ton of bugs related to it as well as qol improvements (#75040)
2023-05-09 15:42:11 -07:00
palette.dm
Adds a eye-dropper right-click function to the painting canvas. (#75571)
2023-05-24 12:06:44 -06:00
parry.dm
Miner Style Points 2: Style on Everyone (#74690)
2023-04-29 02:33:09 +00:00
payment.dm
Optimizes INVOKE_ASYNC by making it a macro and avoiding a proc call (#73264)
2023-03-04 19:33:37 -08:00
pellet_cloud.dm
fixes pellet clouds dealing insane wounds (probably?) (#72359)
2022-12-30 21:52:23 -05:00
phylactery.dm
Refactors Regenerate Organs, and a few organ helpers (#74219)
2023-03-26 17:54:36 +01:00
pinata.dm
Adds Pinatas that can be purchased by cargo and clown operatives! (#73868)
2023-03-13 16:20:34 -06:00
pricetag.dm
…
pry_open_door.dm
Makes "forced" opening and closing of doors way more sane (#73699)
2023-03-07 11:24:44 +00:00
punchcooldown.dm
…
puzzgrid.dm
the inevitable Revert "Refactors admin verbs from giant ass lists into datums" in case stuff breaks (#73206)
2023-02-05 11:44:38 +13:00
radiation_countdown.dm
…
radioactive_emitter.dm
Renames delta time to be a more obvious name (#74654)
2023-04-11 21:31:07 -07:00
README.md
…
reagent_refiller.dm
afterattack now returns a flag if it's reasonable to suspect the user intends to act on an item (#72320)
2023-01-04 21:10:41 -08:00
redirect_attack_hand_from_turf.dm
Fixes arrivals shuttle runtime (#74296)
2023-03-28 23:27:23 -06:00
regenerator.dm
Renames delta time to be a more obvious name (#74654)
2023-04-11 21:31:07 -07:00
religious_tool.dm
Bible refactor (#75350)
2023-05-15 04:27:43 +00:00
remote_materials.dm
Ore silo will put machines off its level on hold, instead of disconnecting (#74990)
2023-04-30 16:06:12 -06:00
rename.dm
…
rot.dm
…
rotation.dm
Refactors sheet crafting to better support directional construction (#74572)
2023-04-15 21:48:34 -06:00
scope.dm
Renames delta time to be a more obvious name (#74654)
2023-04-11 21:31:07 -07:00
seclight_attachable.dm
…
sect_nullrod_bonus.dm
Cleans up + Improves bows, Sorts files, Adds the Divine Archer clothing, weapon, rite (#74811)
2023-04-29 02:07:44 +00:00
seethrough.dm
Fixes critical plane masters improperly not being readded in show_to (#72604)
2023-01-31 10:25:38 +00:00
shell.dm
…
shielded.dm
Stops shields getting broken by pillows and disablers. (#75759)
2023-06-01 16:26:10 -04:00
shrink.dm
…
shuttle_cling.dm
Being moved around by conveyor belt or tram no longer plays footsteps and wheelchair sounds. (#75732)
2023-05-31 14:29:44 -04:00
shy_in_room.dm
…
shy.dm
…
sign_language.dm
Adds TTS to the game. Players can select their own voices in preferences. (#74775)
2023-05-15 16:21:54 -07:00
simple_access.dm
…
singularity.dm
Renames delta time to be a more obvious name (#74654)
2023-04-11 21:31:07 -07:00
sitcomlaughter.dm
…
sizzle.dm
…
slippery.dm
[no gbp] Golem mineral functionality tweaks/fixes (#75343)
2023-05-12 20:51:39 -06:00
smooth_tunes.dm
Optimizes particle holders (#74524)
2023-04-16 10:12:14 +02:00
soul_stealer.dm
Fixes soul-stealer component being broken (#73285)
2023-02-10 13:15:40 -07:00
soulstoned.dm
Implements AddTraits and RemoveTraits procs for adding/removing multiple traits + swag unit test (#74037)
2023-03-18 01:57:06 +00:00
sound_player.dm
…
spawner.dm
March into Mapness: Meateor (#74070)
2023-03-31 19:40:29 -07:00
spill.dm
Refactors memories to be less painful to add and apply, moves memory detail / text to memory subtypes. Adds some new memories to demonstrate. (#72110)
2023-01-03 11:23:31 -08:00
spin2win.dm
Renames delta time to be a more obvious name (#74654)
2023-04-11 21:31:07 -07:00
spinny.dm
Renames delta time to be a more obvious name (#74654)
2023-04-11 21:31:07 -07:00
spirit_holding.dm
Fixes a bad assignment of parent in spirit holding component (#72999)
2023-01-29 19:42:04 +08:00
splattercasting.dm
Lints Against Unmanaged Local Defines (#74333)
2023-03-29 10:17:03 -07:00
squashable.dm
…
squeak.dm
Pet Command Component + Regal Rats can order their subjects around (#71590)
2022-12-13 12:34:23 -08:00
stationloving.dm
Fixes inability to declare war as nukies (#72217)
2022-12-26 22:58:13 -08:00
stationstuck.dm
Lints Against Unmanaged Local Defines (#74333)
2023-03-29 10:17:03 -07:00
strong_pull.dm
Trying to grab something restricted by HAUL gauntlets now has a Balloon alert. (#72758)
2023-01-18 23:22:18 -08:00
subtype_picker.dm
…
summoning.dm
afterattack now returns a flag if it's reasonable to suspect the user intends to act on an item (#72320)
2023-01-04 21:10:41 -08:00
supermatter_crystal.dm
Fixes the supermatter not dusting you when you fall on top of it from a z-level (#74535)
2023-04-06 16:26:14 -06:00
surgery_initiator.dm
Implanted foreign bodyparts will resist being removed on species change (#74701)
2023-04-14 20:50:22 +02:00
swabbing.dm
…
swarming.dm
…
tackle.dm
Refactors Regenerate Organs, and a few organ helpers (#74219)
2023-03-26 17:54:36 +01:00
tactical.dm
…
takes_reagent_appearance.dm
Reagent soup / Soup rework / Stoves - A kitchen expansion (#74205)
2023-04-07 19:42:49 -06:00
tameable.dm
You no longer have to sacrifice your soul to give a mouse sentience. (#72782)
2023-01-21 09:41:32 -08:00
tattoo.dm
…
technointrovert.dm
…
technoshy.dm
…
temporary_body.dm
Mafia update: Return to body when the game ends (#75258)
2023-06-05 13:18:20 -05:00
tether.dm
…
thermite.dm
Cleans up thermite component code (#74825)
2023-04-21 13:11:52 -06:00
tippable.dm
You can tip flashed borgs (#75539)
2023-05-21 21:37:10 -06:00
toggle_suit.dm
…
transforming.dm
New inhand icons for light tubes, makes latex balloons craftable, and various other fixes/improvements (#74576)
2023-04-09 19:51:35 -04:00
trapdoor.dm
…
twohanded.dm
Split weapons_and_items.dmi icons into their own categories (#74363)
2023-04-06 08:30:57 +12:00
udder.dm
Renames delta time to be a more obvious name (#74654)
2023-04-11 21:31:07 -07:00
unbreakable.dm
Basic Mob Spiders II: Elements (#73202)
2023-02-10 12:40:31 -07:00
unobserved_actor.dm
Refactor Statue & Creature unobserved behaviour (#73630)
2023-02-26 17:58:51 -07:00
uplink.dm
Replaceable Traitor Uplinks (#74315)
2023-04-05 16:54:22 +01:00
usb_port.dm
…
vacuum.dm
…
wearertargeting.dm
…
wet_floor.dm
…

README.md

Datum Component System (DCS)

Concept

Loosely adapted from /vg/. This is an entity component system for adding behaviours to datums when inheritance doesn't quite cut it. By using signals and events instead of direct inheritance, you can inject behaviours without hacky overloads. It requires a different method of thinking, but is not hard to use correctly. If a behaviour can have application across more than one thing. Make it generic, make it a component. Atom/mob/obj event? Give it a signal, and forward it's arguments with a SendSignal() call. Now every component that want's to can also know about this happening.

HackMD page for an introduction to the system as a whole.

See/Define signals and their arguments in __DEFINES\components.dm

Reference in New Issue View Git Blame Copy Permalink