mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-02-02 12:29:36 +00:00
ec67ffb340
* Properly accounts for byond tick fuckery in runechat code (#74388) ## About The Pull Request Ok so like, the agreed upon assumption for "verb like code" (stuff that triggers when a client sents a network packet to the server), is it runs in verb time, that sliver of time between maptick and the start of the next tick. We thought MeasureText worked like this. It doesn't. It will, occasionally, resume not during verb time but as a sleeping proc, at the start of the next tick. Before the MC has started working. This appears to only happen when the tick is already overloaded. Unfortunately, it doesn't invoke after all sleeping procs as we were lead to believe, but just like, like any sleeping proc. This means it fights with the mc for cpu time, and doesn't respect the TICK_CHECK macro we use to ensure this situation doesn't happen. SOOO lets use a var off the MC instead, tracking when it last fired. We can use this in companion with TICK_CHECK to ensure verbs schedule properly if they invoke before the MC runs. Hopefully this should fix 0 cpu when running at highpop Thanks to Kylerace and MrStonedOne for suffering together with me on this, I hate this engine. * Properly accounts for byond tick fuckery in runechat code --------- Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>