Files
Bubberstation/code/modules/power/singularity
SkyratBot 0459e4a9e1 [MIRROR] Fix incorrectly passed biotype args in take_overall_damage [MDB IGNORE] (#19170)
* Fix incorrectly passed biotype args in take_overall_damage (#73203)

## About The Pull Request

The linters in #73202 revealed to me that `heal_overall_damage` was
overridden wrong in `carbon` and left out an argument, meaning that
plausibly some places that didn't provide an argument for `stamina`
probably had an off-by-one error with args and wouldn't apply them
properly.
I fixed that in that PR because it was using it. Then I noticed that the
same problem exists in `take_overall_damage` so I am fixing that too.

I don't know if this was linked to any actual bugs, but it might cause
some. They'd be hard to spot because it'd be for stuff like "a
shadowperson with a prosthetic takes damage to their prosthetic if not
in darkness" and probably nobody would even get into that situation let
alone notice to report it.

## Why It's Good For The Game

We want arguments to do what they are supposed to do.

## Changelog

🆑
fix: Biotypes will be more consistently applied when taking damage, pod
and shadowperson prosthetic limbs won't be corroded due to light levels.
fix: Podperson and Wooden Golem prosthetic limbs won't be corroded by
having a hungry tummy.
/🆑

* Fix incorrectly passed biotype args in take_overall_damage

---------

Co-authored-by: Jacquerel <hnevard@gmail.com>
2023-02-08 02:29:06 +00:00
..